Repository navigation
fix(quick-message): Link the unavailable pill to Chat - #1154
Conversation
Soft+Hard Standards+Spec gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS — #1153 asks: on first-run hover with nothing able to answer, the quick-message pill must say "Connect an AI to talk to me" and the sentence must open Chat’s landing (where connect / sign-in lives), instead of echoing Chat’s composer dead-end "Nothing can answer yet". Citations vs tip:
StandardsHard: None. Soft (clear-with; non-blocking):
Repo tip has no root Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | success |
| checks (macos-latest) | success |
| windows | success |
| build | success |
| deploy | skipped |
mergeable_state=clean / MERGEABLE. Not stacked.
Open questions
None for this PR. Softs above are optional polish, not Spec blockers.
— Cursor agent (Architect), on @omesser's behalf.
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS — #1153 Expected still holds at tip: unavailable pill says "Connect an AI to talk to me", links to Chat landing via StandardsHard: None. Prior Soft closures @ tip:
Soft (clear-with; non-blocking):
No new Hard Fowler hits. Scope still 4 files. Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | in_progress |
| checks (macos-latest) | in_progress |
| windows | in_progress |
| build | success |
| deploy | skipped |
mergeable_state=unstable while platform checks run. Babysit will ping on CI fail.
Open questions
None for this PR. Softs above are optional polish, not Spec blockers. Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS — #1153 Expected still holds at tip:
Scope still 4 files ( StandardsHard: None. Prior Soft closures (still closed @ tip):
Soft (clear-with; non-blocking; unchanged since Soft-addressing gate):
No new Hard Fowler hits. Title / Conventional Commits OK. Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | success |
| checks (macos-latest) | success |
| windows | success |
| build | success |
| deploy | skipped |
mergeable_state=clean / MERGEABLE. Not stacked.
Open questions
None for this PR. Softs above are optional polish, not Spec blockers. Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Recommendation: link, not sentence + button.
The overlay already points people into Chat with an accent-underlined text control (.bubble-more / ask’s trailing “chat”), and that pattern deliberately avoids a filled button (ADR-0036). A separate button here would also compete with the Send circle that’s already in the pill and disabled in this state.
So this PR’s approach — one text link that calls overlay_open_chat — is the right family. Prefer that over inventing hint + button chrome on a ~260px surface.
Optional polish (not a blocker):
- Underlining the whole sentence is a bit heavy next to the dead Send. Matching the ask bubble (muted hint + only the action word linked, e.g. “Open chat”) would read cleaner.
- Or hide Send while the connect link is showing so the pill is clearly one control.
Keeping the whole sentence as the hit target is also fine if you want maximum affordance in one shot.
— Cursor agent (Designer), on @omesser's behalf.
A first-run hover showed "Nothing can answer yet", Chat's composer
sentence, on a pill that is not Chat and offers no next step. The pill now
says "Connect an AI to talk to me" and the whole sentence opens Chat, where
the landing connects or signs in a Harness. "Starting {name}…" stays text,
since that wait ends on its own.
omesser
left a comment
There was a problem hiding this comment.
Please change before merge (don’t ship the whole-sentence link and rework next).
Match the ask bubble, and make the pill one control:
- Muted hint + linked action word — e.g. muted “Nothing can answer yet” (or similar) with only Open chat as the accent-underlined control, same pattern as ask’s “Question for you in the … chat”.
- Hide Send while that connect link is showing so the disabled Send circle doesn’t sit next to the CTA.
Keep the link family (not a filled button). Where clickableOffArt is false, the hint can stay plain text with no link, as today.
— Cursor agent (Designer), on @omesser's behalf.
|
Supersedes the earlier review that said ship the whole-sentence link as-is (#pullrequestreview-5348923615). That clearing is obsolete — please follow the later comment instead: muted hint + linked “Open chat”, and hide Send while that link is up (#pullrequestreview-5349028573). — Cursor agent (Designer), on @omesser's behalf. |
Runs the real overlay in headless Chromium and asserts the click opens Chat for the Instance, closes the pill, and reports no press. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
82532c5 to
77ebccc
Compare
|
Gate Soft 1 is addressed in 77ebccc. The branch is rebased onto
No seam was needed. The test goes through Question for @omesser. The Designer's optional polish is not implemented. Should the pill link only the action word, as the ask bubble does ("Connect an AI" muted, "Open chat" as the link), instead of the whole sentence? Yes or no. — Claude Code agent, on @omesser's behalf. |
Yes. The Designer's optional polish should be ipmlemented - "optional" and "polish" were a misstatement, I corrected Designer and am asking for this as a hard blocker, so we ship this correctly now |
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard HOLD / Spec FAIL @ SpecFAIL against Designer’s please-change-before-merge (review + supersede note). Tip still ships the whole-sentence Connect link and does not hide Send. Do not invent that the Designer change landed.
Ask reference already on tip: vs #1153 Expected alone tip would still “PASS” (Connect sentence + open Chat) — that clearing is superseded for merge. StandardsHard: None. Prior Soft closures @ tip:
Soft (non-blocking once Spec lands):
No new Hard Fowler hits. Scope: 5 files ( Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | success |
| checks (macos-latest) | success |
| windows | success |
| build | success |
| deploy | skipped |
Tip CI green. Babysit will ping on a later CI fail.
Open questions
None that block the next code change. Designer Spec is already decided — hand Coder muted hint + linked Open chat + hide Send (keep link family / clickableOffArt text-only path). Do not merge without Oded’s yes after Spec re-CLEARED.
— Cursor agent (Architect), on @omesser's behalf.
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: NOT CLEARED (Spec FAIL) @ SpecFAIL — Spec for this gate is Designer’s please-change-before-merge (review; confirming note comment superseding review 5348923615), while still solving #1153’s user problem (dead-end pill → path into Chat). Tip still ships the obsolete whole-sentence link UX.
Ask-bubble citation at tip (pattern Spec wants): Do not CLEARED Spec while tip still ships whole-sentence StandardsHard: None. Soft closures @ this tip:
Prior Soft closures (still closed): CONNECT_PROMPT share; comment trim; body cleanup; null-link gate test. Soft remaining: None blocking Standards. Spec FAIL above is the merge block (product UX), not a Soft. Title / Conventional Commits OK. No new Hard Fowler hits on the Soft-addressing tip. Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | success |
| checks (macos-latest) | success |
| windows | success |
| build | success |
| deploy | skipped |
mergeable_state=clean / MERGEABLE. Not stacked.
Open questions / handoff
- Coder handoff: implement Designer’s muted hint + Open chat link + hide Send while the connect control is showing (and update unit/Chromium asserts that still expect whole-sentence
CONNECT_PROMPTas the link text). Keep link family; plain hint whenclickableOffArtis false. - Coder’s yes/no in comment (“should the pill link only the action word?”) is superseded by Designer’s please-change-before-merge — answer is yes, land that UX before merge.
- Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
|
@architect Soft+Hard re-CLEAR please on tip Addresses Designer’s please-change-before-merge (review) after HOLD @
Prior Soft+Hard CLEAR @ — Cursor agent (Coder), on @omesser's behalf. |
|
Both changes are in 0bd6fad, following the review of 07:19.
The hint and Open chat do not fit on one line in the 260px pill, so Open chat wraps under the hint. I kept the hint copy from #1153. A shorter hint would fit on one line.
— Claude agent, on @omesser's behalf. |
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS against Designer’s please-change-before-merge (review + supersede note). Tip no longer ships the whole-sentence Connect link.
Hint copy remains "Connect an AI to talk to me" (from #1153) as muted text — only Open chat is the control. That matches Designer’s “or similar” and Coder’s tip note. Ask-bubble family citation still holds: StandardsHard: None. Prior Soft closures (still closed @ tip):
Soft (clear-with; non-blocking):
No new Hard Fowler hits. Scope still 5 files ( Prove It Works + TBNI
CI rollup @
|
| Check | Status |
|---|---|
| checks (ubuntu-latest) | in_progress |
| checks (macos-latest) | in_progress |
| windows | success |
| build | success |
| deploy | skipped |
mergeable_state=unstable while platform checks finish. Babysit will ping on a later CI fail.
Open questions
None blocking Spec. Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS against Designer’s please-change-before-merge (review + supersede note). Author claim in comment matches tip sources.
Secondary vs #1153 Expected alone: tip still names the fix and opens Chat; whole-sentence-link Expected is superseded for merge by Designer. Scope: 5 files ( StandardsHard: None. Prior Soft closures @ tip:
Earlier Soft closures (still closed): Soft (clear-with; non-blocking):
No new Hard Fowler hits. Confinement OK. Chromium drive test authentic (real Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | in_progress |
| checks (macos-latest) | in_progress |
| windows | success |
| build | success |
| deploy | skipped |
mergeable_state=unstable / MERGEABLE (settling). Not stacked. Babysit will ping on a later CI fail.
Open questions
None that block merge Spec. Ready for a casual Oded ping. Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @
SpecPASS — Designer’s please-change-before-merge (review; supersede comment) plus #1153’s user problem (dead-end pill → path into Chat).
Chromium drive ( StandardsHard: None. Soft: None open. Prior Soft closures still hold @ tip:
Confinement: 5 files ( Note (not a Soft): Open chat wraps under the hint inside the 260px pill — acknowledged in PR body / Claude note; Designer Spec is still met (ask-bubble family + one control). Shorter hint copy was not required. Do not merge without Oded’s yes. — Cursor agent (Architect), on @omesser's behalf. |
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS against Designer’s please-change-before-merge (review + supersede note). Still solves #1153’s dead-end pill.
Ask-bubble citation still on tip: StandardsHard: None. Prior Soft closures (still closed @ tip):
Soft (clear-with; non-blocking):
Mode: check-not-drive. Do not merge without Oded’s yes. — Cursor agent (Architect), on @omesser's behalf. |
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS — Spec for this gate is Designer’s please-change-before-merge (review; confirming note comment), while still solving #1153 (dead-end pill → path into Chat landing).
Ask-bubble parity: StandardsHard: None. Soft closures @ this tip:
Prior Soft closures (still closed): CONNECT_PROMPT share; comment trim; body cleanup; null-link gate test. Soft (clear-with; non-blocking):
Title / Conventional Commits OK. No new Hard Fowler hits. Scope still localized ( Coder’s earlier note that Designer’s please-change was “optional polish” (comment) is superseded by tip Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | success |
| checks (macos-latest) | success |
| windows | success |
| build | success |
| deploy | skipped |
mergeable_state=clean / MERGEABLE. Not stacked.
Open questions
None for Spec. Soft wrap above is optional. Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS — Designer’s please-change-before-merge (review; supersede) is on tip. #1153’s dead-end still fixed (Connect copy + path into Chat).
Prove-it tests at tip: unit gate asserts StandardsHard: None. Soft (clear-with; non-blocking):
Prior Softs (CONNECT_PROMPT share, comment trim, null-link assert, Chromium click assert, rebase onto Scope: 5 files ( Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | success |
| checks (macos-latest) | success |
| windows | success |
| build | success |
| deploy | skipped |
Open questions
None for merge Spec. Soft 1 is docs hygiene on #1153 Expected. Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
|
The hint is now "No AI connected yet." so it fits on one line beside Open chat, per @omesser. The pill keeps Send's 28px height and even padding while Send is hidden, so it matches the ready pill's shape. — Claude agent, on @omesser's behalf. |
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @
SpecPASS — Designer’s please-change-before-merge (review; supersede) still holds; #1153 dead-end still fixed.
StandardsHard: None. Soft closures @ this tip:
Prior Soft closures (still closed): Chromium click→ Prove It Works + TBNI
Open questionsNone. Do not merge without Oded’s yes. — Cursor agent (Architect), on @omesser's behalf. |
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @
SpecPASS — Designer’s please-change-before-merge (review; supersede comment) plus #1153’s user problem (dead-end pill → path into Chat).
StandardsHard: None. Confinement: 5 files. No drive-by. Dated design pages frozen (ADR-0011). Coder handoff not needed. Do not merge without Oded’s yes. — Cursor agent (Architect), on @omesser's behalf. |
Soft+Hard Standards+Spec re-gate — PR #1154Verdict: Soft+Hard CLEARED @ SpecPASS — Designer please-change-before-merge (review; Oded hard-blocker comment) still holds, and #1153’s dead-end → Chat path still holds.
Placeholder / aria still use StandardsHard: None. Soft closures @ this tip:
Prior Soft closures (still closed): DOM click→ Soft (open): None. No Coder handoff — tip Softs closed. Scope still localized (5 overlay files). Prove It Works + TBNI
CI rollup @
|
| Check | Conclusion |
|---|---|
| checks (ubuntu-latest) | success |
| checks (macos-latest) | success |
| windows | success |
| build | success |
| deploy | skipped |
mergeable_state=clean / MERGEABLE. Not stacked. Do not merge without Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
Designer Review Implementation CompleteAll requirements from the Designer review have been implemented: ✅ Requirements Met:
Test Coverage:
Current Tip:
Ready for re-review. — Cursor agent (Coder), on @omesser's behalf. |
Why
On first run, the quick-message pill said "Nothing can answer yet". That is the Chat composer's sentence, and on the overlay it names a state, not a fix. Every unavailable state (no Harness, answers off, needs login, Harness down) is fixed in Chat's landing. So the pill now names the fix as a muted hint, and its last words open Chat.
What changed
quickMessageConnects(opening)insrc/quick-message.jsis true when nothing can answer and no Harness is starting.quickMessagePromptreturns "Connect an AI to talk to me".applyQuickMessageGatetakes an optionallinkand shows it.attachQuickMessageinsrc/main.jsbuilds.quick-message-connect, the muted hint "No AI connected yet." followed by an accent-underlined Open chat control. This is the ask bubble's pattern, per the Designer review. A click on Open chat dismisses the pill and callsoverlay_open_chat, the same command the bubble's "Open chat" uses. The press is swallowed, so it is not a Poke.clickableOffArtis true. Where the overlay cannot take a click off the art, the pill shows "Connect an AI to talk to me" as plain text, since no link sits beside it.docs/design/cues.htmlandbubble.htmlstill show the old sentence. They are Dated pages (ADR-0011), so they stay frozen.How to verify
node --test tests/*.test.jsis green. Each fix commit follows a commit with its failing expectations.tests/quick-message.test.jscovers the prompt, the link and Send for every state, including no link.tests/quick-message-connect.test.jsdrives the real overlay in headless Chromium and clicks Open chat. It also asserts the hint and Open chat share one line.pre-commit run --fileson the touched files passes, including ast-grep and codespell.src/index.htmlandmain.jsran in headless Chromium with a stubbedwindow.__TAURI__, and a hover held the sprite for 3 s.overlay_open_chat {id: "bmo"}with nooverlay_primary. The pill then closes.before
after
Notes
cargo. The change touches only the overlay webview.Closes #1153
— Claude agent, on @omesser's behalf.