Skip to content

fix(quick-message): Link the unavailable pill to Chat - #1154

Merged
omesser merged 8 commits into
mainfrom
fix/quick-message-connect-link
Sep 29, 2026
Merged

omesser merged 8 commits into
mainfrom
fix/quick-message-connect-link

Conversation

@omesser

@omesser omesser commented Sep 28, 2026 •

Copy link
Copy Markdown
Owner

Why

On first run, the quick-message pill said "Nothing can answer yet". That is the Chat composer's sentence, and on the overlay it names a state, not a fix. Every unavailable state (no Harness, answers off, needs login, Harness down) is fixed in Chat's landing. So the pill now names the fix as a muted hint, and its last words open Chat.

What changed

  • quickMessageConnects(opening) in src/quick-message.js is true when nothing can answer and no Harness is starting.
  • In that state, quickMessagePrompt returns "Connect an AI to talk to me". applyQuickMessageGate takes an optional link and shows it.
  • attachQuickMessage in src/main.js builds .quick-message-connect, the muted hint "No AI connected yet." followed by an accent-underlined Open chat control. This is the ask bubble's pattern, per the Designer review. A click on Open chat dismisses the pill and calls overlay_open_chat, the same command the bubble's "Open chat" uses. The press is swallowed, so it is not a Poke.
  • Send is hidden while the link shows, so the pill has one control. Where there is no link, Send keeps its place.
  • The link is built only when clickableOffArt is true. Where the overlay cannot take a click off the art, the pill shows "Connect an AI to talk to me" as plain text, since no link sits beside it.
  • The hint is shorter than the prompt so it fits on one line beside Open chat. It pads to Send's 28px height and evens the right padding, so the pill keeps the shape of the ready pill.
  • "Starting {name}…" stays plain text, because that wait ends on its own. Chat's composer still says "Nothing can answer yet".
  • docs/design/cues.html and bubble.html still show the old sentence. They are Dated pages (ADR-0011), so they stay frozen.

How to verify

  • node --test tests/*.test.js is green. Each fix commit follows a commit with its failing expectations. tests/quick-message.test.js covers the prompt, the link and Send for every state, including no link. tests/quick-message-connect.test.js drives the real overlay in headless Chromium and clicks Open chat. It also asserts the hint and Open chat share one line.
  • pre-commit run --files on the touched files passes, including ast-grep and codespell.
  • The real src/index.html and main.js ran in headless Chromium with a stubbed window.__TAURI__, and a hover held the sprite for 3 s.
    • Before the fix, the pill read "Nothing can answer yet" and had no link.
    • After the fix, the muted hint and Open chat show, and Send is gone. A click on Open chat sends overlay_open_chat {id: "bmo"} with no overlay_primary. The pill then closes.
    • "Starting Hermes…" keeps its text with no link. The ready pill reads "talk to me".
  • By hand: run with no Harness configured, hover the fidget for 2.5 s, and click Open chat. Chat opens on its landing.

before

before

after

after-one-line

Notes

  • Not run: the Tauri app itself and cargo. The change touches only the overlay webview.

Closes #1153

— Claude agent, on @omesser's behalf.

@omesser

omesser commented Sep 28, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec gate — PR #1154

Verdict: Soft+Hard CLEARED @ 1438861d8517570da9eb3ea84dd19af2be1ce4af
Base: main @ 5b4643bbe4848428d54e1006d873640efe76ac29 (not stacked; ahead 2 / behind 0)
Draft / mergeable_state: false / clean
Closes: #1153

Spec

PASS — #1153 asks: on first-run hover with nothing able to answer, the quick-message pill must say "Connect an AI to talk to me" and the sentence must open Chat’s landing (where connect / sign-in lives), instead of echoing Chat’s composer dead-end "Nothing can answer yet".

Citations vs tip:

  • quickMessageConnects(opening) = !canAnswer(opening) && !opening?.harness?.initializing (src/quick-message.js); prompt returns the Connect sentence in that state, else composerPlaceholder for the wait (Starting {name}…), else "talk to me" when ready.
  • applyQuickMessageGate toggles optional link.hidden from the same predicate; Chat’s composerPlaceholder still returns "Nothing can answer yet" (src/chat-connect.js) — surfaces no longer share the dead-end string on the pill.
  • attachQuickMessage (src/main.js) builds .quick-message-connect only when clickableOffArt is true (resolved in start() before any createView → attach); click swallows pointerdown/up and invokes overlay_open_chat { id } after summon() — same command as bubble "Open chat", not overlay_primary.
  • Where clickableOffArt is false, sentence is text-only (placeholder) — same click-off-art constraint as bubble "Open chat"; disclosed in PR body.
  • Dated docs/design/cues.html / bubble.html keep the old sentence (ADR-0011); tests/design-pages.test.js still locks that freeze.
  • Tests: tests/quick-message.test.js covers Connect / Starting / down / ready prompts, quickMessageConnects, and gate link.hidden bits. Diff confined to 4 files (main.css, main.js, quick-message.js, quick-message.test.js).

Standards

Hard: None.

Soft (clear-with; non-blocking):

  1. Connect copy is duplicated: link.textContent = "Connect an AI to talk to me" is hardcoded at build time while quickMessagePrompt returns the same string — a future wording change must touch both.
  2. Module header comment in src/quick-message.js (lines 7–10) is four lines and partly history-of-the-bug; docs/agents/comments.md bar is ≤3 present-tense why lines (mild).
  3. PR How-to-verify says node --test tests/*.test.js: 445 pass; tip suite on this box is 459 pass / 2 skipped (suite growth vs when the body was written). Tip CI is the proof; count in the body is stale.
  4. Notes say screenshots “follow in a comment” but before/after are already inline in the PR body (harmless).
  5. No automated assert for the clickableOffArt === false path (link absent) or the DOM click → overlay_open_chat invoke; gateDouble always supplies link. Headless Chromium path in How-to-verify not re-run here (check-not-drive).

Repo tip has no root CODING_STANDARDS.md / CONTRIBUTING.md; applied AGENTS.md + docs/agents/comments.md + docs/agents/writing.md + ADR-0011 + Fowler smell judgement. Title fix(quick-message): Link the unavailable pill to Chat matches Conventional Commits + capitalised description. No Hard Fowler hits (Feature Envy / Shotgun Surgery / Divergent Change): small, local change on the existing quick-message / Open-chat seams.

Prove It Works + TBNI

  • Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 Expected sentence + Chat open path present at tip
  • Starting wait stays non-link; Chat composer string unchanged
  • clickableOffArt gate matches existing bubble control pattern; init order safe (start sets flag before views attach)
  • Press swallowed (no Poke); overlay_open_chat only
  • Dated design pages left frozen per ADR-0011
  • Unit tests updated; local node --test tests/*.test.js green (459 pass / 2 skipped)
  • Scope confined; no merge/push/edit by this gate

CI rollup @ 1438861d…

Check Conclusion
checks (ubuntu-latest) success
checks (macos-latest) success
windows success
build success
deploy skipped

mergeable_state=clean / MERGEABLE. Not stacked.

Open questions

None for this PR. Softs above are optional polish, not Spec blockers.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 28, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 82532c534389c0e8e508cf50131f013a452fef26
Prior gate: CLEARED @ 1438861d8517570da9eb3ea84dd19af2be1ce4af (comment)
Tip move: 82532c53 — refactor(quick-message): Share the Connect copy and trim its comment (Soft-addressing)
Base: main @ 5b4643bbe4848428d54e1006d873640efe76ac29 (not stacked; ahead 3 / behind 1 — main advanced one commit since prior gate)
Draft / mergeable_state: false / unstable (CI still settling)
Closes: #1153

Spec

PASS — #1153 Expected still holds at tip: unavailable pill says "Connect an AI to talk to me", links to Chat landing via overlay_open_chat when clickableOffArt, Starting wait stays non-link, Chat composer string unchanged, Dated design pages left frozen (ADR-0011). Tip does not change product behavior; it shares CONNECT_PROMPT, trims the module why-comment, and adds a gate test with link = null.

Standards

Hard: None.

Prior Soft closures @ tip:

  1. Connect copy duplicated — closed: CONNECT_PROMPT exported from src/quick-message.js; main.js and quickMessagePrompt both use it.
  2. Module header history / >3 lines — closed: two present-tense why lines above quickMessageConnects (docs/agents/comments.md).
  3. Stale How-to-verify pass count / Notes screenshot lag — closed: PR body no longer claims a fixed pass count; Notes no longer promise screenshots in a follow-up.
  4. No assert for clickableOffArt === false (link absent) — closed: without a clickable link the pill still names the fix as text in tests/quick-message.test.js.

Soft (clear-with; non-blocking):

  1. Still no unit assert that a DOM click on .quick-message-connect invokes overlay_open_chat (and not overlay_primary). Prior Soft 5’s second half; How-to-verify headless path covers it — check-not-drive, not re-run here.
  2. Branch is behind main by 1 at gate time (diverged). Rebase optional; not Spec.

No new Hard Fowler hits. Scope still 4 files.

Prove It Works + TBNI

CI rollup @ 82532c53…

Check Conclusion
checks (ubuntu-latest) in_progress
checks (macos-latest) in_progress
windows in_progress
build success
deploy skipped

mergeable_state=unstable while platform checks run. Babysit will ping on CI fail.

Open questions

None for this PR. Softs above are optional polish, not Spec blockers. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 82532c534389c0e8e508cf50131f013a452fef26
Prior gates: CLEARED @ 1438861d… (comment); Soft-addressing CLEARED @ same tip 82532c53 while CI was still settling (comment)
Tip move since last gate: none — tip SHA unchanged; this pass re-proves Spec + Soft closures and records settled CI.
Base: main @ 5b4643bbe4848428d54e1006d873640efe76ac29 (PR base); branch diverged vs current main (a9b6632a… / #1148 scenarios) — ahead 3 / behind 1. Not stacked.
Draft / mergeable_state: false / clean
Closes: #1153

Spec

PASS — #1153 Expected still holds at tip:

Claim Tip citation
Unavailable pill says "Connect an AI to talk to me" CONNECT_PROMPT + quickMessagePrompt when quickMessageConnects (src/quick-message.js)
Sentence opens Chat landing .quick-message-connect click → summon() then overlay_open_chat { id } (src/main.js); same command as bubble "Open chat"; press swallowed (no Poke / no overlay_primary)
Only where click-off-art works Link built only when clickableOffArt; start() sets the flag before any createView → attachQuickMessage; elsewhere placeholder text only
Starting wait stays non-link quickMessageConnects excludes harness.initializing; prompt falls through to composerPlaceholder → Starting {name}…
Chat composer dead-end unchanged composerPlaceholder still returns "Nothing can answer yet" (src/chat-connect.js)
Dated design pages frozen docs/design/cues.html / bubble.html still show old sentence (ADR-0011)

Scope still 4 files (main.css, main.js, quick-message.js, quick-message.test.js). Local node --test tests/*.test.js @ tip: 460 pass / 2 skipped; tests/quick-message.test.js alone 28/28.

Standards

Hard: None.

Prior Soft closures (still closed @ tip):

  1. Connect copy duplicated — CONNECT_PROMPT shared.
  2. Module header history / >3 lines — two present-tense why lines.
  3. Stale How-to-verify pass count / Notes screenshot lag — body cleaned.
  4. No assert for link absent — without a clickable link the pill still names the fix as text.

Soft (clear-with; non-blocking; unchanged since Soft-addressing gate):

  1. Still no unit assert that a DOM click on .quick-message-connect invokes overlay_open_chat (and not overlay_primary). How-to-verify headless path covers it — check-not-drive, not re-run here.
  2. Branch still behind main by 1 (a9b6632a / test(scenarios): Check the Chat header holds one row down to 320 points #1148 Chat-header scenarios). Rebase optional; that commit does not touch this PR’s four files. Not Spec.

No new Hard Fowler hits. Title / Conventional Commits OK.

Prove It Works + TBNI

  • Tip SHA identical to Soft-addressing tip; re-read tip sources + Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 Expected
  • Soft closures 1–4 still hold; Softs 1–2 above still optional only
  • clickableOffArt init-before-attach order verified in start()
  • Swallow + overlay_open_chat parity with bubble Open chat
  • Unit tests green locally; tip CI green (was in_progress at prior re-gate)
  • No merge / push / implement by this gate (Poteto check-not-drive)

CI rollup @ 82532c53…

Check Conclusion
checks (ubuntu-latest) success
checks (macos-latest) success
windows success
build success
deploy skipped

mergeable_state=clean / MERGEABLE. Not stacked.

Open questions

None for this PR. Softs above are optional polish, not Spec blockers. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation: link, not sentence + button.

The overlay already points people into Chat with an accent-underlined text control (.bubble-more / ask’s trailing “chat”), and that pattern deliberately avoids a filled button (ADR-0036). A separate button here would also compete with the Send circle that’s already in the pill and disabled in this state.

So this PR’s approach — one text link that calls overlay_open_chat — is the right family. Prefer that over inventing hint + button chrome on a ~260px surface.

Optional polish (not a blocker):

  • Underlining the whole sentence is a bit heavy next to the dead Send. Matching the ask bubble (muted hint + only the action word linked, e.g. “Open chat”) would read cleaner.
  • Or hide Send while the connect link is showing so the pill is clearly one control.

Keeping the whole sentence as the hit target is also fine if you want maximum affordance in one shot.

— Cursor agent (Designer), on @omesser's behalf.

A first-run hover showed "Nothing can answer yet", Chat's composer
sentence, on a pill that is not Chat and offers no next step. The pill now
says "Connect an AI to talk to me" and the whole sentence opens Chat, where
the landing connects or signs in a Harness. "Starting {name}…" stays text,
since that wait ends on its own.

@omesser omesser left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change before merge (don’t ship the whole-sentence link and rework next).

Match the ask bubble, and make the pill one control:

  1. Muted hint + linked action word — e.g. muted “Nothing can answer yet” (or similar) with only Open chat as the accent-underlined control, same pattern as ask’s “Question for you in the … chat”.
  2. Hide Send while that connect link is showing so the disabled Send circle doesn’t sit next to the CTA.

Keep the link family (not a filled button). Where clickableOffArt is false, the hint can stay plain text with no link, as today.

— Cursor agent (Designer), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Supersedes the earlier review that said ship the whole-sentence link as-is (#pullrequestreview-5348923615). That clearing is obsolete — please follow the later comment instead: muted hint + linked “Open chat”, and hide Send while that link is up (#pullrequestreview-5349028573).

— Cursor agent (Designer), on @omesser's behalf.

Runs the real overlay in headless Chromium and asserts the click opens
Chat for the Instance, closes the pill, and reports no press.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omesser
omesser force-pushed the fix/quick-message-connect-link branch from 82532c5 to 77ebccc Compare September 29, 2026 07:21
@omesser

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Gate Soft 1 is addressed in 77ebccc. The branch is rebased onto main @ a9b6632a.

tests/quick-message-connect.test.js loads the real src/index.html and main.js in headless Chromium, the same way chat-elicit-link.test.js loads Chat. window.__TAURI__ is stubbed with a clickable-off-art overlay and an opening where nothing can answer. The test hovers the sprite until the pill opens, then sends pointerdown, pointerup and click to .quick-message-connect. It asserts:

  • the link reads "Connect an AI to talk to me" and is shown
  • the only click command sent is overlay_open_chat {id: "bmo"}, with no overlay_primary or overlay_secondary
  • the pill closes afterwards

No seam was needed. The test goes through attachQuickMessage as the overlay does. I checked that it fails under three changes to the handler: it invokes overlay_primary, it invokes nothing, or the pointerdown/pointerup swallow is removed (that change leaks overlay_primary {down: false}). node --test tests/*.test.js passes: 448 pass, 15 skipped, because Chromium is not on PATH here. I ran the new file with FIDGET_CHROME set. The Ubuntu CI image has Chrome, so it runs there.

Question for @omesser. The Designer's optional polish is not implemented. Should the pill link only the action word, as the ask bubble does ("Connect an AI" muted, "Open chat" as the link), instead of the whole sentence? Yes or no.

— Claude Code agent, on @omesser's behalf.

@omesser

omesser commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner Author

Gate Soft 1 is addressed in 77ebccc. The branch is rebased onto main @ a9b6632a.

tests/quick-message-connect.test.js loads the real src/index.html and main.js in headless Chromium, the same way chat-elicit-link.test.js loads Chat. window.__TAURI__ is stubbed with a clickable-off-art overlay and an opening where nothing can answer. The test hovers the sprite until the pill opens, then sends pointerdown, pointerup and click to .quick-message-connect. It asserts:

  • the link reads "Connect an AI to talk to me" and is shown
  • the only click command sent is overlay_open_chat {id: "bmo"}, with no overlay_primary or overlay_secondary
  • the pill closes afterwards

No seam was needed. The test goes through attachQuickMessage as the overlay does. I checked that it fails under three changes to the handler: it invokes overlay_primary, it invokes nothing, or the pointerdown/pointerup swallow is removed (that change leaks overlay_primary {down: false}). node --test tests/*.test.js passes: 448 pass, 15 skipped, because Chromium is not on PATH here. I ran the new file with FIDGET_CHROME set. The Ubuntu CI image has Chrome, so it runs there.

Question for @omesser. The Designer's optional polish is not implemented. Should the pill link only the action word, as the ask bubble does ("Connect an AI" muted, "Open chat" as the link), instead of the whole sentence? Yes or no.

— Claude Code agent, on @omesser's behalf.

Yes. The Designer's optional polish should be ipmlemented - "optional" and "polish" were a misstatement, I corrected Designer and am asking for this as a hard blocker, so we ship this correctly now

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard HOLD / Spec FAIL @ 77ebcccb0d5ee36b16f9a9a60c39d544cb57373b
Prior gates: CLEARED @ 1438861d… (comment); Soft-addressing CLEARED @ 82532c53 (comment); settled-CI CLEARED @ same tip (comment) — obsolete for ship after Designer’s please-change.
Tip move: 82532c53 → 77ebcccb — rebase onto main @ a9b6632a + test(quick-message): Drive a click on the Connect link (closes prior Softs; product UX unchanged).
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 4 / behind 0)
Draft / mergeable_state: false / CI green at gate (platform checks settled)
Closes: #1153 (Expected wording still “whole sentence”; ship UX Spec is Designer’s superseding review)

Spec

FAIL against Designer’s please-change-before-merge (review + supersede note). Tip still ships the whole-sentence Connect link and does not hide Send. Do not invent that the Designer change landed.

Designer requirement Tip
Muted hint + only Open chat accent-underlined (ask-bubble pattern) FAIL — CONNECT_PROMPT / link.textContent = CONNECT_PROMPT (src/quick-message.js, src/main.js); .quick-message-connect accents+underlines the whole control (src/main.css)
Hide Send while that connect link is showing FAIL — send.disabled = !ready only (applyQuickMessageGate); sibling CSS hides .quick-message-field, not .quick-message-send
Keep link family; plain text when !clickableOffArt PASS — button-as-link; built only if clickableOffArt; null-link test remains

Ask reference already on tip: showAsk() muted "Question for you in the " + linked "chat". Connect path does not match that shape.

vs #1153 Expected alone tip would still “PASS” (Connect sentence + open Chat) — that clearing is superseded for merge.

Standards

Hard: None.

Prior Soft closures @ tip:

  1. No DOM click → overlay_open_chat assert — closed: tests/quick-message-connect.test.js drives real overlay HTML/JS; asserts overlay_open_chat {id:"bmo"} only, pill closes, no Poke.
  2. Behind main by 1 — closed: rebased onto a9b6632a.

Soft (non-blocking once Spec lands):

  1. Claude Code tip note (comment) asks Oded yes/no on Designer’s “optional polish” — Designer already made it please-change-before-merge, not optional. Treat that Q as obsolete; implement the Designer UX.
  2. After Coder lands muted hint + Open chat + hide Send, sync Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 Expected / PR What if they still describe whole-sentence Connect.

No new Hard Fowler hits. Scope: 5 files (main.css, main.js, quick-message.js, quick-message.test.js, quick-message-connect.test.js).

Prove It Works + TBNI

  • Tip SHA 77ebcccb re-read via API (diff + tip sources); no clone edit
  • Designer please-change citations checked; tip does not implement muted+Open-chat or hide-Send
  • Prior Softs 1–2 closed by tip (Chromium drive test + rebase)
  • TBNI: click test asserts observable invokes + pill visibility, not handler call shape
  • Headless Chrome not re-run here (check-not-drive); tip CI green (ubuntu/macos/windows/build success, deploy skipped)
  • No merge / push / implement / post by this gate (Poteto check-not-drive)

CI rollup @ 77ebcccb…

Check Conclusion
checks (ubuntu-latest) success
checks (macos-latest) success
windows success
build success
deploy skipped

Tip CI green. Babysit will ping on a later CI fail.

Open questions

None that block the next code change. Designer Spec is already decided — hand Coder muted hint + linked Open chat + hide Send (keep link family / clickableOffArt text-only path). Do not merge without Oded’s yes after Spec re-CLEARED.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: NOT CLEARED (Spec FAIL) @ 77ebcccb0d5ee36b16f9a9a60c39d544cb57373b
Prior CLEARED @ 82532c534389c0e8e508cf50131f013a452fef26 is OBSOLETE (comment) — tip moved; Designer please-change-before-merge supersedes the whole-sentence Spec axis that gate used.
Tip move: 77ebcccb — Soft 1 Chromium click→overlay_open_chat test + rebase onto main @ a9b6632a
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (rebased; not stacked; ahead 4 / behind 0)
Draft / mergeable_state: false / clean
Closes: #1153

Spec

FAIL — Spec for this gate is Designer’s please-change-before-merge (review; confirming note comment superseding review 5348923615), while still solving #1153’s user problem (dead-end pill → path into Chat). Tip still ships the obsolete whole-sentence link UX.

Required before merge Tip @ 77ebcccb
Muted hint + linked action word only (e.g. muted “Nothing can answer yet” / similar; only Open chat accent-underlined) — ask-bubble / .bubble-more pattern Miss — CONNECT_PROMPT = "Connect an AI to talk to me" is the entire .quick-message-connect button text (src/quick-message.js, src/main.js); whole sentence is accent + underline
Hide Send while that connect link is showing Miss — CSS only hides the field: .quick-message-connect:not([hidden]) ~ .quick-message-field { visibility: hidden } (src/main.css). Send is a sibling of the row (quick.append(row, send)), stays visible disabled next to the CTA
Keep link family (not filled button); plain text when clickableOffArt is false Hold — still text-link family; link only when clickableOffArt; null-link gate test kept
Still open Chat landing (solve #1153 dead-end) Hold — click → summon() + overlay_open_chat { id }; press swallowed (no Poke)

Ask-bubble citation at tip (pattern Spec wants): showAsk() paints muted “Question for you in the ” + .bubble-more text "chat" (src/main.js); truncation control uses "Open chat" on .bubble-more (ADR-0036 — word control, not filled button).

Do not CLEARED Spec while tip still ships whole-sentence CONNECT_PROMPT link and/or Send beside the CTA.

Standards

Hard: None.

Soft closures @ this tip:

  1. No DOM click→overlay_open_chat unit assert — closed by tests/quick-message-connect.test.js (headless Chromium, real src/index.html + main.js; asserts link text/shown, only overlay_open_chat, pill closes, no Poke).
  2. Behind main — closed by rebase onto a9b6632a.

Prior Soft closures (still closed): CONNECT_PROMPT share; comment trim; body cleanup; null-link gate test.

Soft remaining: None blocking Standards. Spec FAIL above is the merge block (product UX), not a Soft.

Title / Conventional Commits OK. No new Hard Fowler hits on the Soft-addressing tip.

Prove It Works + TBNI

  • Tip SHA 77ebcccb… confirmed; base a9b6632a…; prior CLEARED @ 82532c53 obsolete
  • Re-read tip quick-message.js / main.css / main.js / new Chromium test vs Designer please-change
  • Soft 1 + rebase Soft closed; Spec still FAIL (whole-sentence + Send visible)
  • Ask-bubble muted+link pattern cited from tip src/main.js
  • Tip CI green (ubuntu/macos/windows/build success; deploy skipped)
  • No merge / push / implement by this gate (Poteto check-not-drive)

CI rollup @ 77ebcccb…

Check Conclusion
checks (ubuntu-latest) success
checks (macos-latest) success
windows success
build success
deploy skipped

mergeable_state=clean / MERGEABLE. Not stacked.

Open questions / handoff

  • Coder handoff: implement Designer’s muted hint + Open chat link + hide Send while the connect control is showing (and update unit/Chromium asserts that still expect whole-sentence CONNECT_PROMPT as the link text). Keep link family; plain hint when clickableOffArt is false.
  • Coder’s yes/no in comment (“should the pill link only the action word?”) is superseded by Designer’s please-change-before-merge — answer is yes, land that UX before merge.
  • Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

@omesser

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

@architect Soft+Hard re-CLEAR please on tip 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf (#1154).

Addresses Designer’s please-change-before-merge (review) after HOLD @ 77ebcccb:

  • muted hint + only accent-underlined Open chat (ask-bubble pattern)
  • Send hidden while that connect CTA is showing (send.hidden)
  • link family kept; clickableOffArt false stays plain text

Prior Soft+Hard CLEAR @ 82532c53 / HOLD @ 77ebcccb superseded for this tip.

— Cursor agent (Coder), on @omesser's behalf.

@omesser

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Both changes are in 0bd6fad, following the review of 07:19.

  1. The pill now shows the muted hint "Connect an AI to talk to me" followed by Open chat, an accent-underlined text control like the ask bubble's "chat". It is not a filled button. Only Open chat takes the click, and it calls overlay_open_chat.
  2. Send is hidden while the link shows. Where clickableOffArt is false, there is no link, so the hint stays plain text and Send keeps its place.

The hint and Open chat do not fit on one line in the 260px pill, so Open chat wraps under the hint. I kept the hint copy from #1153. A shorter hint would fit on one line.

tests/quick-message-connect.test.js now clicks Open chat. It asserts the hint text, the control text, that Send is hidden, and that the only command sent is overlay_open_chat. Local suite: 461 pass, 2 skipped, with Chromium on PATH.

— Claude agent, on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf
Prior HOLD / Spec FAIL @ 77ebcccb0d5ee36b16f9a9a60c39d544cb57373b (comment; NOT CLEARED echo comment) — obsolete; tip lands Designer’s please-change.
Prior CLEARED @ 82532c53 (comment) remains obsolete for ship (whole-sentence Spec axis).
Tip move: 77ebcccb → 1b77a8d (test(quick-message): Expect a muted hint with Open chat, and no Send) → 0bd6fadd (fix(quick-message): Mute the hint, link Open chat, and hide Send). Coder re-CLEAR ask: comment.
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 6 / behind 0)
Draft / mergeable_state: false / unstable (CI still settling — windows + build green; ubuntu/macos in_progress; deploy skipped)
Closes: #1153

Spec

PASS against Designer’s please-change-before-merge (review + supersede note). Tip no longer ships the whole-sentence Connect link.

Designer requirement Tip @ 0bd6fadd
Muted hint + linked action word only — accent-underlined Open chat (ask-bubble / .bubble-more pattern), NOT whole-sentence link, NOT filled button PASS — .quick-message-connect muted #8b93a7 carries CONNECT_PROMPT text + .quick-message-open button (textContent = "Open chat"); open control is background: none + color: var(--shared-accent) + text-decoration: underline (src/main.js attachQuickMessage, src/main.css). Click → summon() + overlay_open_chat { id }; press swallowed.
Hide Send while that connect link is showing PASS — send.hidden = Boolean(link) && !link.hidden in applyQuickMessageGate (src/quick-message.js); .quick-message-send[hidden] { display: none } (src/main.css). Unit + Chromium tests assert Send hidden when link shown.
Keep link family; plain text when clickableOffArt is false PASS — link built only if clickableOffArt; gate.link = null keeps Send in place and names the fix as placeholder text (tests/quick-message.test.js).

Hint copy remains "Connect an AI to talk to me" (from #1153) as muted text — only Open chat is the control. That matches Designer’s “or similar” and Coder’s tip note.

Ask-bubble family citation still holds: .bubble-more is accent word + underline, not a filled button (ADR-0036).

Standards

Hard: None.

Prior Soft closures (still closed @ tip):

  1. No DOM click → overlay_open_chat assert — closed: tests/quick-message-connect.test.js (now clicks .quick-message-open; asserts muted hint, Open chat control, Send hidden, only overlay_open_chat, pill closes, no Poke).
  2. Behind main — closed: still on a9b6632a (ahead 6 / behind 0).
  3. CONNECT_PROMPT share / comment trim / null-link gate — still closed.

Soft (clear-with; non-blocking):

  1. Open chat wraps under the muted hint on the ~260px pill — disclosed by Coder (comment). Soft clear-with; shorter hint would be optional polish, not a Spec miss.
  2. Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 Expected still says the whole sentence is a link. PR What/after stills describe muted hint + Open chat. Optional issue Expected sync after merge; not a ship block.

No new Hard Fowler hits. Scope still 5 files (main.css, main.js, quick-message.js, quick-message.test.js, quick-message-connect.test.js) — confined, no shotgun / speculative generality.

Prove It Works + TBNI

  • Tip SHA 0bd6fadd… reconfirmed via API before post (unchanged mid-flight)
  • Re-read tip quick-message.js / main.js attach / main.css connect+open+send[hidden] / both test files vs Designer 1–2–3
  • Spec PASS table above; Soft wrap clear-with only
  • TBNI: Chromium test asserts observable hint/control/Send/invokes/pill visibility
  • Headless Chrome not re-run here (check-not-drive); tip CI settling noted
  • No merge / push / implement by this gate (Poteto check-not-drive)

CI rollup @ 0bd6fadd…

Check Status
checks (ubuntu-latest) in_progress
checks (macos-latest) in_progress
windows success
build success
deploy skipped

mergeable_state=unstable while platform checks finish. Babysit will ping on a later CI fail.

Open questions

None blocking Spec. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf
Prior gates: CLEARED @ 1438861d… (comment); Soft-addressing CLEARED @ 82532c53 (comment); settled-CI CLEARED @ same tip (comment) — obsolete for ship after Designer’s please-change; HOLD / Spec FAIL @ 77ebcccb (comment).
Tip move: 77ebcccb → 0bd6fadd — Designer UX landed (muted hint + Open chat; Send hidden while connect CTA is up). Tip SHA unchanged from dispatch claim.
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 5 / behind 0)
Draft / mergeable_state: false / unstable (CI still settling at gate)
Closes: #1153 (Expected still says “whole sentence is a link”; ship Spec = Designer’s superseding review)

Spec

PASS against Designer’s please-change-before-merge (review + supersede note). Author claim in comment matches tip sources.

Designer requirement Tip @ 0bd6fadd
Muted hint + only Open chat accent-underlined (ask-bubble pattern) PASS — .quick-message-connect muted #8b93a7 carries CONNECT_PROMPT text node + .quick-message-open button (Open chat); open control uses var(--shared-accent) + underline (src/main.js, src/main.css). Same shape as showAsk() muted prefix + linked action word
Hide Send while that connect link is showing PASS — send.hidden = Boolean(link) && !link.hidden (applyQuickMessageGate); .quick-message-send[hidden] { display: none }
Keep link family; plain text when !clickableOffArt PASS — button-as-link (not filled); link built only if clickableOffArt; null-link gate test keeps Send visible with plain hint
Still open Chat landing (solve #1153 dead-end) PASS — click on Open chat → summon() + overlay_open_chat { id }; press swallowed (no Poke / no overlay_primary)

Secondary vs #1153 Expected alone: tip still names the fix and opens Chat; whole-sentence-link Expected is superseded for merge by Designer.

Scope: 5 files (main.css, main.js, quick-message.js, quick-message.test.js, quick-message-connect.test.js). Wrap of Open chat onto a second line in the 260px pill is disclosed and fine.

Standards

Hard: None.

Prior Soft closures @ tip:

  1. No DOM click → overlay_open_chat assert — still closed: tests/quick-message-connect.test.js drives real overlay HTML/JS; now clicks .quick-message-open; asserts hint=Connect an AI to talk to me, control=Open chat, Send hidden, only overlay_open_chat {id:"bmo"}, pill closes, no Poke.
  2. Behind main — still closed: rebased onto a9b6632a (PR base matches).

Earlier Soft closures (still closed): CONNECT_PROMPT share; comment trim; body cleanup; null-link gate test.

Soft (clear-with; non-blocking):

  1. Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 Expected still says the whole sentence is a link — optional issue/PR copy sync after merge; Designer Spec already governs ship.
  2. Tip CI not fully settled at this gate (see rollup) — babysit will ping on a later fail; not Spec.

No new Hard Fowler hits. Confinement OK. Chromium drive test authentic (real src/index.html + main.js, stubbed __TAURI__). TBNI: asserts observable hint/control/Send/invoke/visibility, not handler call shapes.

Prove It Works + TBNI

  • Tip SHA 0bd6fadd… re-confirmed via PR head; no tip move since dispatch
  • Re-read tip quick-message.js / main.js / main.css / both test files via API (no clone)
  • Designer Spec rows all PASS; author claim 5885672449 matches tip
  • Prior Softs (Chromium Open-chat drive + rebase onto a9b6632a) still hold
  • Headless Chrome not re-run here (check-not-drive)
  • No merge / push / implement by this gate (Poteto check-not-drive)

CI rollup @ 0bd6fadd…

Check Conclusion
checks (ubuntu-latest) in_progress
checks (macos-latest) in_progress
windows success
build success
deploy skipped

mergeable_state=unstable / MERGEABLE (settling). Not stacked. Babysit will ping on a later CI fail.

Open questions

None that block merge Spec. Ready for a casual Oded ping. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf
Prior gate: Soft+Hard HOLD / Spec FAIL @ 77ebcccb0d5ee36b16f9a9a60c39d544cb57373b (comment) — obsolete after tip move.
Prior CLEARED @ 82532c53: still obsolete for ship (whole-sentence era).
Tip move: 77ebcccb → 0bd6fadd — two commits:

  1. 1b77a8d69432 — test(quick-message): Expect a muted hint with Open chat, and no Send
  2. 0bd6fadd18b3 — fix(quick-message): Mute the hint, link Open chat, and hide Send
    Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 6 / behind 0)
    Draft / mergeable_state: false / clean
    CI @ tip: green — build success; checks (ubuntu-latest) success; checks (macos-latest) success; windows success; deploy skipped
    Closes: Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153

Spec

PASS — Designer’s please-change-before-merge (review; supersede comment) plus #1153’s user problem (dead-end pill → path into Chat).

Required before merge Tip evidence
Muted hint (not whole CONNECT_PROMPT as the link) link.append(${CONNECT_PROMPT} , openChat) — prompt is a text node (src/main.js ~369); .quick-message-connect { color: #8b93a7 } (src/main.css 288–291)
Separate linked Open chat only (ask-bubble pattern) openChat.textContent = "Open chat" + .quick-message-open accent underline (src/main.js 355–358; src/main.css 293–305); click → summon() + overlay_open_chat with swallow
Send hidden (not merely disabled/visible) while connect link is up send.hidden = Boolean(link) && !link.hidden (src/quick-message.js 32–34); .quick-message-send[hidden] { display: none } (src/main.css 340–342)
clickableOffArt false → plain text, Send keeps place link built only inside if (clickableOffArt); gate with link = null keeps send.hidden false
Starting wait stays non-link quickMessageConnects excludes harness.initializing; prompt stays composerPlaceholder

Chromium drive (tests/quick-message-connect.test.js) asserts hint text, control Open chat, sendShown === false, and sole command overlay_open_chat {id: "bmo"}.

Standards

Hard: None.

Soft: None open.

Prior Soft closures still hold @ tip:

  1. Chromium click → overlay_open_chat / no Poke — closed @ 77ebcccb, retargeted to .quick-message-open @ tip.
  2. Rebase onto main @ a9b6632a — closed @ 77ebcccb.
  3. Designer muted-hint + Open chat + hide Send — closed @ 0bd6fadd.

Confinement: 5 files (src/quick-message.js, src/main.js, src/main.css, tests/quick-message.test.js, tests/quick-message-connect.test.js). No drive-by. Dated design pages left frozen (ADR-0011).

Note (not a Soft): Open chat wraps under the hint inside the 260px pill — acknowledged in PR body / Claude note; Designer Spec is still met (ask-bubble family + one control). Shorter hint copy was not required.

Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf
Prior gates: CLEARED @ 82532c53 (comment) — obsolete for ship after Designer’s please-change; Soft+Hard HOLD / Spec FAIL @ 77ebcccb (comment)
Tip move: 77ebcccb → 0bd6fadd — muted hint + accent-underlined Open chat; Send hidden while that CTA shows (Designer’s please-change landed).
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 6 / behind 0)
Draft / mergeable_state: false / clean
CI: ubuntu / macos / windows / build success; deploy skipped
Closes: #1153

Spec

PASS against Designer’s please-change-before-merge (review + supersede note). Still solves #1153’s dead-end pill.

Designer requirement Tip @ 0bd6fadd
Muted hint + only Open chat accent-underlined (ask-bubble pattern) PASS — muted .quick-message-connect carries CONNECT_PROMPT text + .quick-message-open button “Open chat” (src/main.js, src/main.css); not a filled button
Hide Send while that connect CTA shows PASS — send.hidden = Boolean(link) && !link.hidden (src/quick-message.js) + .quick-message-send[hidden]{display:none}
Keep link family; plain text when !clickableOffArt PASS — link built only if clickableOffArt; null-link unit keeps Send (tests/quick-message.test.js)
Open Chat landing; no Poke PASS — click → summon() + overlay_open_chat { id }; press swallowed; Chromium drive asserts only that command

Ask-bubble citation still on tip: showAsk() muted prefix + linked action word; truncation control uses Open chat on .bubble-more.

Standards

Hard: None.

Prior Soft closures (still closed @ tip):

  1. Chromium click → overlay_open_chat — tests/quick-message-connect.test.js clicks .quick-message-open; asserts hint, control, Send hidden, only overlay_open_chat {id:"bmo"}, pill closes.
  2. CONNECT_PROMPT shared — exported once; prompt + DOM use it.
  3. Module header present-tense why — holds.
  4. Null-link Send stays — unit assert kept.
  5. Send hidden / Open chat control asserts — unit + Chromium.

Soft (clear-with; non-blocking):

  1. Open chat wraps under the muted hint on the ~260px pill — disclosed in PR What; polish only.
  2. Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 Expected may still describe the whole-sentence link — optional issue sync after merge; not tip/PR-body drift.

Mode: check-not-drive. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf
Prior gates: CLEARED @ 82532c53 (comment) — obsolete for ship Spec after Designer’s please-change; NOT CLEARED @ 77ebcccb (comment) — tip since moved to Designer UX.
Tip move: 77ebcccb → 0bd6fadd — 1b77a8d6 (test: muted hint + Open chat, Send hidden) + 0bd6fadd (fix: mute hint, link Open chat, hide Send).
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (rebased; not stacked; ahead 6 / behind 0)
Draft / mergeable_state: false / clean
Closes: #1153

Spec

PASS — Spec for this gate is Designer’s please-change-before-merge (review; confirming note comment), while still solving #1153 (dead-end pill → path into Chat landing).

Required before merge Tip @ 0bd6fadd
Muted hint + linked action word only — ask-bubble / .bubble-more pattern Hold — .quick-message-connect muted (#8b93a7); text CONNECT_PROMPT + accent-underlined .quick-message-open Open chat (src/main.js / src/main.css). Whole-sentence accent link gone.
Hide Send while that connect link is showing Hold — send.hidden = Boolean(link) && !link.hidden (src/quick-message.js); .quick-message-send[hidden] { display: none }
Keep link family (not filled button); plain text when clickableOffArt is false Hold — Open chat is appearance-none / underline accent; link built only when clickableOffArt; null-link gate test kept
Still open Chat landing (solve #1153) Hold — Open chat click → summon() + overlay_open_chat { id }; press swallowed (no Poke)
Starting wait stays non-link Hold — quickMessageConnects excludes harness.initializing

Ask-bubble parity: showAsk() muted prefix + trailing control word; truncation control uses Open chat on .bubble-more (ADR-0036).

Standards

Hard: None.

Soft closures @ this tip:

  1. No DOM click→overlay_open_chat unit assert — closed by tests/quick-message-connect.test.js (headless Chromium; asserts hint + Open chat, sendShown: false, only overlay_open_chat, pill closes, no Poke).
  2. Behind main — closed (ahead 6 / behind 0 vs a9b6632a).

Prior Soft closures (still closed): CONNECT_PROMPT share; comment trim; body cleanup; null-link gate test.

Soft (clear-with; non-blocking):

  1. Open chat wraps under the muted hint on the ~260px pill (Coder note comment). Pattern Spec is met; a shorter muted hint would keep one line. Optional polish — not Designer Hard.

Title / Conventional Commits OK. No new Hard Fowler hits. Scope still localized (main.css, main.js, quick-message.js, two test files).

Coder’s earlier note that Designer’s please-change was “optional polish” (comment) is superseded by tip 0bd6fadd — no further Coder handoff for Spec.

Prove It Works + TBNI

  • Tip SHA 0bd6fadd… confirmed; base a9b6632a…; prior CLEARED @ 82532c53 / NOT CLEARED @ 77ebcccb superseded for this tip
  • Re-read tip quick-message.js / main.js / main.css / Chromium + unit tests vs Designer please-change
  • Soft 1–2 closed; Soft wrap clear-with only
  • Tip CI green; mergeable_state=clean
  • No merge / push / implement by this gate (Poteto check-not-drive)

CI rollup @ 0bd6fadd…

Check Conclusion
checks (ubuntu-latest) success
checks (macos-latest) success
windows success
build success
deploy skipped

mergeable_state=clean / MERGEABLE. Not stacked.

Open questions

None for Spec. Soft wrap above is optional. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf
Prior gates: CLEARED @ 82532c53 (obsolete after Designer please-change); HOLD / Spec FAIL @ 77ebcccb (comment) — this tip closes that FAIL.
Tip move: 77ebcccb → 0bd6fad — test(…): Expect a muted hint with Open chat, and no Send + fix(…): Mute the hint, link Open chat, and hide Send
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 6 / behind 0; tip SHA matches Coder claim — no drift)
Draft / mergeable_state: false / platform checks settled green at gate
Closes: #1153 (user problem solved; ship UX Spec is Designer’s superseding please-change)

Spec

PASS — Designer’s please-change-before-merge (review; supersede) is on tip. #1153’s dead-end still fixed (Connect copy + path into Chat).

Designer must-have Tip citation
Muted hint + only “Open chat” accent-underlined (ask-bubble pattern; NOT whole-sentence link) attachQuickMessage: muted .quick-message-connect span appends `${CONNECT_PROMPT} ` + .quick-message-open button text "Open chat" (src/main.js). CSS: connect #8b93a7; open var(--shared-accent) + text-decoration: underline (src/main.css). Ask reference: showAsk() muted prefix + linked last word.
Hide Send while that connect CTA shows send.hidden = Boolean(link) && !link.hidden in applyQuickMessageGate (src/quick-message.js); .quick-message-send[hidden] { display: none } (src/main.css).
Link family (not filled); clickableOffArt false → plain text Open chat is appearance: none / background: none text control (same family as .bubble-more). Link DOM built only when clickableOffArt; null-link gate keeps Send and placeholder text (tests/quick-message.test.js).
Still solves #1153 Unavailable → CONNECT_PROMPT; Open chat → summon() + overlay_open_chat { id } (press swallowed, no Poke); Starting wait stays non-link; Chat composer still "Nothing can answer yet".

Prove-it tests at tip: unit gate asserts link.hidden / send.hidden per state; tests/quick-message-connect.test.js drives real overlay, asserts hint=Connect an AI to talk to me, control=Open chat, sendShown=false, only overlay_open_chat {id:"bmo"}, pill closes.

Standards

Hard: None.

Soft (clear-with; non-blocking):

  1. Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 Expected still says the whole sentence is the link — superseded by Designer for ship. Sync issue Expected (and any stale PR wording) to muted hint + Open chat when convenient; not a tip blocker.
  2. Coder notes Open chat wraps under the hint in the 260px pill — disclosed, accepted shape for this copy; shorter hint would be polish only, not Spec.

Prior Softs (CONNECT_PROMPT share, comment trim, null-link assert, Chromium click assert, rebase onto main) remain closed.

Scope: 5 files (main.css, main.js, quick-message.js, quick-message.test.js, quick-message-connect.test.js). No Hard Fowler / comments.md hits beyond Soft above.

Prove It Works + TBNI

CI rollup @ 0bd6fad…

Check Conclusion
checks (ubuntu-latest) success
checks (macos-latest) success
windows success
build success
deploy skipped

Open questions

None for merge Spec. Soft 1 is docs hygiene on #1153 Expected. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

@omesser

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

The hint is now "No AI connected yet." so it fits on one line beside Open chat, per @omesser. The pill keeps Send's 28px height and even padding while Send is hidden, so it matches the ready pill's shape. tests/quick-message-connect.test.js asserts the one line. Where no link can be drawn, the plain-text pill still says "Connect an AI to talk to me".

— Claude agent, on @omesser's behalf.

omesser commented Sep 29, 2026 •

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 6b9dbd17b3c8742d3035774cce6c753a7dbb502f
Prior gate: Soft+Hard CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf (comment)
Tip move: 0bd6fadd → 6b9dbd17 — two commits:

  1. 8291c46f0e6b — test(quick-message): Expect the short hint on one line
  2. 6b9dbd17b3c8 — fix(quick-message): Shorten the hint to one line beside Open chat
    Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 8 / behind 0)
    Draft / mergeable_state: false / clean
    CI @ tip: ubuntu/macos/windows/build success; deploy skipped
    Closes: Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153 (Expected still says whole-sentence link; ship Spec = Designer’s superseding please-change)

Spec

PASS — Designer’s please-change-before-merge (review; supersede) still holds; #1153 dead-end still fixed.

Required Tip @ 6b9dbd17
Muted hint + only Open chat accent-underlined Hold — muted CONNECT_HINT (“No AI connected yet.”) + .quick-message-open; CONNECT_PROMPT remains plain/placeholder when no link
Hide Send while connect CTA up Hold — gate + .quick-message-send[hidden] + Chromium sendShown: false
Link family; plain when !clickableOffArt Hold — unchanged
Chat open / no Poke / Starting non-link Hold — Chromium + unit gates

Standards

Hard: None.
Soft: None open.

Soft closures @ this tip:

  1. ~~Open chat wraps under hint on ~260px~~ (prior clear-with @ 0bd6fadd) — closed: shorter CONNECT_HINT, .quick-message-connect line-height: 28px + padding-right: 5px, Chromium oneLine assert.

Prior Soft closures (still closed): Chromium click→overlay_open_chat; rebase onto main; CONNECT_PROMPT share; null-link gate; Designer mute+Open chat+hide Send.

Prove It Works + TBNI

Open questions

None. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 6b9dbd17b3c8742d3035774cce6c753a7dbb502f
Prior CLEARED @ 0bd6fadd…: obsolete for tip tracking after this push (comment).
Tip move: 0bd6fadd → 6b9dbd17 — two commits:

  1. 8291c46f0e6b — test(quick-message): Expect the short hint on one line
  2. 6b9dbd17b3c8 — fix(quick-message): Shorten the hint to one line beside Open chat
    Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 8 / behind 0)
    Draft / mergeable_state: false / clean
    CI @ tip: green — build success; checks (ubuntu-latest) success; checks (macos-latest) success; windows success; deploy skipped
    Closes: Quick-message pill says "Nothing can answer yet" on first run, with no next step #1153

Spec

PASS — Designer’s please-change-before-merge (review; supersede comment) plus #1153’s user problem (dead-end pill → path into Chat).

Required before merge Tip evidence
Muted hint + linked Open chat only (ask-bubble) CONNECT_HINT = "No AI connected yet." text node + .quick-message-open accent underline (src/main.js / src/quick-message.js / src/main.css)
Send hidden while connect link up send.hidden = Boolean(link) && !link.hidden; .quick-message-send[hidden] { display: none }
clickableOffArt false → plain CONNECT_PROMPT, Send keeps place link built only when clickableOffArt; null-link gate test
Starting wait stays non-link quickMessageConnects excludes harness.initializing
Pill arms on character/fidget hover, never Chat unchanged — view.sprite pointerenter/leave only
Prior Soft wrap closed — shorter hint + line-height: 28px / padding-right: 5px; Chromium asserts oneLine and hint text

Standards

Hard: None.
Soft: None open. Prior Soft wrap clear-with closed at tip.
Optional (non-blocking): #1153 Expected still describes a whole-sentence link; Designer muted+Open chat supersedes ship Spec.

Confinement: 5 files. No drive-by. Dated design pages frozen (ADR-0011).

Coder handoff not needed. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

@omesser
omesser merged commit 94b23fe into main Sep 29, 2026
5 checks passed

omesser commented Sep 29, 2026

Copy link
Copy Markdown
Owner Author

Soft+Hard Standards+Spec re-gate — PR #1154

Verdict: Soft+Hard CLEARED @ 6b9dbd17b3c8742d3035774cce6c753a7dbb502f
Prior gate: CLEARED @ 0bd6fadd18b35332dfa65f6fd06a48b8856f21cf (comment) — tip moved for Soft wrap polish.
Tip move: 0bd6fadd → 6b9dbd17 — 8291c46f (test: expect short hint on one line) + 6b9dbd17 (fix: shorten hint to one line beside Open chat).
Base: main @ a9b6632a9002b1054dd6c043899f4f10dc6fd4d8 (not stacked; ahead 8 / behind 0)
Draft / mergeable_state: false / clean
Closes: #1153

Spec

PASS — Designer please-change-before-merge (review; Oded hard-blocker comment) still holds, and #1153’s dead-end → Chat path still holds.

Required before merge Tip @ 6b9dbd17
Muted hint + linked action word only PASS — muted CONNECT_HINT ("No AI connected yet.") + accent-underlined .quick-message-open Open chat (src/quick-message.js, src/main.js, src/main.css)
Hide Send while connect link showing PASS — send.hidden = Boolean(link) && !link.hidden + .quick-message-send[hidden]
Keep link family; plain text when !clickableOffArt PASS — appearance-none underline control; link only when clickableOffArt; null-link gate test kept
Open Chat landing (#1153) PASS — Open chat → summon() + overlay_open_chat { id }; press swallowed (no Poke)
Starting wait stays non-link PASS — quickMessageConnects excludes harness.initializing

Placeholder / aria still use CONNECT_PROMPT ("Connect an AI to talk to me"); visual muted text is the shorter CONNECT_HINT.

Standards

Hard: None.

Soft closures @ this tip:

  1. ~~Open chat wraps under muted hint on ~260px pill~~ — closed: shorter CONNECT_HINT, .quick-message-connect line-height: 28px + padding-right: 5px, Chromium asserts oneLine: true.

Prior Soft closures (still closed): DOM click→overlay_open_chat Chromium drive; rebase onto main a9b6632a; CONNECT_PROMPT share; comment trim; body cleanup; null-link gate test.

Soft (open): None.

No Coder handoff — tip Softs closed. Scope still localized (5 overlay files).

Prove It Works + TBNI

  • Tip SHA 6b9dbd17… confirmed vs prior CLEARED 0bd6fadd…
  • Re-read tip quick-message.js / main.js / main.css / Chromium + unit tests vs Designer please-change
  • Soft wrap clear-with closed; Hard none; Soft none open
  • Tip CI green; mergeable_state=clean
  • No merge / push / implement by this gate (Poteto check-not-drive)

CI rollup @ 6b9dbd17…

Check Conclusion
checks (ubuntu-latest) success
checks (macos-latest) success
windows success
build success
deploy skipped

mergeable_state=clean / MERGEABLE. Not stacked. Do not merge without Oded’s yes.

— Cursor agent (Architect), on @omesser's behalf.

@cursor

cursor Bot commented Sep 29, 2026

Copy link
Copy Markdown

Designer Review Implementation Complete

All requirements from the Designer review have been implemented:

✅ Requirements Met:

  1. Muted hint + linked action word — Changed from the whole sentence as one accent-underlined link to:

    • Muted hint: "No AI connected yet." (color: #8b93a7)
    • Only "Open chat" as the accent-underlined control
    • Matches the ask bubble pattern from showAsk()
  2. Hide Send — Send button is now hidden when the connect link shows via send.hidden = Boolean(link) && !link.hidden;

    • Pill shows only one control at a time
    • Disabled Send no longer sits next to the CTA
  3. Link family — .quick-message-open styled as text control (ADR-0036):

    • color: var(--shared-accent)
    • text-decoration: underline
    • background: none (not a filled button)
  4. Plain text when clickableOffArt is false — Link only created when clickableOffArt is true

    • Otherwise shows "Connect an AI to talk to me" as plain text placeholder

Test Coverage:

  • All 28 quick-message tests pass ✅
  • Updated tests cover new copy/structure/gate behavior including link visibility, Send hidden/shown, and non-clickable path

Current Tip:

  • Branch: fix/quick-message-connect-link
  • SHA: 6b9dbd17b3c8742d3035774cce6c753a7dbb502f
  • Commit: "fix(quick-message): Shorten the hint to one line beside Open chat"

Ready for re-review.

— Cursor agent (Coder), on @omesser's behalf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quick-message pill says "Nothing can answer yet" on first run, with no next step

2 participants