Repository navigation
test: Drop source greps that do not pin a failure - #1268
Conversation
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED Soft (a) settling
Tip: 127fc991c012f7edc6d4b47260f538e035587a27 (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop tests that grep source instead of calling the code
Mergeable: true (unstable — Soft (a) settling)
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | settling — build / renderer success; checks (ubuntu-latest) / checks (macos-latest) / windows in progress; Pages deploy skipped (run 37044316595) |
| (b) Scope/intent | Met — origin/main...HEAD = +4/−2117 across 31 files (14 deleted / 17 modified). Matches claim. Prod-adjacent edits are #[cfg(test)] / panic-only drops in acp_wire.rs, harness.rs, secrets.rs. No production control-flow change |
| (c) Correctness vs claim | Met — Removals are source-grep, self-simulating lists, selector pins, or panic-only Rust. ADR/research/skill/budget/secret-scanner tests and assert_send witnesses untouched. Surviving seams: chat-settle preempt notes; harness second-shutdown / refuse-later-turn; secrets deleting_an_item_leaves_none |
| (d) Tests / prod path | Met — Copy press asserts literal "copy_byo_snippet" then clipboard write; drag/tab behavior kept |
| (e) Hygiene | Met — undrafted; MERGEABLE; no Closes/Fixes (none warranted) |
Soft-FIX
None.
Soft notes (not Soft-FIX)
- Soft (a) → Met when ubuntu / macos / windows go green on tip.
chat-preempt-causesgreppedhappened_cellthen calledpreemptedNote; settle tests still pin user-visible notes. Auto-discovery of a new Rust arm is the source-oracle this cleanup removes.
Soft CLEARED Soft (a) settling. Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED
Tip: 127fc991c012f7edc6d4b47260f538e035587a27 (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop tests that grep source instead of calling the code
Mergeable: true (clean)
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — PR Tests 37044316595: checks (ubuntu-latest) / checks (macos-latest) / windows / renderer success; Pages 37044316579: build success / deploy skipped |
| (b) Scope/intent | Met — unchanged since Soft CLEARED Soft (a) settling (review 5395075073) |
| (c) Correctness vs claim | Met — unchanged |
| (d) Tests / prod path | Met — unchanged |
| (e) Hygiene | Met — undrafted; MERGEABLE/CLEAN; no Closes/Fixes (none warranted) |
Soft-FIX
None.
Soft CLEARED Soft (a)–(e) Met (Soft (a) flipped from settling). Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
Soft Open Soft-FIXTip: Soft ledger
Soft-FIX (once per tip → Coder)Restore these deleted tests (whole files on
Soft notes (not Soft-FIX)Prior Soft note on preempt-causes alone was too narrow. Source-grep noise in the rest of the deletion set can stay gone. Soft Open Soft-FIX. Comment-only. Never merge without Oded yes. — Cursor agent (Architect), on @omesser's behalf. |
The cleanup deleted the only checks for an HTML sink, a drifted vendored parser, a composer that strips newlines, a maxlength off CHAT_LIMIT, an unexported Tauri handle, a preempt wake with no clause, a Harness with no Connect button, and a Settings finder that matches Windows Settings by name. Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED Soft (a) settling
Tip: 22626394327c1ff9a34c450d460f6ce53bad64de (cursor/drop-shape-tests-db46) — test: Restore oracles that pin silent failures
PR: #1268 — test: Drop source greps that do not pin a failure
Mergeable: true (unstable — Soft (a) settling)
Supersedes: Soft Open Soft-FIX on 127fc991… (issue comment 5958544908)
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | settling — Pages build success / deploy skipped (37047442392); PR Tests 37047442766: renderer success; checks (ubuntu-latest) / checks (macos-latest) / windows still in progress |
| (b) Scope/intent | Met — tip restores the seven failure-mode oracles Soft-FIX asked for; CSS/token/shape, design-page Dated/noindex, self-simulating banner, and panic-only Rust stay deleted (+4/−1721 across 29 files vs main) |
| (c) Correctness vs claim | Met — each Soft-FIX pin is present on tip and fails for the named silent failure (read bodies, not name-only) |
| (d) Tests / prod path | Met — Soft-FIX Met (below) |
| (e) Hygiene | Met — undrafted; MERGEABLE; mergeStateStatus unstable only for Soft (a); no Closes (none warranted); title/body rewritten to match |
Soft-FIX (from Soft Open on 127fc991…) — Met
tests/chat-markdown.test.js—nothing in the webview writes HTML(sink sweep ofsrc/+src/vendor/) + vendored parser sha256 pin restored.tests/chat-composer.test.js— TEXTAREA / newline hold + Enter / Shift+Enter /requestSubmitoracles restored (height CSS greps stay gone).tests/chat-composer-limit.test.js—the composer field is bounded at CHAT_LIMIT(maxlength↔ Rust const) restored.tests/settings-window-handle.test.js— byte-identical to main: no unexported handle + every handle viagetCurrentWebviewWindow.tests/chat-preempt-causes.test.js—every wake the Rust side can name has a clause of its ownrestored.tests/connect-buttons.test.js— byte-identical to main: every named Harness ↔ Connect button.tests/ax-settings-win-finder.test.js—Name-only is insufficient: the Windows Settings app is not a matchrestored (ClassName discrimination kept; phase-2 script greps stay gone).
Soft notes
Soft-FIX once-per-tip on 127fc991… is closed by this tip. No new Soft-FIX. Soft (a) alone remains open until PR Tests finishes green on 22626394…; Soft will re-gate when that settles if needed. Comment-only. Never merge without Oded yes.
Soft CLEARED Soft (a) settling.
— Cursor agent (Architect), on @omesser's behalf.
Missing-pid job teardown, shutdown before a child exists, and delete of a missing secret can panic or hang if the early return goes away. A bare assignment in a module throws on load. The other dropped tests grep source or assert a fixture they built; each former site says why. Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED Soft (a) settling
Tip: d076511a8ef9d305b9821f7f0beea865b7228794 (cursor/drop-shape-tests-db46) — test: Restore noop oracles and mark the drops that stay
PR: #1268 — test: Drop source greps that do not pin a failure
Mergeable: true (unstable — Soft (a) settling)
Supersedes: Soft CLEARED Soft (a) settling on 22626394… (review 5395329000)
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | settling — Pages build success / deploy skipped (37064113109); PR Tests 37064113240: renderer success; checks (ubuntu-latest) / checks (macos-latest) / windows still in progress |
| (b) Scope/intent | Met — tip delta ahead_by 1 restores failure-mode noop oracles (secrets delete-missing, acp_wire terminate_job missing pid, harness shutdown-before-child×2, no-undeclared-assignment scan) and adds DROPPED notes at former grep/self-simulating sites; Soft-FIX seven untouched in spirit (DROPPED comments only on some Soft-FIX files; settings-window-handle + connect-buttons still byte-identical to main) |
| (c) Correctness vs claim | Met — each Soft-FIX pin still present and fails for the named silent failure; new noops pin panic/hang/load-throw paths the commit names; intentional DROPPED noise (CSS/token, design-page Dated/noindex, self-simulating banner, phase-2 script greps) stays documented, not Soft-FIX |
| (d) Tests / prod path | Met — Soft-FIX Met (below); new restores are failure pins, not Soft Open Soft-FIX |
| (e) Hygiene | Met — undrafted; MERGEABLE; mergeStateStatus unstable only for Soft (a); no Closes (none warranted); DROPPED comments name #1268 |
Soft-FIX (from Soft Open on 127fc991…) — still Met
tests/chat-markdown.test.js—nothing in the webview writes HTML+ vendored parser sha256 (DROPPED note only added).tests/chat-composer.test.js— TEXTAREA / newline + Enter / Shift+Enter /requestSubmit(DROPPED height-CSS note only).tests/chat-composer-limit.test.js—maxlength↔CHAT_LIMIT(DROPPED note only).tests/settings-window-handle.test.js— byte-identical to main (unexported handle +getCurrentWebviewWindow).tests/chat-preempt-causes.test.js— every wake clause (DROPPED transcript-draw note only).tests/connect-buttons.test.js— byte-identical to main.tests/ax-settings-win-finder.test.js— Name-only insufficient / Windows Settings app (phase-2 DROPPED notes added; Name-only pin stays).
New on this tip (not Soft-FIX, sound failure pins): deleting_a_missing_item_is_ok (secrets), test_terminate_job_missing_pid_is_noop (acp_wire), shutdown_before_a_child_exists_is_repeatable (harness, shutdown×2), tests/no-undeclared-assignment.test.js (bare assignment throws on module load).
Soft notes
Prior Soft-FIX once-per-tip remains Met; no new Soft-FIX. Soft (a) alone remains open until PR Tests finishes green on d076511a…; Soft will re-gate when that settles if needed. Comment-only. Never merge without Oded yes.
Soft CLEARED Soft (a) settling.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED
Tip: d076511a8ef9d305b9821f7f0beea865b7228794 (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop tests that grep source instead of calling the code
Mergeable: true (clean)
Supersedes: Soft CLEARED Soft (a) settling on this tip (review 5396809711).
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — PR Tests 37064113240: ubuntu / macos / windows / renderer SUCCESS; Pages 37064113109: build SUCCESS / deploy skipped |
| (b) Scope/intent | Met — Soft-FIX seven oracles still present; noop/load restores land; remaining drops keep // DROPPED (#1268): reasons |
| (c) Correctness vs claim | Met — Soft-FIX Met (below) |
| (d) Tests / prod path | Met — Soft-FIX None |
| (e) Hygiene | Met — undrafted; MERGEABLE/CLEAN; no Closes (none warranted) |
Soft-FIX
None. Soft-FIX Met vs Soft Open Soft-FIX at 127fc991 and the follow-up Soft CLEARED Soft (a) settling at 22626394:
- Prior seven failure-mode oracles still on tip (webview HTML sink + marked hash, composer newlines, CHAT_LIMIT, window-handle, preempt-causes, connect-buttons, Windows Settings finder).
- Tip restores
test_terminate_job_missing_pid_is_noop,shutdown_before_a_child_exists_is_repeatable,deleting_a_missing_item_is_ok, andno module assigns to a name it never declares. - Remaining drops carry overrulable
// DROPPED (#1268):markers (78 counted).
Soft CLEARED Soft (a)–(e) Met (Soft (a) flipped from settling). Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft Open Soft-FIX
Tip: d076511a8ef9d305b9821f7f0beea865b7228794 (cursor/drop-shape-tests-db46) — unchanged vs Soft CLEARED Soft (a)–(e) Met (review 5396840710).
PR: #1268 — test: Drop source greps that do not pin a failure
Mergeable: true (clean)
Trigger: Oded inline "Remove file" on tests/ax-settings-select.test.js.
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — PR Tests 37064113240: ubuntu / macos / windows / renderer SUCCESS; Pages 37064113109: build SUCCESS / deploy skipped |
| (b) Scope/intent | Soft Open Soft-FIX — DROPPED-only stub files must go (Oded), not linger as comment-only husks |
| (c) Correctness vs claim | Soft Open Soft-FIX — same |
| (d) Tests / prod path | Met — Soft-FIX is delete-only; live suites untouched |
| (e) Hygiene | Met — undrafted; MERGEABLE/CLEAN |
Soft-FIX (Coder, once on this tip)
Delete these seven files that contain only // DROPPED (#1268): notes and no remaining test(:
tests/ax-settings-select.test.js— Oded asktests/chat-prompt.test.jstests/chat-session-banner.test.jstests/chat-ui-tokens.test.jstests/design-pages.test.jstests/settings-surface-flag.test.jstests/shared-tokens.test.js
Keep // DROPPED (#1268): notes that sit beside remaining live tests in other files (e.g. tests/chat-appearance-paint.test.js). Soft does not reopen the seven failure-mode oracles or the noop/load restores already Soft-FIX Met on this tip.
Soft Open Soft-FIX. Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft Open Soft-FIX
Tip: d076511a8ef9d305b9821f7f0beea865b7228794 (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop tests that grep source instead of calling the code
Mergeable: true (clean)
Trigger: Oded inline on tests/ax-settings-select.test.js — "Remove file" (discussion_r4169857227).
Supersedes: Soft CLEARED Soft (a)–(e) Met on this tip (review 5396840710).
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — unchanged from Soft CLEARED (PR Tests 37064113240 ubuntu/macos/windows/renderer SUCCESS; Pages 37064113109 build SUCCESS / deploy SKIPPED) |
| (b) Scope/intent | Open Soft-FIX — tip still ships a DROPPED-stub file Oded asked to delete |
| (c) Correctness vs claim | Met — prior Soft-FIX seven oracles + noop restores still hold |
| (d) Tests / prod path | Met — Soft-FIX None beyond the stub delete |
| (e) Hygiene | Met — undrafted; MERGEABLE/CLEAN |
Soft-FIX (once this tip → Coder)
- Delete
tests/ax-settings-select.test.js(DROPPED stub only; no livetest/describe). Do not leave a tombstone file. - Confirm nothing else imports or lists that path; keep the seven failure-mode oracles and noop restores intact.
Soft note (not Soft-FIX): six other tip files are DROPPED-comment stubs with no live tests (chat-prompt, chat-session-banner, chat-ui-tokens, design-pages, settings-surface-flag, shared-tokens). Same delete shape if you want them gone too; Oded only named this one.
Soft Open Soft-FIX. Soft COMMENT only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
The reasons belong on the pull request, where a reply can overrule one. The noop and load-throw oracles stay. Co-authored-by: Oded Messer <odedmesser@gmail.com>
|
Stay-dropped tests. Reply on this comment to overrule one. Each line is a test that greps source, matches CSS or static HTML, or asserts a value the test itself built. None of them call a function that can panic, hang, or change a noop. tests/ax-settings-select.test.js (file removed)
tests/ax-settings-win-finder.test.js (Name-only match stays)
tests/bubble.test.js
tests/chat-appearance-paint.test.js
tests/chat-ask-order.test.js
tests/chat-ask-row.test.js
tests/chat-composer-limit.test.js (maxlength pin stays)
tests/chat-composer.test.js (textarea newline pin stays)
tests/chat-connect.test.js
tests/chat-markdown.test.js (HTML-sink and parser-hash pins stay)
tests/chat-placeholder.test.js
tests/chat-preempt-causes.test.js (wake-clause pin stays)
tests/chat-prompt.test.js (file removed)
tests/chat-session-banner.test.js (file removed)
tests/chat-ui-tokens.test.js (file removed)
tests/design-pages.test.js (file removed)
tests/landing-page.test.js
tests/product-identity.test.js
tests/quick-message.test.js
tests/settings-drag-gate.test.js
tests/settings-surface-flag.test.js (file removed)
tests/settings-tabs.test.js
tests/settings.test.js
tests/shared-tokens.test.js (file removed)
— Cursor agent (Coder), on @omesser's behalf. |
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED Soft (a) settling
Tip: 9421b3fbbc117d5a5443a403709b1001289b98fe (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop the in-tree notes for tests that stay deleted
Mergeable: true (unstable — Soft (a) settling)
Supersedes: Soft Open Soft-FIX at d076511a (review 5396897109).
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | settling — windows / renderer success; checks (ubuntu-latest) / checks (macos-latest) in progress; Pages build success / deploy skipped |
| (b) Scope/intent | Met — d076511a...9421b3f = 24 files, −160. Seven DROPPED-only stubs deleted; in-tree // DROPPED (#1268): notes gone (0 left) |
| (c) Correctness vs claim | Met — Soft-FIX Met |
| (d) Tests / prod path | Met — delete-only; failure-mode oracles and noop/load restores still present |
| (e) Hygiene | Met — undrafted; MERGEABLE; no Closes (none warranted) |
Soft-FIX
None. Soft-FIX Met vs review 5396897109:
- Gone:
tests/ax-settings-select.test.js,tests/chat-prompt.test.js,tests/chat-session-banner.test.js,tests/chat-ui-tokens.test.js,tests/design-pages.test.js,tests/settings-surface-flag.test.js,tests/shared-tokens.test.js. - Still present: webview HTML sink, CHAT_LIMIT, Windows Settings finder, preempt wake clauses,
terminate_jobmissing pid, shutdown before a child, delete of a missing secret, undeclared-assignment scan.
Soft CLEARED Soft (a) settling. Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED Soft (a) settling
Tip: 9421b3fbbc117d5a5443a403709b1001289b98fe (cursor/drop-shape-tests-db46) — test: Drop the in-tree notes for tests that stay deleted
PR: #1268 — test: Drop source greps that do not pin a failure
Mergeable: true (unstable — Soft (a) settling)
Supersedes: Soft Open Soft-FIX on d076511a8ef9d305b9821f7f0beea865b7228794 (review 5396887508)
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | settling — Pages 37065458638: build SUCCESS / deploy skipped; PR Tests 37065458681: renderer SUCCESS; checks (ubuntu-latest) / checks (macos-latest) / windows still in progress |
| (b) Scope/intent | Met — tip ahead_by 1 deletes the seven DROPPED-only stubs Soft-FIX named; also moves remaining // DROPPED (#1268): reasons off-tree onto the PR checklist (matches updated PR claim; Soft does not Soft-FIX restore in-tree DROPPED notes when the claim says they stay off-tree) |
| (c) Correctness vs claim | Met — Soft-FIX Met (below); seven failure-mode oracles + noop/load restores still present and pin the named silent failures |
| (d) Tests / prod path | Met — delete-only Soft-FIX + note relocation; live Soft-FIX suites untouched in substance |
| (e) Hygiene | Met — undrafted; MERGEABLE; mergeStateStatus unstable only for Soft (a); no Closes (none warranted) |
Soft-FIX (from Soft Open Soft-FIX on d076511a… / 5396887508) — Met
All seven DROPPED-only stubs are gone from tip (404 / removed vs main):
tests/ax-settings-select.test.jstests/chat-prompt.test.jstests/chat-session-banner.test.jstests/chat-ui-tokens.test.jstests/design-pages.test.jstests/settings-surface-flag.test.jstests/shared-tokens.test.js
Soft-FIX Met (must still hold — still hold; not reopened)
tests/chat-markdown.test.js—nothing in the webview writes HTML+ vendored parser sha256tests/chat-composer.test.js— TEXTAREA / newline + Enter / Shift+Enter /requestSubmittests/chat-composer-limit.test.js—maxlength↔CHAT_LIMITtests/settings-window-handle.test.js— unexported handle +getCurrentWebviewWindowtests/chat-preempt-causes.test.js— every wake clausetests/connect-buttons.test.js— Harness ↔ Connect buttontests/ax-settings-win-finder.test.js— Name-only insufficient / Windows Settings app
Plus noop/load:deleting_a_missing_item_is_ok,test_terminate_job_missing_pid_is_noop,shutdown_before_a_child_exists_is_repeatable,no-undeclared-assignment
Soft notes
Soft-FIX once-per-tip Met on this new tip. Soft (a) alone remains open until PR Tests finishes green on 9421b3fb…. Soft will re-gate when that settles if needed. Comment-only. Never merge without Oded yes.
Soft CLEARED Soft (a) settling.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED
Tip: 9421b3fbbc117d5a5443a403709b1001289b98fe (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop source greps that do not pin a failure
Mergeable: true (clean)
Supersedes: Soft CLEARED Soft (a) settling on this tip (reviews 5396924367 + 5396924399).
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — PR Tests 37065458681: ubuntu / macos / windows / renderer SUCCESS; Pages 37065458638: build SUCCESS / deploy SKIPPED |
| (b) Scope/intent | Met — Soft-FIX seven DROPPED-only stubs deleted; in-tree DROPPED notes off-tree per PR claim |
| (c) Correctness vs claim | Met — Soft-FIX Met; seven failure-mode oracles + noop/load restores still present |
| (d) Tests / prod path | Met — Soft-FIX None |
| (e) Hygiene | Met — undrafted; MERGEABLE/CLEAN; no Closes (none warranted) |
Soft-FIX
None. Soft-FIX Met on this tip (reviews 5396924367 / 5396924399). Do not reopen the seven failure-mode oracles or noop/load restores.
Soft CLEARED Soft (a)–(e) Met (Soft (a) flipped from settling). Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft Open Soft-FIX
Tip: 9421b3fbbc117d5a5443a403709b1001289b98fe (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop source greps that do not pin a failure
Supersedes: Soft CLEARED Soft (a)–(e) Met on this tip (review 5397030902). That clear checked the seven restored failure pins, the noop/load restores, and the seven stub deletions. It did not re-read every original dropped test. Oded asked for that pass.
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — unchanged from review 5397030902 (PR Tests 37065458681 ubuntu/macos/windows/renderer SUCCESS; Pages 37065458638 build SUCCESS / deploy SKIPPED). Tip SHA unchanged. |
| (b) Scope/intent | Met — still test-only deletions vs the PR base. |
| (c) Correctness vs claim | Open — most drops are source-grep, CSS, design-page text, or self-simulating. A few are the only pin for a silent user-facing failure. |
| (d) Tests / prod path | Open — Soft-FIX below. |
| (e) Hygiene | Met — undrafted; no Closes (none warranted). |
Still held (not reopened)
nothing in the webview writes HTML; vendored parser sha256; composer newlines + Enter / Shift+Enter / requestSubmit; the composer field is bounded at CHAT_LIMIT; unexported Tauri handle + getCurrentWebviewWindow; every wake the Rust side can name has a clause of its own; Harness ↔ Connect button; Name-only is insufficient: the Windows Settings app is not a match; deleting_a_missing_item_is_ok; test_terminate_job_missing_pid_is_noop; shutdown_before_a_child_exists_is_repeatable; no module assigns to a name it never declares.
Soft-FIX (once on this tip → Coder)
Restore only these. A behavioral test that fails on the same bug is fine. Do not restore CSS, token, design-page, or self-simulating tests.
- From deleted
tests/chat-prompt.test.js, these four only (not the CSS/copy/layer tests):nothing in the Chat surface saves on a keystroke;the save is asked for twice before the conversation is spent;Prompt tab Save and Discard stay disabled until the field is dirty;Discard restores the last saved text; Cancel only aborts confirm. No test on tip mentionschat_promptorpromptDirty. A keystroke save wipes the session (ADR-0012). tests/bubble.test.js—the Shell carries a line for exactly as long as the bubble can show one(CARRY_WINDOWvsbubbleDurationmax). Andthe capability the renderer asks for is a command the Shell registers(overlay_hit_tests_hotspots↔generate_handler!).tests/chat-composer-limit.test.js—the log row and what is sent are the same string. The maxlength pin does not read the submit path.tests/chat-preempt-causes.test.js—the transcript draws a preempted turn instead of dropping the row(turn.them.remove()+note). Settle tests assert the note string only.tests/settings-tabs.test.js—the tab bar is a tablist of buttons over one panel;every tab names the panel it opens;the page loads its module as a module and inlines no script.tabTitles/selectTabnever opensettings.html.tests/landing-page.test.js— put back theassembleScriptassertion that the Pages Assemble step contains--release release.json.
Soft notes (not Soft-FIX)
Stay dropped: phase-2 finder greps, session-banner self-simulation, chat-ui token scanner, design-page Dated/noindex, shared-token CSS, product-name strings, quick-message main.js string pins (module behavior tests remain), prompt-tab layout/copy, ask-row CSS, appearance stylesheet greps (browser paint tests remain). scripts/chat-ask-order.mjs is not in CI; say if the lowerCaret grep should come back too.
Soft Open Soft-FIX. Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
A keystroke that saves, a carry window shorter than the bubble, a log row that is not the sent string, a dropped preempt, a tab bar that is not a tablist, and an Assemble step that forgets the release file. Co-authored-by: Oded Messer <odedmesser@gmail.com>
|
These lines on the stay-dropped checklist are restored and are no longer overrule candidates:
The other checklist lines stay dropped. — Cursor agent (Coder), on @omesser's behalf. |
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED Soft (a) settling
Tip: 0e72007c42764d0e702b80cdde74a44275b80a53 (cursor/drop-shape-tests-db46) — test: Restore prompt, bubble, and settings pins that catch a silent miss
PR: #1268 — test: Drop source greps that do not pin a failure
Mergeable: true (unstable — Soft (a) settling)
Supersedes: Soft Open Soft-FIX on 9421b3fb… (review 5397169096)
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | settling — Pages 37069030614: build success / deploy skipped; PR Tests 37069030692: windows / renderer success; checks (ubuntu-latest) / checks (macos-latest) still in progress |
| (b) Scope/intent | Met — 9421b3fb...0e72007c = +244/−0 across 6 files. Restores only the named failure-mode oracles. Stay-dropped stubs still 404 (ax-settings-select, chat-session-banner, chat-ui-tokens, design-pages, settings-surface-flag, shared-tokens). lowerCaret absent. Prompt copy/layer titles absent. Bubble tail-CSS grep not restored (behavioral invert test is a different pin) |
| (c) Correctness vs claim | Met — each restored test asserts the named silent failure (read bodies, not titles only) |
| (d) Tests / prod path | Met — Soft-FIX Met (below). Prior seven oracles + noop/load restores still present |
| (e) Hygiene | Met — undrafted; MERGEABLE; mergeStateStatus unstable only for Soft (a); no Closes (none warranted) |
Soft-FIX (from review 5397169096) — Met
tests/chat-prompt.test.js— four tests only: keystroke save ban (line.keydown/promptText.input|change, noinvoke/askingToSaveon those); double-confirm (chat_promptonly afterpromptConfirm, one invoke); dirty gate (disabled+promptDirty+promptSave.disabled = confirming \|\| !dirty); Discard restoressavedPromptand Cancel does not writepromptText.value.tests/bubble.test.js—CARRY_WINDOWseconds × 1000 equalsbubbleDurationmax clamp;overlay_hit_tests_hotspotsin rendererinvokeis inside shellgenerate_handler!.tests/chat-composer-limit.test.js— oneline.value.trim(),said("You", text, "you"), andinvoke("chat_send", { instance, text }).tests/chat-preempt-causes.test.js— preempted branch (cut at the nextelse) matchesturn.them.remove()andnote(outcome.note).tests/settings-tabs.test.js—role="tablist"+role="tabpanel"; every tabaria-controls="set-panel";<script type="module" src="settings.js">and no inline script.tests/landing-page.test.js—assembleScriptasserts the Pages Assemble step contains--release release.json.
Soft notes
Soft-FIX once-per-tip on 9421b3fb… is closed by this tip. No new Soft-FIX. Soft (a) alone remains open until ubuntu and macos go green on 0e72007c…. Comment-only. Never merge without Oded yes.
Soft CLEARED Soft (a) settling.
— Cursor agent (Architect), on @omesser's behalf.
omesser
left a comment
There was a problem hiding this comment.
Soft CLEARED Soft (a)–(e) Met
Tip: 0e72007c42764d0e702b80cdde74a44275b80a53 (cursor/drop-shape-tests-db46)
PR: #1268 — test: Drop source greps that do not pin a failure
Supersedes: Soft Open Soft-FIX on 9421b3fbbc117d5a5443a403709b1001289b98fe (review 5397169096). Tip commit 0e72007c restores the Soft-FIX pins.
Soft ledger
| Axis | Status |
|---|---|
| (a) CI green on tip | Met — Pages run 37069030614: build SUCCESS / deploy SKIPPED. PR Tests run 37069030692: ubuntu / macos / windows / renderer SUCCESS. |
| (b) Scope/intent | Met — still test-only: drop source greps / self-simulating pins that do not catch a silent miss; keep failure-mode oracles. No wild scope creep on this tip. |
| (c) Spec / restore pins | Met — Soft-FIX list from review 5397169096 is present on tip (see below). Prior seven failure-mode oracles + noop/load restores remain held. |
| (d) Soft-FIX hygiene | Met / Soft-FIX None — Soft-FIX Met this tip; no further Soft-FIX to Coder. |
| (e) Evidence / process | Met — undrafted; MERGEABLE; How-to-verify is node --test on the six restored suites (61 passed); no forbidden local paths. Architect COMMENT-only; never merge without Oded yes. |
Soft-FIX restores verified on tip
tests/chat-prompt.test.js— four: keystroke-save; double-ask (chat_prompt); dirty Save/Discard +promptDirty; Discard-vs-Cancel.tests/bubble.test.js—CARRY_WINDOWvsbubbleDurationmax;overlay_hit_tests_hotspots↔generate_handler!.tests/chat-composer-limit.test.js— log-row == sent string (identical to main).tests/chat-preempt-causes.test.js— preempt transcript row (turn.them.remove+note) (identical to main).tests/settings-tabs.test.js— tablist / panel / module load.tests/landing-page.test.js—assembleScriptasserts--release release.json(identical to main).
Still held (not reopened)
nothing in the webview writes HTML; vendored parser sha256; composer newlines + Enter / Shift+Enter; CHAT_LIMIT; every window handle comes from getCurrentWebviewWindow; every wake the Rust side can name has a clause of its own; Harness ↔ Connect button; Name-only is insufficient; deleting_a_missing_item_is_ok; test_terminate_job_missing_pid_is_noop; shutdown_before_a_child_exists_is_repeatable; no module assigns to a name it never declares.
Soft notes
Stay dropped (unchanged Soft notes): CSS / token / design-page / self-simulating greps; prompt-tab layout/copy; bubble-tail CSS; phase-2 finder greps; session-banner self-simulation. Residual vs main on chat-prompt / bubble / settings-tabs is those intentional stay-drops, not missing Soft-FIX pins.
Soft CLEARED Soft (a)–(e) Met. Soft-FIX Met / Soft-FIX None. Comment-only. Never merge without Oded yes.
— Cursor agent (Architect), on @omesser's behalf.
Why
Source-text oracles that fail on a rename, and tests that assert a value they just wrote, are gone. A behavior bug could pass them. The cuts also deleted pins for a silent miss: a keystroke that saves an Instance Prompt, a carry window that does not match the bubble, a log row that is not the string sent, a preempted turn that drops the row, a Settings tab bar that is not a tablist, and a Pages Assemble step that forgets the release file. Those are back.
The tests that stay dropped are the checklist comment on this pull request. A follow-up comment names the lines that were restored and are no longer overrule candidates. Those reasons are not comments in the tree.
What changed
Failure-mode oracles from the earlier passes stay: HTML sink, vendored parser hash, composer newlines,
CHAT_LIMIT, the Tauri window handle, preempt wake clauses, Connect buttons, the Name-only Settings match,terminate_jobon a missing pid, shutdown before a child exists, delete of a missing secret, and the undeclared-assignment scan.CSS, token, design-page, and self-simulating greps stay deleted. So do the prompt layout and copy tests, the bubble tail CSS, and
lowerCaret.How to verify
That command finished with 61 passed and 0 failed.
— Cursor agent (Coder), on @omesser's behalf.