Repository navigation
Conversation
Adds re-runnable e2e scenario for the agent sign-in button and waiting line. Uses fixture Harness in auth-sign-in-link mode. What: New script scripts/scenarios/sign-in-button.sh verifies the sign-in flow: button presence on needs-login landing, waiting line after press, and session opening once authenticate completes. Why: Issue #1054 added agent sign-in buttons and the waiting line shown while authenticate runs. No scenario covered this flow before. How to verify: Run with --go flag: scripts/scenarios/sign-in-button.sh --go <fidget> <test-binary> Captures three states: - needs-login: Fake login button present, terminal command shown - waiting: Waiting line appears after button press, names harness - signed-in: Session opened, waiting line cleared Refs #1088, #1054 Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
marked this pull request as ready for review
October 2, 2026 23:39
|
Closing: #1054 is already covered by existing scenarios and unit tests. Gap analysis: Existing coverage:
What's missing from e2e scenarios:
Why that gap is acceptable:
Per Laziness Protocol: unit test coverage + two live e2e scenarios satisfy #1054's checkbox. — Cursor agent (Coder), on @omesser's behalf. |
|
Fixed shellcheck SC2015 and force-pushed. Change: Rewrote line 98-99 from wait_for 15 grep -qx new "$marks" || fail "session did not open after sign-in; see $log"
[ "$(grep -c new "$marks")" -ge 2 ] || fail "session opened only once (expected >= 2); see $log"This avoids SC2015 (A && B || C is not if-then-else). Each assertion now fails independently with a clear message. Rebased onto current main. Ready for CI. — Cursor agent (Coder), on @omesser's behalf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds one re-runnable e2e scenario for the agent sign-in button and waiting line from #1054, part of epic #1088.
scripts/scenarios/sign-in-button.shlaunches Fidget with a fixture Harness (auth-sign-in-linkmode) that advertises agent methods. The script captures three states via Accessibility dumps and screenshots:Follows the patterns in
thinking-row.sh,chat-header-narrow.sh, andlauncher-dies-at-startup.sh.Why
Issue #1054 added in-app agent sign-in buttons and the waiting line shown while
authenticateruns. No scenario covered this flow before. The scenario proves the button shows when agent methods are advertised, the waiting line appears during sign-in, and both clear once a session opens.How to verify
Run with the
--goflag:Without
--go, prints the GUI takeover prompt and exits 2.The scenario:
authenticateto complete and session to openExpected duration: ~30s, 2 min max.
Refs #1088, #1054
— Cursor agent (Coder), on @omesser's behalf.