Repository navigation
fix: A sprite past the Dock's real end falls instead of walking on air - #145
Merged
Merged
Conversation
CGWindowList reports the Dock as a full-display window and the work area reserves a full-width strip, so the floor ran wall to wall while the Dock does not. With trust already granted (never prompted for, DESIGN.md decision 9) the Dock's AX frame makes it a real Perch and the floor beside it drops to the display's own bottom edge. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…hape Exact bounds for every user with zero grants. The private symbol is looked up at runtime so a release removing it costs the rung and not the launch, and its answer is believed only when plausible_dock agrees it is shaped like a bottom Dock standing in the reserved margin. The Accessibility rung keeps paying where trust exists; the full-width strip stays the fallback. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…tion The transmute's comment now says what dlsym cannot prove and where the accepted ABI risk lives; plausible_dock and floor_under_dock get their own docs and share centered_in; the no-Dock log line stops promising what a grant cannot deliver; and only the display that holds the Dock narrates its floor as beside it. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This was referenced Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
read_displaysbuilds the floor from the work area, and the work area reserves a full-width strip for the Dock — so the floor ran wall to wall while the Dock itself does not, and a sprite walking past the Dock's real end kept standing on the strip: walking on air. #39 chose that strip deliberately, becauseCGWindowListCopyWindowInforeports the Dock as a window covering the whole display (verified again while writing this: the layer-20 Dock window is exactly the display's rectangle).What
The Dock's true rectangle now comes from a chain that degrades silently, and the startup log names the rung that answered:
CoreDockGetRect— private CoreDock SPI, adopted knowingly: exact bounds for every user with zero grants. Treated as the unversioned thing it is: resolved bydlsymat runtime (never linked, so its removal costs the rung, not the launch) and believed only afterplausible_dockagrees the answer is shaped like a bottom Dock — a thin horizontal strip standing in the margin the work area reserved. A full-display rect, an empty one, a bar floating mid-screen, or a claim on a display that reserved nothing all fall through.With a true rectangle, the Dock becomes a real Perch (frontmost — it draws above every application window — with a reserved id so a resizing Dock is ridden, #109) and
floor_under_dockdrops the floor beside it to the display's own bottom edge. A walk past the Dock's end falls; landing beside the Dock lands in the true corner; standing on the Dock stands on it, and the Director hears "the top of the Dock". A side-pinned Dock reports nothing (its wall is already where the work area puts it); a hidden Dock reserves nothing, unchanged.The two live rungs frame the Dock differently — CoreDock reports the reserved strip (top at 982 on the reporting desktop, the exact line #39 chose by hand), AX reports the drawn island (top at 978) — so the preferred rung is also the one that keeps #39's resting line.
One smaller lie remains, named here deliberately: windows are not obstacles in the Engine, so a sprite walking along the true bottom can pass behind the Dock's island for the few steps of its span. That is transient and beats the permanent air-walk; solidity would be an Engine feature, not a Dock fix.
Alternatives surveyed
Measured on the reporting desktop against the AX rect (234, 978, 1452x92); also recorded in
dock.rs's module doc so the hunt is not repeated:CGWindowListCopyWindowInfo(bounds+layer+alpha, on-screen and all)com.apple.dockdefaults + running apps + TrashCoreDockGetRect(private CoreDock SPI)CGSGetDockRectWithReason/SLSGetDockRectWithReasonAXUIElementCopyElementAtPosition, screen captureVerify
cargo test --all-targets(351 — including theplausible_dockgate: both measured shapes believed, five lies refused) andnode --test tests/(22).cd src-tauri && cargo test dock -- --ignored --nocaptureprints the rectangle and its rung —Some((Rect { x: 233.0, y: 982.0, width: 1453.0, height: 98.0 }, CoreDock))on the desk this was written at, no permission dialog.Perched. The startup line readsdock: true bounds via CoreDock, ….🤖 Generated with Claude Code