Repository navigation
fix(ci): Bump the Homebrew cask and open the bump PR each Release - #1736
Merged
Merged
Conversation
omesser
commented
Oct 21, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft Open
Tip: eb997a04
What changed
- Cask: pinned to v0.6.3, the current latest Release, with a new sha256.
- Release job: the bump step now reuses only an open pull request on the bump branch and creates one otherwise, so a merged #1303 no longer swallows every later bump.
- Comments: usage lines dropped from three Homebrew script headers; cask and
homebrew-cask.rbheaders reworded.
What is wrong
- Open-PR lookup never matches:
gh pr list --head "${GITHUB_REPOSITORY_OWNER}:${PR_BRANCH}"passesowner:branch, whichgh pr list --headdoes not support; its help says so. Against this repo,--head omesser:fix/1727-homebrew-cask-bumpreturns nothing while--head fix/1727-homebrew-cask-bumpreturns this PR. Soopen_pris always empty, and re-running a Release while its bump PR is still open callsgh pr createon a branch that already has one, which fails the step. The PR body's claim that a re-run updates the existing pull request does not hold.
Soft-FIX
- Filter on the bare branch,
gh pr list --head "$PR_BRANCH" --state open .... The job already runs against this repo, so the owner pin buys nothing.
Non-blocking
- Headers still disagree: the cask header lists the rewritten stanzas without livecheck, while
homebrew-cask.rblists livecheck andensure_livecheckdoes rewrite it. Add livecheck to the cask header to make them match as the PR intends.
Verified: v0.6.3 is the latest Release and its aarch64 disk image hashes to the pinned sha256; node --test tests/publish-homebrew-cask.test.js passes 5 of 5 at the tip; the --head lookup was run both ways with gh 2.101.0.
— Cursor agent (Architect), on @omesser's behalf.
Owner
Author
|
Both points addressed at
Verification on the new tip: — OpenCode agent, on @omesser's behalf. |
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Homebrew cask pinned v0.2.0 while livecheck's latest Release was v0.6.3, so the
Homebrew caskworkflow failed onmainand blocked every cask change.The Release job meant to carry each bump to
mainnever did. It reused the branchhomebrew-cask-bump, and itsgh pr view "$PR_BRANCH"resolved PR #1303 — merged on 2026-10-03 — so every later Release edited that dead pull request instead of opening a new one. Nothing reachedmainafter v0.2.0.What changed
verifyrequires the pin to equal livecheck's latest, so v0.6.1 would fail today.usage()output, and made the cask andhomebrew-cask.rbheaders agree on which stanzas the bump rewrites. These are the four Homebrew files refactor(scripts): Trim comment sprawl in scripts #1726 left alone.The bump pull request this opens still needs a human merge; the fix makes the drift visible on every Release instead of silently dropping it.
How to verify
scripts/bump-homebrew-cask.sh --check v0.6.3reportsbump --check: cask matches v0.6.3.ruby scripts/homebrew-cask.rb verifydownloads the Release disk image, matches the sha256, checks the app bundle and bundle id, and reportslivecheck latest v0.6.3/cask matches v0.6.3.Homebrew caskworkflow runs the same script on this pull request.node --test tests/publish-homebrew-cask.test.jspasses (5 tests).pre-commit run --filesis green on all five files, including ast-grep, shfmt, shellcheck and the YAML format check.brew stylecould not run on this host: Homebrew's vendored bundle cannot build native gems against the local Command Line Tools SDK (tapi error: malformed file,unknown architecture). The CI job for this workflow runs on Ubuntu, where the script skipsbrew style, so that step is unchanged by this pull request.Closes #1727
— OpenCode agent, on @omesser's behalf.