Repository navigation
fix: Keep the Character hidden while a fullscreen app is frontmost (#188) - #189
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Sep 2, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Going fullscreen fades the Character out. Then it comes back and sits on the fullscreen app. The hide rule looks at the first overlapping window. The snapshot lists the Dock first. The Dock never covers a display, so after the transition the rule thinks nothing is fullscreen.
What changed
fullscreen_frontmostskips the Dock and the menu bar when they sit on a display edge and span most of that edge. A short window on the same edge still counts as frontmost. Zoomed windows and the hide hotkey are unchanged.How to verify
cargo test -p ai-buddy-core visibilitythe_dock_does_not_answer_for_the_window_behind_it— Dock in front of a fullscreen window still counts as fullscreena_short_window_on_the_bottom_edge_is_still_the_one_being_worked_in— a short window on that edge is still the frontmost appCloses #188