Skip to content

fix: Keep the Character hidden while a fullscreen app is frontmost (#188) - #189

Merged
omesser merged 3 commits into
mainfrom
fix/188-fullscreen-stays-hidden
Sep 2, 2026
Merged

omesser merged 3 commits into
mainfrom
fix/188-fullscreen-stays-hidden

Conversation

@omesser

@omesser omesser commented Sep 2, 2026 •

Copy link
Copy Markdown
Owner

Why

Going fullscreen fades the Character out. Then it comes back and sits on the fullscreen app. The hide rule looks at the first overlapping window. The snapshot lists the Dock first. The Dock never covers a display, so after the transition the rule thinks nothing is fullscreen.

What changed

fullscreen_frontmost skips the Dock and the menu bar when they sit on a display edge and span most of that edge. A short window on the same edge still counts as frontmost. Zoomed windows and the hide hotkey are unchanged.

How to verify

  • cargo test -p ai-buddy-core visibility
  • the_dock_does_not_answer_for_the_window_behind_it — Dock in front of a fullscreen window still counts as fullscreen
  • a_short_window_on_the_bottom_edge_is_still_the_one_being_worked_in — a short window on that edge is still the frontmost app
  • README step 16 on a real machine: go fullscreen and stay gone; leave fullscreen and fade back; Option-click zoom must not hide

Closes #188

omesser and others added 3 commits September 2, 2026 03:58
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@omesser omesser changed the title fix: The Dock no longer hands the Character back after fullscreen (#188) fix: Keep the Character hidden while a fullscreen app is frontmost (#188) Sep 2, 2026
@omesser
omesser merged commit cf6bf3a into main Sep 2, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Going fullscreen fades the Character out and then right back in

1 participant