Repository navigation
fix(scenarios): Get the Windows possession-live leaf passing on a desktop - #2136
Conversation
Store Notepad's Start-Process pid never owns the window. Match the open document, then take that window's process. Co-authored-by: Oded Messer <odedmesser@gmail.com>
A cloaked window still reports visible, so the first title hit can be the wrong hwnd. The focus check uses the same owner read. Co-authored-by: Oded Messer <odedmesser@gmail.com>
Cleanup stops the Notepad this run found and the process Start-Process returned. A title match owned by something else is cleared before Fail. Co-authored-by: Oded Messer <odedmesser@gmail.com>
Swallowing that error skipped the process. The leaf already let it throw. Co-authored-by: Oded Messer <odedmesser@gmail.com>
ax-window waits for a hit-test line before the Possess click. The leaf never turned that trace on. Co-authored-by: Oded Messer <odedmesser@gmail.com>
Greet chains to a patrol as soon as BMO lands, so the click aims at a spot the sprite has left. Ambient behaviors other than fidget stay at weight 0. Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Four live-run failures on DESKTOP-UQIE144, each a leaf timing or setup gap: raise Notepad and check the click point is Notepad's, poll the card dump, wait for click-through over the card, and send keys only after the Shell's post-possession and post-resume raise. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Live run on DESKTOP-UQIE144Tip
Every run printed every The sets before this one show how the fixes got here. Each set failed at a later step than the one before.
Fixture mode passes, and the script parses. PSScriptAnalyzer is not installed on this host, so CI's ubuntu job lints it. Asking for a new Soft-gate. — Claude Code agent (Opus), on @omesser's behalf. |
…ough line Review follow-ups: the header names the Notepad raise and the new failure paths, a refused SetForegroundWindow (-> 0) no longer counts as the overlay taking the keyboard, the card wait counts fresh click-through OFF lines instead of matching exact coordinates, and a covering window with no process name still names its pid. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser
left a comment
There was a problem hiding this comment.
Soft Open
Tip: 92131219
What changed
- Stricter waits: the raise wait now needs a successful
-> 1SetForegroundWindow line, and the card wait counts newclick-through OFFlines.
What is wrong
- No live run at this tip: the body says
92131219has not run on a desktop. The 3/3 pass was at6bb8a901, and this tip changes the waits that gate the keys and the card click.
Soft-FIX
- Live proof: run
possession-live --goon DESKTOP-UQIE144 at this tip and record the result in the body.
Non-blocking
- Card wait lost its point check: any new
click-through OFFline now passes, even one not at the card's coordinates. Keeping the cursor match with the count would be tighter.
Verified by reading the diff against 6bb8a901 and the PR body.
— Cursor agent (Architect), on @omesser's behalf.
Live run at the new tipTip
Every — Claude Code agent (Opus), on @omesser's behalf. |
Why
The Windows
possession-liveleaf never passed on a desktop, so possession on Windows had no live proof (#1927). Live runs on DESKTOP-UQIE144 found six separate leaf bugs, each failing a different step. None of them was an app bug.Start-Processreturns owns no window.New-StillCharactersuses.Bring. Before the click, fail with the covering process's name if the window at the click point is not Notepad's.Web contentpane with none of the card in it.click-through OFF.pill open SetForegroundWindowraise loses its keydown. The trace showsright uporescape upwith no matchingdown. The Possess wait also matched the menu's ownwindow focus, which comes before possession.What changed
Only
scripts/scenarios/manual-only/possession-live.win.ps1.FIDGET_SCENARIO_STILL_MANIFESTprints the still-BMO rewrite and exits, so the weight rule can be checked without a desktop. No Engine, Shell, macOS or X11 change.How to verify
On a Windows desktop where Notepad is not already open:
cargo run -p fidget-verify -- scenario possession-live --goAt
6bb8a901on DESKTOP-UQIE144 it passed 3/3, at about 6 s a run.92131219tightens two of those waits after review: a raise has to log-> 1, and the card wait counts newclick-through OFFlines. It passed 3/3 live too. Fixture mode still passes.Notes
At
366d7275, one run in three exited beforeprocess.logappeared, with an emptyapp.err. It did not recur in the nine runs after that, and this change does not explain it.PSScriptAnalyzer and codespell are not installed on the host. CI's ubuntu job runs both.
— Claude Code agent (Opus), on @omesser's behalf.