Repository navigation
chore: Bump the Rust crates to the released 0.8.0 - #2169
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
omesser
commented
Nov 9, 2026
omesser
left a comment
Owner
Author
There was a problem hiding this comment.
Soft Open
Tip: 24690dbc
What changed
- Workspace version:
[workspace.package] versiongoes from 0.1.0 to 0.8.0, andCargo.lockfollows for the fourfidget*crates only.
What is wrong
- Root cause stays open:
release.ymlalready computes the shipping version in theverstep but only passes it to Tauri through--config.env!("CARGO_PKG_VERSION")inacp_wire.rsandmcp_http.rskeeps readingCargo.toml, so v0.8.1 will again report 0.8.0 until someone remembers a manual bump, and every-dev.g<sha>build reports a release it isn't.
Soft-FIX
- Stamp Cargo from the release step: have
release.ymlwritesteps.ver.outputs.versioninto[workspace.package] versionbefore the Tauri build, or have the two call sites read a build env the step sets, so the ACP client info and MCPserverInfoalways match the bundle. Keeping 0.8.0 as the checked-in baseline is fine.
Non-blocking
- tauri.conf.json: with the release step stamping both, its 0.1.0 could move to 0.8.0 too so local builds agree with
Cargo.toml.
Verified cargo metadata --locked accepts the lockfile and the only CARGO_PKG_VERSION readers are the two call sites above.
— Cursor agent (Architect), on @omesser's behalf.
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The workspace has said
0.1.0since #33, while releases have reachedv0.8.0. The release workflow stamps the tag on the bundles through Tauri's--config, but that doesn't reachenv!("CARGO_PKG_VERSION"). From reading the workflow, a released Fidget should still report0.1.0in its ACP client info and MCPserverInfo. I didn't confirm that on a release build.What changed
[workspace.package] versiongoes from0.1.0to0.8.0, the latest release, andCargo.lockfollows for the four workspace crates. No dependency moved.src-tauri/tauri.conf.jsonstays at0.1.0:release.ymloverrides it, and its comment says git names the version that ships.How to verify
cargo check --workspace --all-targetspasses, and so do thefidget-mcp-servertests and themcp_httptests infidget, on Windows.git diff main -- Cargo.lockshows only the fourfidget*version lines.ast-grep,ast-grep-rule-testsandoxlintskipped because they won't install on this machine.Notes
Nothing automates this, so each later release needs the same small bump after it publishes.
🤖 Generated with Claude Code
— Claude Code, on @omesser's behalf.