Repository navigation
Conversation
Every local model measured in #175 capitalises the Behavior it names, and the exact compare threw the reply away as speech. The proposal now carries the declared spelling, which is the one the Engine can find. A trailing full stop or colon is trimmed; `say` with nothing to say falls back to Static instead of saying "say". The trace-logging the issue floated is left out — observability, not the fix.
|
Closing as redundant: #233 merged at 12:40 with the same fix — Two things this branch had that #233 left out, recorded here in case either is wanted as a small follow-up rather than lost:
Neither is worth a PR of its own unless the harness on #230 shows the trailing-punctuation case often enough to matter. The tests for both are on this branch if anyone wants them. |
|
GitHub would not reopen this PR after |
|
Landed as #242 (this PR could not be reopened after the branch rewrite). Trailing |
What
Two leftovers from the case-match that #233 already shipped:
.or:on the Behavior name inparse_proposal, before the identifier check.Prowl.andprowl:becomeprowl(thendeclaredmaps case as fix(engine): Match a declared Behavior however the model capitalises it #233 already does).saywith nothing after it isWake::Failed, so Static takes the turn. Baresay,say:, andSay.no longer speak the word "say".say | helloandsay: hellostill speakhello.Why
#231 is closed for the case bug. These two were on the same branch and were left on the close comment so they would not vanish.
A trailing full stop or colon is the model finishing a sentence, not a different name. #175 saw
Prowl.now and then. Without the trim that token failsidentifier,parse_proposalerrors, and the whole reply becomes speech — the buddy talks and never acts, the same symptom #233 fixed for case. One line at the parser.Empty
sayis a pre-existing quirk: thesayarm still did.or(Some(proposal.behavior)), so a reply that is onlysayspeaks "say". The trim makessay:andSay.reach that arm, so the quirk widens unless emptysayfalls back to Static.Not done: logging an unknown-but-close name under
AI_BUDDY_TRACE_DIRECTOR(#231 also floated that). Observability, not this fix.Does not close #231 (already closed by #233).
How to test
Automated scenarios this PR covers:
Prowl.,prowl:, andPROWL. | huntingplay declaredprowlnap./nap:are the namenap; dialogue after|is untouched;Nap.still comes through asNapfordeclaredto mapsay,say:, andSay.are a failed wake (Static), not spoken "say"say | hellostill speakshello