Repository navigation
Record the core/shell crate split in the spec - #24
Merged
Merged
Conversation
omesser
force-pushed
the
docs/23-core-crate-decision
branch
from
August 28, 2026 02:28
03f3e88 to
81ee0f5
Compare
The spec already says the Engine is pure with no I/O, and the source honours it. The crate does not: everything lives in one crate that depends on tauri and objc2, so cargo test links the platform stack to run arithmetic, the Rust checks cannot run on Linux at all, and nothing would fail if a future change imported Tauri into the Engine. Writing the layout down makes the boundary a build property instead of a convention, and names where Memory belongs, which is the case most likely to be argued: it does file I/O but has no platform dependency, so it is core. Decision only. The layout stays single-crate until issue #23 lands, which is sequenced after the three open branches merge to avoid conflicting with all of them. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
omesser
force-pushed
the
docs/23-core-crate-decision
branch
from
August 28, 2026 02:30
81ee0f5 to
0a042ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #23. Decision only — no code moves here.
What changed
docs/SPEC.md"Overall shape" now states the crate layout: a core crateholding the Engine, the overlay hit-testing arithmetic and Memory, depending on
neither
taurinor any platform binding; and a shell crate depending on it,holding
main.rs, the Tauri setup, the AppKit panel work andWindowSource.Why it looks like this
The spec already calls the Engine "pure, synchronous, no I/O" and the primary
test seam. The source honours that —
engine.rshas no imports outside its owntest module. The crate does not: everything lives in
ai-buddy, which depends ontauriandobjc2, socargo testlinks the whole platform stack to runarithmetic, and
.github/workflows/tests.ymlhas to skip the Rust hooks on Linuxand run a second macOS job instead.
The point of writing it down is that purity becomes a build property rather than
a property of the source. Today nothing would fail if a change imported Tauri
into the Engine.
It also settles the case most likely to be argued: Memory does file I/O and still
belongs in core, because the rule is no platform or toolkit dependency, not no
I/O.
How to verify
Documentation only. No code changed, so there is nothing to run beyond CI.
Known and deferred
since merged, so it now waits only on Engine core: a snapshot in, a frame out #22, which adds
engine.rs; splittingbefore that lands would conflict with it.
cargo treeon the core cratemust show no
tauriand noobjc2*, so the boundary is checked rather thantrusted.
🤖 Generated with Claude Code