Repository navigation
ci: Build and attach Windows NSIS bundles on Release - #343
Merged
Merged
Conversation
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
marked this pull request as ready for review
September 4, 2026 21:56
Releases attach a Windows installer now. Point Install/DESIGN/SPEC (and the research row) at that, and keep stub/degraded for the remaining platform cells only.
This was referenced Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Release workflow currently builds only macOS (dmg) and Linux (appimage, deb) bundles. Windows users have no installer, even though the runtime itself targets Windows at some level. This adds the packaging step so GitHub Releases include all three platforms.
What changed
Workflow inputs: Added three boolean checkboxes to
workflow_dispatch—linux,macos,windows— each defaulting to true. Manual runs now honor those checkboxes; arelease(published) trigger always builds all three platforms regardless of input state.Matrix: Added
windows-latest/nsis/ keywindowsrow. Each matrix row now carries akeyfor conditional evaluation.Job-level
if: Thepackagejob runs a matrix row when either:releaseevent (builds all three), ORworkflow_dispatchand the corresponding input boolean is trueVersion step: Explicitly uses
shell: bashso the existing bash script runs on Windows via Git for Windows bash (already present onwindows-latestrunners).Bundle targets: Added
nsistosrc-tauri/tauri.conf.jsonso localtauri buildcan produce Windows installers alongside the existing dmg/appimage/deb.Comment updates: Changed job comment from "Windows is stubbed… no row" to note that Windows packages NSIS installers while runtime furniture (#197) remains stubbed in SPEC.
How to verify
YAML validity: Checked with Python's YAML parser — syntax is valid.
Expected behavior:
workflow_dispatchwith all three checkboxes true builds all threelinux: truebuilds only the Linux rowwindows: truebuilds only the Windows rowWindows-specific considerations:
windows-latestrunners include Git for Windows bash, so the version-stamping step's bash script runs without modificationtauri-apps/tauri-action@v1already handles WebView2 bootstrapping on Windows; no extra setup step requiredArtifacts: The
tauri-actionwithuploadWorkflowArtifacts: trueandreleaseIdwill attach Windows NSIS installers to the Release the same way macOS and Linux bundles are attached today.Notes
This does not close the Windows runtime stub tracked in #197. It only adds the packaging/Release workflow coverage so Windows installers are built and published when a Release is cut.
— Cursor agent, on @omesser's behalf.