Skip to content

ci: Build and attach Windows NSIS bundles on Release - #343

Merged
omesser merged 2 commits into
mainfrom
cursor/release-windows-bundles-869d
Sep 4, 2026
Merged

omesser merged 2 commits into
mainfrom
cursor/release-windows-bundles-869d

Conversation

@omesser

@omesser omesser commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Why

The Release workflow currently builds only macOS (dmg) and Linux (appimage, deb) bundles. Windows users have no installer, even though the runtime itself targets Windows at some level. This adds the packaging step so GitHub Releases include all three platforms.

What changed

Workflow inputs: Added three boolean checkboxes to workflow_dispatch — linux, macos, windows — each defaulting to true. Manual runs now honor those checkboxes; a release (published) trigger always builds all three platforms regardless of input state.

Matrix: Added windows-latest / nsis / key windows row. Each matrix row now carries a key for conditional evaluation.

Job-level if: The package job runs a matrix row when either:

  • The trigger is a release event (builds all three), OR
  • The trigger is workflow_dispatch and the corresponding input boolean is true

Version step: Explicitly uses shell: bash so the existing bash script runs on Windows via Git for Windows bash (already present on windows-latest runners).

Bundle targets: Added nsis to src-tauri/tauri.conf.json so local tauri build can produce Windows installers alongside the existing dmg/appimage/deb.

Comment updates: Changed job comment from "Windows is stubbed… no row" to note that Windows packages NSIS installers while runtime furniture (#197) remains stubbed in SPEC.

How to verify

YAML validity: Checked with Python's YAML parser — syntax is valid.

Expected behavior:

  • A Release publish (e.g., tagging v1.2.3 and publishing the Release in GitHub UI) triggers all three OS builds and attaches artifacts to the Release
  • A manual workflow_dispatch with all three checkboxes true builds all three
  • A manual run with only linux: true builds only the Linux row
  • A manual run with only windows: true builds only the Windows row

Windows-specific considerations:

  • windows-latest runners include Git for Windows bash, so the version-stamping step's bash script runs without modification
  • tauri-apps/tauri-action@v1 already handles WebView2 bootstrapping on Windows; no extra setup step required
  • NSIS is the standard Tauri Windows installer format

Artifacts: The tauri-action with uploadWorkflowArtifacts: true and releaseId will attach Windows NSIS installers to the Release the same way macOS and Linux bundles are attached today.

Notes

This does not close the Windows runtime stub tracked in #197. It only adds the packaging/Release workflow coverage so Windows installers are built and published when a Release is cut.

— Cursor agent, on @omesser's behalf.

Open in Web Open in Cursor 

Co-authored-by: Oded Messer <odedmesser@gmail.com>
@omesser
omesser marked this pull request as ready for review September 4, 2026 21:56
Releases attach a Windows installer now. Point Install/DESIGN/SPEC (and the
research row) at that, and keep stub/degraded for the remaining platform cells
only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants