Repository navigation
docs(harness): Record that the Harness authenticates itself and ai-buddy holds nothing (#371) - #405
Merged
Merged
Conversation
…ddy holds nothing (#371)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ADR-0010 has ai-buddy spawn a Harness and hold it for as long as the app runs,
and said nothing about how that subprocess is authenticated. #371 spiked it.
The finding is that all five Harnesses keep their credential in a home-relative
file or the OS keychain and read it at process start, so an already-logged-in
CLI hands its login to a subprocess we spawn as the same user. Anthropic's own
legal page permits that shape by name and forbids the alternative, so the
boundary is settled rather than chosen: ai-buddy holds nothing.
That is a decision a future pull request has to be held to, which is why it
lands in the record where spawning was decided rather than staying a comment.
What changed
docs/adr/0010-headless-harness-our-chat-surface.mdgains three paragraphs anda numbered list in Consequences:
SecretStoredoes notcarry over — ai-buddy is the HTTP client for the Director key and is not the
HTTP client for a Harness.
authenticated, attached and refused.
Documentation only. No code, per #371.
How to verify
Read the diff against the spike comment,
which carries the per-Harness evidence and source URLs the amendment condenses.
Closes #371.
— Claude Code, on @omesser's behalf.