Skip to content

fix(settings): Stop offering consent rows Linux cannot grant - #538

Merged
omesser merged 1 commit into
mainfrom
fix/250-linux-sensing-consent
Sep 8, 2026
Merged

omesser merged 1 commit into
mainfrom
fix/250-linux-sensing-consent

Conversation

@omesser

@omesser omesser commented Sep 8, 2026 •

Copy link
Copy Markdown
Owner

Why

The Linux settings pane offered two checkboxes — Accessibility and Screen
Recording — that nothing on Linux can grant. form::describe() declared them on
every platform and the GTK renderer filtered them back out by id, so the shared
form described a consent model Linux does not have.

What changed

Linux declares no consent rows: the omission moves from the renderer to
privacy_sections(), and should_omit_row is deleted. macOS and Windows keep
their two rows.

Two files follow from that, both load-bearing. settings.rs gates
BoolField::UseAccessibility / UseScreenRecording the way Capturable
already is — with no Linux row constructing them, a variant that is only matched
is a dead_code warning, and the Linux job denies warnings. consent.rs holds
the pane's Linux copy, now opening "there is nothing to turn on" because the
section renders prose with nothing under it, plus a test that Null reports no
grant and invents none when prompted.

ADR-0005 called the platform grant "Screen Recording on macOS, its equivalent
elsewhere"; Linux has no equivalent, so it now says what Linux does instead.
DESIGN.md §9 gets the same correction beside the pane it describes.

Linux's own grant is an xdg-desktop-portal session that waits on Capture. None
of it is here; #250 stays open for it.

How to verify

cargo test (816), clippy -D warnings, cargo fmt, pre-commit --all-files,
node --test tests/ — green on macOS. consent_section_has_two_checkboxes now
asserts Linux declares no rows and Windows still declares two. The Linux leg of
checks is what compiles platform/x11/ and proves the gating.

Notes

— Cursor agent (Coder), on @omesser's behalf.

Linux has no TCC. The shared form declared both rows on every platform
and the GTK renderer filtered them back out; now Linux declares none.
Windows keeps its rows. #250.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@omesser
omesser force-pushed the fix/250-linux-sensing-consent branch from 5895517 to b9d71ae Compare September 8, 2026 04:50
@omesser omesser changed the title fix(settings): Stop offering macOS TCC rows on Linux fix(settings): Stop offering consent rows Linux cannot grant Sep 8, 2026
@omesser
omesser merged commit 162f6de into main Sep 8, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant