Repository navigation
fix(settings): Stop offering consent rows Linux cannot grant - #538
Merged
Merged
Conversation
4 tasks
Linux has no TCC. The shared form declared both rows on every platform and the GTK renderer filtered them back out; now Linux declares none. Windows keeps its rows. #250. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
omesser
force-pushed
the
fix/250-linux-sensing-consent
branch
from
September 8, 2026 04:50
5895517 to
b9d71ae
Compare
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Linux settings pane offered two checkboxes — Accessibility and Screen
Recording — that nothing on Linux can grant.
form::describe()declared them onevery platform and the GTK renderer filtered them back out by id, so the shared
form described a consent model Linux does not have.
What changed
Linux declares no consent rows: the omission moves from the renderer to
privacy_sections(), andshould_omit_rowis deleted. macOS and Windows keeptheir two rows.
Two files follow from that, both load-bearing.
settings.rsgatesBoolField::UseAccessibility/UseScreenRecordingthe wayCapturablealready is — with no Linux row constructing them, a variant that is only matched
is a
dead_codewarning, and the Linux job denies warnings.consent.rsholdsthe pane's Linux copy, now opening "there is nothing to turn on" because the
section renders prose with nothing under it, plus a test that
Nullreports nogrant and invents none when prompted.
ADR-0005 called the platform grant "Screen Recording on macOS, its equivalent
elsewhere"; Linux has no equivalent, so it now says what Linux does instead.
DESIGN.md §9 gets the same correction beside the pane it describes.
Linux's own grant is an xdg-desktop-portal session that waits on Capture. None
of it is here; #250 stays open for it.
How to verify
cargo test(816), clippy-D warnings,cargo fmt,pre-commit --all-files,node --test tests/— green on macOS.consent_section_has_two_checkboxesnowasserts Linux declares no rows and Windows still declares two. The Linux leg of
checksis what compilesplatform/x11/and proves the gating.Notes
platform/x11/iscfg'd out on macOS, so the GTK edit was not compiled orrun here. Linux CI is the only evidence.
desktop.
— Cursor agent (Coder), on @omesser's behalf.