Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 22 additions & 16 deletions CONTEXT.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,12 @@ _Avoid_: Routine, script, macro
The role that proposes a Behavior, and Speech when the session is on. Static
weights fill Behaviors and never speak; an attached Harness is that role and
proposes Speech by calling speak. Never runs in the frame loop and never
drives animation directly.
_Avoid_: Brain, agent, planner
drives animation directly. Covers both Static Director and AI Director (ModelDirector).
The environment variables `AI_BUDDY_DIRECTOR_*` configure the HTTP Completer,
which is one fill of this role (#466).
_Avoid_: Brain, agent, planner. In user-facing Settings and README: the role
name "Director" when it means the on/off switch or HTTP configuration — say
"AI" / "AI on" for the toggle, "Model" / "API" for HTTP knobs instead

**Proactive model call**:
A Director session wake that fires because the buddy was left alone long
Expand Down Expand Up @@ -178,15 +182,19 @@ behalf. Supplied by the user, never bundled.
_Avoid_: Backend, provider, model

**Completer**:
Whatever answers a Character Prompt behind the one session trait
([ADR-0008](./docs/adr/0008-one-harness-session.md)): the attached Harness
over ACP, or the HTTP chat-completions endpoint when none is attached
([ADR-0017](./docs/adr/0017-acp-client-over-the-official-sdk-and-supported-harnesses.md)).
Settings names the HTTP one's timeout and reply cap, which is where the word
reaches the screen. That one streams, so the first token arrives long before
the reply and a dropped call stops the host generating rather than merely
going unheard; one that will not stream is answered whole instead.
_Avoid_: Model, LLM, provider, API
The session trait the Director role uses to answer Character Prompts, filled by
either HTTP chat-completions or an attached Harness over ACP
([ADR-0008](./docs/adr/0008-one-harness-session.md),
[ADR-0017](./docs/adr/0017-acp-client-over-the-official-sdk-and-supported-harnesses.md)).
Director is the role; Completer is the umbrella trait both fills implement.
When no Harness is attached, the HTTP Completer streams chat-completions (first
token arrives long before the reply; a dropped call stops the host generating
rather than merely going unheard; non-streaming hosts are answered whole). When
a Harness is attached, it fills the trait instead. Settings names the HTTP
fill's timeout and reply cap. The environment variables
`AI_BUDDY_DIRECTOR_BASE_URL`, `AI_BUDDY_DIRECTOR_MODEL`, and
`AI_BUDDY_DIRECTOR_API_KEY` configure the HTTP Completer (#466).
_Avoid_: Using "Completer" as user-facing brand, or as synonym for HTTP-only fill

**Executor**:
Whatever posts synthetic mouse and keyboard events to the operating system.
Expand Down Expand Up @@ -283,11 +291,9 @@ _Avoid_: Reasoning pane, thoughts, chain of thought, transcript
The window a Summon opens: where the user types to the attached Harness and
reads the answers too long for a Speech bubble. Belongs to the Character
Instance that was Summoned, and is drawn by ai-buddy rather than by the
Harness. The term for internal writing — code, ADRs, `DESIGN.md`. User-facing
copy says "chat window", which is friendlier and names the same thing. #17,
ADR-0010.
_Avoid_: console, terminal, prompt box, Chat UI (its visual design, not the
window); Chat surface in user-facing copy, Chat window in internal writing
Harness. #17, ADR-0010.
_Avoid_: Chat window, console, terminal, prompt box, Chat UI (its visual
design, not the window)

**Chat UI**:
A named, swappable visual design for the Chat surface — palette, type scale and
Expand Down
13 changes: 7 additions & 6 deletions docs/research/naming-review-2026-09.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,15 @@ No mechanical renames identified. The codebase accurately uses CONTEXT.md terms:
- **State, Perch, Surface, Contact**: Match glossary.
- **Speech, speak, Cue**: Correct usage.

### 🟡 Defer / Issue
### 🟢 Completed (Issue #466)

**User-facing Settings UI copy** (issue #466):
- Variable names like `AI_BUDDY_DIRECTOR_BASE_URL` say "Director" but configure
the Completer's endpoint.
- Settings section "Director" mixes Director-the-role with Completer fields.
- This is a **product decision**, not a code-internal naming issue.
- Already tracked in #466; no code PR should touch this without Oded's input.
- Decision (locked): Keep Director as domain role; fix user-facing labels
- Environment variables remain `AI_BUDDY_DIRECTOR_*` (no breaking change)
- Settings section renamed to "AI" (not "Director" or "AI Completer")
- Toggle label: "AI on" (clear what it means)
- HTTP field labels: "Model", "API key" (not "Director" or "Completer")
- CONTEXT.md clarifies: Director = role, Completer = trait (HTTP|Harness umbrella)

### ⚪ Leave (Intentional / Not Churny)

Expand Down
4 changes: 2 additions & 2 deletions src-tauri/src/menu.rs
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ pub fn describe(snapshot: MenuSnapshot<'_>) -> MenuDescription {
entries.push(MenuEntry::Check {
id: DIRECTOR_ID.to_string(),
label: match snapshot.director_env_owned {
true => format!("Director (set by {})", crate::model::ENABLED),
false => "Director".to_string(),
true => format!("AI (set by {})", crate::model::ENABLED),
false => "AI".to_string(),
},
enabled: !snapshot.director_env_owned,
checked: snapshot.director_enabled,
Expand Down
40 changes: 17 additions & 23 deletions src-tauri/src/settings/form.rs
Original file line number Diff line number Diff line change
Expand Up @@ -559,12 +559,12 @@ fn director_sections() -> Vec<FormSection> {
http_row("Base URL", model::BASE_URL, driving, configured);
let (model_label, model_frozen) = http_row("Model", model::MODEL, driving, configured);
let (api_key_label, api_key_frozen) = http_row("API key", model::API_KEY, driving, configured);
let (director_label, director_frozen) = switch_row("Director on", model::ENABLED);
let (director_label, director_frozen) = switch_row("AI on", model::ENABLED);
let (wake_label, wake_frozen) = env_row("First wake, in seconds", model::WAKE_SECS);

vec![
FormSection {
heading: "Director".to_string(),
heading: "AI".to_string(),
comment: None,
rows: vec![
FormRow::Checkbox {
Expand Down Expand Up @@ -715,7 +715,7 @@ fn director_sections() -> Vec<FormSection> {
fn completer_source_section() -> FormSection {
let (source_label, frozen) = harness_env_row("Harness");
FormSection {
heading: "Completer source".to_string(),
heading: "AI source".to_string(),
comment: Some(
"Director off runs on static weights. Director on with no Harness is the \
HTTP Completer above. Director on with a Harness that answers makes \
Expand Down Expand Up @@ -1017,7 +1017,7 @@ fn development_sections() -> Vec<FormSection> {
rows,
},
FormSection {
heading: "Completer limits".to_string(),
heading: "HTTP limits".to_string(),
comment: Some("Also for development and testing. Blank uses the default.".to_string()),
rows: vec![
FormRow::TextField {
Expand Down Expand Up @@ -1104,7 +1104,7 @@ pub fn describe() -> FormDescription {
sections: character_sections(),
},
FormTab {
title: "Director".to_string(),
title: "AI".to_string(),
sections: director_sections(),
},
FormTab {
Expand Down Expand Up @@ -1161,9 +1161,9 @@ mod tests {

let mut expected = vec![
"Character",
"Completer limits",
"Completer source",
"Director",
"HTTP limits",
"AI source",
"AI",
"Do Not Disturb",
"Excluded applications",
"Harness attachment",
Expand All @@ -1189,13 +1189,7 @@ mod tests {
.collect();
assert_eq!(
titles,
vec![
"Presence",
"Character",
"Director",
"Privacy",
"Development"
]
vec!["Presence", "Character", "AI", "Privacy", "Development"]
);
for tab in &description.tabs {
assert!(!tab.sections.is_empty(), "{} has no section", tab.title);
Expand Down Expand Up @@ -1357,12 +1351,12 @@ mod tests {
}

#[test]
fn director_section_has_two_checkboxes() {
fn ai_section_has_two_checkboxes() {
let description = describe();
let director = description
.sections()
.find(|s| s.heading == "Director")
.expect("Director section");
.find(|s| s.heading == "AI")
.expect("AI section");

assert_eq!(director.rows.len(), 9);
assert!(matches!(
Expand Down Expand Up @@ -1581,9 +1575,9 @@ mod tests {
.is_some()
};

assert!(has_help("Director", DIRECTOR_ID));
assert!(has_help("Director", AMBIENT_ID));
assert!(has_help("Completer source", HARNESS_STATE_ID));
assert!(has_help("AI", DIRECTOR_ID));
assert!(has_help("AI", AMBIENT_ID));
assert!(has_help("AI source", HARNESS_STATE_ID));
assert!(has_help("Last user turn", PAYLOAD_ID));
assert!(has_help("Do Not Disturb", DND_ID));
assert!(has_help("Do Not Disturb", SOUND_ID));
Expand Down Expand Up @@ -2039,8 +2033,8 @@ mod tests {
fn source_section(description: &FormDescription) -> &FormSection {
description
.sections()
.find(|section| section.heading == "Completer source")
.expect("the Completer source section exists")
.find(|section| section.heading == "AI source")
.expect("the AI source section exists")
}

fn popup_row(description: &FormDescription, id: &str) -> (String, Vec<String>, bool) {
Expand Down