Repository navigation
fix(harness): Let the login table outrank the handshake description - #676
Merged
Merged
Conversation
ACP auth method descriptions are prose, not commands, so Settings told users to run "Use Claude subscription". The claude-only guard was dead because claude-code-acp advertises no methods without a terminal client. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
login_commandtook the handshake's firstauthMethodsdescription before the table of documented sign-in commands. ACP never asked adapters to put a command there, so they write prose: claude-code-acp says "Use Claude subscription", codex-acp names "API Key" and "ChatGPT", opencode says "Runopencode auth loginin the terminal". Only aterminal-type method carries something runnable, inargs, and ADR-0018 hosts no terminal to run it.The
name == "claude"guard dodged this for one Harness, and it was dead: claude-code-acp advertises no methods unless the client setsclientCapabilities.auth.terminal, which ai-buddy does not. A user on codex would have seen Settings tell them to runUse Claude subscriptionorChatGPT.What changed
claudeguard is gone.named_loginholds the table asOption<&'static str>;login_hintandlogin_commandboth read it, soselect_harnessinmain.rsis unchanged.How to verify
cargo test -p ai-buddy: 417 passed, 0 failed, 4 ignoredcargo clippy --workspace --all-targets -- -D warnings: cleannode --test tests/: 108 pass, 0 failFollows #661.
— Claude Code agent, on @omesser's behalf.
🤖 Generated with Claude Code