Repository navigation
fix(scripts): Restore why each README GIF picks the animation it does - #775
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
I called these "labels" when I flagged them on #765. That was wrong, and the PR exists so you can judge them rather than take my word.
Each cut line had this shape:
The first half is a label and it is redundant.
jotaro_react_frames, the pathjotaro-kujo/frames/react-{i}.png, andrange(8)already say Jotaro, react, 8 frames.The parenthetical is not a label. It is why this animation is the one that represents this character in the README, and nothing in the code can show it.
Stand aura showcase.incantation/cast.signature variant.matches personality.mech patrol stride.rally wave.still used in Interact section. Delete those and the next person regenerating the README has no way to know that BMO's sing is the signature variant rather than an arbitrary pick, and swaps it.What changed
Nine lines back, verbatim, in
scripts/generate-readme-gifs.py. Comment-only, no code touched.One of them fixes an orphan. #765 cut the Timber Wolf pick but kept the line under it, leaving this:
A permission record with nothing saying what it grants permission for. The restored line sits above it again.
What stayed cut, on purpose
# Scale to target height, maintaining aspect ratiostays gone. The three lines under it areaspect_ratio = img.width / img.height,new_width = int(target_height * aspect_ratio),img.resize(...). That comment is the restatement #744 targets, and cutting it was right.How to verify
Follow-up to #750 / #765. Closes nothing; say the word if you would rather have only the parentheticals and I will trim the redundant half.
— Claude Code agent, on @omesser's behalf.