Skip to content

fix(scripts): Restore why each README GIF picks the animation it does - #775

Merged
omesser merged 1 commit into
mainfrom
fix/readme-gif-picks
Sep 16, 2026
Merged

omesser merged 1 commit into
mainfrom
fix/readme-gif-picks

Conversation

@omesser

@omesser omesser commented Sep 16, 2026

Copy link
Copy Markdown
Owner

Why

I called these "labels" when I flagged them on #765. That was wrong, and the PR exists so you can judge them rather than take my word.

Each cut line had this shape:

# Jotaro Kujo: react animation (Stand aura showcase, 8 frames)
jotaro_react_frames = [
    chars_dir / "jotaro-kujo" / "frames" / f"react-{i}.png" for i in range(8)
]

The first half is a label and it is redundant. jotaro_react_frames, the path jotaro-kujo/frames/react-{i}.png, and range(8) already say Jotaro, react, 8 frames.

The parenthetical is not a label. It is why this animation is the one that represents this character in the README, and nothing in the code can show it. Stand aura showcase. incantation/cast. signature variant. matches personality. mech patrol stride. rally wave. still used in Interact section. Delete those and the next person regenerating the README has no way to know that BMO's sing is the signature variant rather than an arbitrary pick, and swaps it.

What changed

Nine lines back, verbatim, in scripts/generate-readme-gifs.py. Comment-only, no code touched.

One of them fixes an orphan. #765 cut the Timber Wolf pick but kept the line under it, leaving this:

# Permission granted by MekaRamen (Yeoh Kher En) to publish (#388)
timber_wolf_walk_frames = [

A permission record with nothing saying what it grants permission for. The restored line sits above it again.

What stayed cut, on purpose

# Scale to target height, maintaining aspect ratio stays gone. The three lines under it are aspect_ratio = img.width / img.height, new_width = int(target_height * aspect_ratio), img.resize(...). That comment is the restatement #744 targets, and cutting it was right.

How to verify

python3 -c "import ast; ast.parse(open('scripts/generate-readme-gifs.py').read())"   # parses
pre-commit run --files scripts/generate-readme-gifs.py                                # exit 0
node --test tests/*.test.js                                                           # 212 pass, 0 fail

Follow-up to #750 / #765. Closes nothing; say the word if you would rather have only the parentheticals and I will trim the redundant half.

— Claude Code agent, on @omesser's behalf.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@omesser
omesser merged commit 971bbe8 into main Sep 16, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant