Repository navigation
refactor(core): Compact the Engine's comments, remaining files (#747 slice 3) - #780
Merged
Merged
Conversation
Owner
Author
CLEARED @
|
This was referenced Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slice 3 of #747 (part 3 of #744): the remaining files under
crates/core/src/, every block judged against #744's five-step procedure by hand, one exact-match swap per block. No regex pass, no codemod.What changed
12 files. Comment lines 1460 -> 898, blocks over three lines 133 -> 8. Every retained block carries a reason, a constraint, a bound or a rejected alternative; blocks that restated the code are gone, and history moved to
git log.Eight blocks stay over the ceiling, each under a named #744 exception:
memory.rsmodule doc,data_dir,MemoryManifest::writing,backup_path: the fourponytail:markers, left whole.git diff -U0 origin/main -- crates/core/src/memory.rs | grep -i ponytailis empty.director/prompt.rscharacter_prompt(7 lines):blankkeeping the Instance Prompt and the empty seats is a rejected alternative a reader would re-attempt.engine/geometry.rsis_perch(7): first-match-in-z-order is the rejected alternative that drops the sprite through a visible edge.snapshot.rsperch_eligible(7):layer == 0is a bound that looks arbitrary; the layer numbers are what make it defensible.visibility.rsmodule doc (8): Do Not Disturb and screen share are two rules a reader would add back.Long function docs that explained several rules at once (
dock_side_reached,footing,fullscreen_frontmost,bubble_owner,in_overlay,hit) became a 3-line summary plus a 2-3 line inline comment on the line each rule governs. Every bare issue reference in these files (#6 #39 #78 #85 #98 #100 #109 #128 #145 #156 #176 #177 #178 #188 #247 #277 #288 #362 #395 #443 #502 #657) is dropped with its fact kept; ADR and DESIGN.md citations stay. One codespell hit (unparseable) fixed in prose.Skipped, and why
engine.rs: slice 1.director.rs,character.rs: slice 2.character/manifest.rs,character/resolve.rs,dispatch.rs,roster.rs,scheduler.rs: all five appear ingh pr diff 689 --name-only(feat(engine): Land a dropped Prop on a Perch, open). Its owner goes first; these are a follow-up once feat(engine): Land a dropped Prop on a Perch #689 lands. feat(timber-wolf): Garrison sleep loop from new capture (with lasers) #608 touches nocrates/corefile.Stale cross-reference in #747: it says to wait for #745 (the amended standard). #745's own body resequences it to land last, after #747-#750, because it quotes source verbatim. This PR compacts to the bar in #744 and #747's one-line rule; do not stall on #745.
How to verify
No code line changes. Over
git diff -U0, printing every added or removed line that is not wholly a comment or blank, then the count:Output on this branch against
origin/main:tools.rskept one restating comment (// No instance_id provided) because deleting it makes rustfmt collapse the surroundingNone => { match .. }block, which would be a code-line change.Tests, diffed by name.
cargo test --workspace: 1015 passed, 4 ignored before and after; the 1019test ... ok/ignoredlines sorted are byte-identical (diffempty).node --test tests/*.test.js: 212/212 before and after, names identical.cargo clippy --workspace --all-targets -- -D warningsandcargo fmt --all -- --checkclean. Pre-commit (codespell, cargo-fmt, cargo-clippy) passed on commit.Census from a throwaway counter: a comment line is a line that is wholly
//,///or//!; ratio is comments / (comments + code); a block is a run of consecutive comment lines.🤖 Generated with Claude Code