Repository navigation
docs(adr): Name ACP attach gates in ADR-0003 Consequences - #818
Merged
Merged
Conversation
Co-authored-by: Oded Messer <odedmesser@gmail.com>
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ADR-0003 Consequences named a Pro or Max subscription and an interactive session, then treated "users without both" as the loss. Anthropic's computer-use page names four gates. The ACP attach path uses print mode, so the interactive gate fires on every plan. The decision to ship no Executor still stands. The consequence was incomplete.
Findings:
docs/research/harness-tools-under-acp-probe.md, "Where this contradicts what the repository already says".What changed
Amended the first Consequences paragraph of ADR-0003 in place. A superseding ADR would restate the same bet under a new number. The architecture is unchanged: ai-buddy ships no Executor, and the Harness owns desktop control.
The paragraph now names macOS, Pro or Max (not Team or Enterprise), claude.ai auth, and an interactive session (not
-por other non-interactive modes). It records that the Agent SDK thatclaude-agent-acpruns uses stream-json print mode, so the interactive gate bears on attach. Under the ACP attach path the Functional Layer is unavailable on every plan. #508 is the only route being evaluated.The
CGEventshelf sentence is unchanged. That item is not under evaluation. Dropping its subscription condition would change fallback policy, which this issue does not ask for.Out of scope: product code, the cwd ADR (#796), attach cwd (#782), DESIGN, SPEC, and README.
How to verify
pre-commit run --files docs/adr/0003-no-executor-harness-owns-desktop-control.md(passed in the worktree, including codespell andadr-numbers-unique)node --test tests/*.test.js(260 passed, 0 failed)Notes
Refs #785 and umbrella #798. Follows
docs/agents/docs.md: complete Consequences when the decision stands.Closes #785
— Cursor agent (Coder), on @omesser's behalf.