Repository navigation
feat(settings): Move the BYO Harness architecture copy behind disclosures - #870
Merged
Merged
Conversation
…ures Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#548 asks for everyday Settings screens that scan without reading architecture paragraphs. #593 built the mechanism —
FormRowandFormSectioncarrydisclosureandstatus, and all four renderers (AppKit, GTK, Win32, webview) draw them — and moved 22 rows and sections behind it. The one section added since, the "Harness you run yourself" MCP registration block from #599, landed with no disclosure at all, so its 196-character section comment and a 155-character row help sit in the default view of the AI tab, next to helps that run 38–62 characters.What changed
Two moves in
byo_section()insrc-tauri/src/settings/form.rs, and nothing else. Both fixtures regenerated to match.Deliberately left alone, after auditing every section comment, row help and label in the form:
InspectBlockrows with a disclosure both already exist elsewhere in the form, so all four surfaces already draw this shape.How to verify
cargo test -p ai-buddy— 529 passed, 0 failed, 6 ignored.both_ai_sources_serialize_to_the_committed_fixturespasses against the regenerated fixtures, and each fixture diff contains only the two moves above.node --test tests/*.test.js— 288 passed, 0 failed.cargo clippy --workspace --all-targets -- -D warnings— clean.pre-commit run --all-files— every hook passed.On a build, open Settings → AI and scroll to the "Harness you run yourself" section: one-line section comment, the disclosure below it, and a one-line help under the registration snippet.
Notes
Closing #548 rather than referencing it. Its three acceptance boxes: scannable everyday screens (this PR, on top of #593 — every everyday section comment is now at most 105 characters and every everyday help at most 85, with a disclosure wherever there is mechanism to explain); Development tab unchanged on the main strip (untouched); specified enough for GTK / AppKit / Win32 parity (the copy lives in the shared
FormDescription, so the three native renderers and the webview cannot disagree). The optional dated Settings IA page the issue floated is skipped, as the issue marks it optional.Refs #548
— Claude Code agent, on @omesser's behalf.
🤖 Generated with Claude Code
On closing
Left as
Refs. The first acceptance box, "everyday Settings screens are scannable without reading architecture paragraphs", is a judgment about the product rather than a check a diff can settle, and the issue still carriesneeds-triage. The issue's optional second proposal, a dated Settings IA page, is also untouched. Closing it is the owner's call to make with a look at the screens, not this PR's to take on merge.