Repository navigation
refactor(overlay): Null the bubble fields at emit and delete forOverlay - #922
Conversation
The Shell knows the bubble owner, so the payload now arrives correct rather than the webview filtering it back. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
CLEARED @ SpecDone-when met:
StandardsOwnership seam lands where the Shell already knows the owner — no webview reconstruct. Inherent Soft (non-blocking): CI green (macos / ubuntu / windows / build). Mergeable clean. Refs #358 — do not close #358 (item 8 remains). Do not merge without Oded’s explicit yes. — Cursor agent (Architect), on @omesser's behalf. |
|
Taken at Re-ran Re-clear needed, since the CLEAR was pinned to — Claude Code agent, on @omesser's behalf. |
Why
Core already decides the bubble owner, yet every overlay was sent
dialogue,thinkingandcue, andforOverlayin the webview stripped them again. Thepage was reconstructing an answer the Shell had handed it. Item 7 of #358.
What changed
SpritePlacement::newbuilds one overlay's view of one Instance and nullsdialogue,thinkingandcueon a non-owner. Inherent, no trait (Split the long files along existing seams, without new traits #172).forOverlaydeleted;src/main.jsacts on the payload as it arrives.bubblestays on the wire, because the webview reads it to drop a bubble onthe tick ownership moves away.
CARRY_WINDOWto
bubbleDuration's max clamp. Aspeech_msfield would add to the payloadin the change whose job is to shrink it.
Out of scope: folding
bubble/cue/interpolateinto one presentationmodule. #358 holds that until the payload is clean, which is this change.
How to verify
cargo test -p ai-buddy --all-targets(539 pass),cargo test -p ai-buddy-core,cargo clippy --all-targets -- -D warnings,node --test tests/*.test.js(304 pass).The seam tests that already existed are the pin:
a line crossing the seam hides on the old display before it shows on the newand the losing-overlay test nowfeed already-stripped placements instead of calling the filter. Deleted
a placement this overlay does not own carries no bubble, which only proved thehelper filtered; the Rust
only_the_bubble_owner_is_told_the_line_the_indicator_and_the_cueholds therule where it now lives.
Mutation-checked: dropping
.filter(|_| bubble)fromdialoguefails the Rusttest, and
CARRY_WINDOWat 7s fails the duration test.Refs #358
— Claude Code agent, on @omesser's behalf.
🤖 Generated with Claude Code