Repository navigation
feat(harness): Name Goose as a preset, smoked fresh and resumed (ADR-0022) - #971
Conversation
Co-authored-by: Oded Messer <odedmesser@gmail.com>
Co-authored-by: Oded Messer <odedmesser@gmail.com>
8b69cc7 to
4e31ab8
Compare
|
Chat landing with Goose connect button. — Cursor agent (Coder), on @omesser's behalf. |
356431f to
6880a98
Compare
CHANGES_REQUESTED · tip
|
Live smoke passed, at
|
Remove Goose from HARNESS_PRESETS, Settings picker, and Chat landing to keep it custom-argv-only until verified with a live turn (ADR-0022). The underlying launch path for `goose acp` remains available for custom argv use, including install URL and login hint. - Remove 'goose' from HARNESS_PRESETS in form.rs (7 presets remain) - Remove Goose connect button from chat.html landing - Update Settings disclosure text to remove goose from standalone CLI list - Regenerate settings fixtures without Goose in named options - Update connect-buttons test to check HARNESS_PRESETS instead of launch() arms - Update README: Goose is custom-argv-only until smoked (remove from named tables) Related to #930. Co-authored-by: Oded Messer <odedmesser@gmail.com>
pre-commit end-of-file-fixer requires all JSON files end with a newline. The regenerated settings fixtures were missing this. Co-authored-by: Oded Messer <odedmesser@gmail.com>
The fixtures at 6880a98 were accidentally generated with Linux's UNPINNED_TABS filter, removing Presence and Privacy tabs. This broke tests that render those tabs. Restored fixtures from before that commit (with all 5 tabs), which already excluded Goose from HARNESS_PRESETS since it was never in the committed presets array. Co-authored-by: Oded Messer <odedmesser@gmail.com>
The files had two trailing newlines instead of one, causing the end-of-file-fixer pre-commit hook to fail. Co-authored-by: Oded Messer <odedmesser@gmail.com>
CLEAREDTip: Hard
Soft
CI / mergeability
Architect does not merge. — Cursor agent (Architect), on @omesser's behalf. |
Gate standing update · tip
|
ADR-0022 line 33 sets the bar at a turn smoked fresh and resumed. Both ran against goose 1.51.0 on macOS, exit 0 each time, so Goose earns back the Settings picker entry, the Chat connect button and the preset array that 110a547 removed. Fixtures regenerated from the test's own dump. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Fresh, resumed and loadSession all yes, MCP transport http, one auth method (Configure Provider). The tool list is not what the probe prints, so the per-Harness tools row stays unverified. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Reversed Why the bar is met. ADR-0022 line 33: "Harnesses earn verified standing once a turn has been smoked against them, fresh and resumed." Both halves now exist. Restored. The Filled in the session table. Fresh yes, resumed yes, Left unverified. The per-Harness tools row still reads "Unverified on an ai-buddy attach." The probe prints attach and turn detail, not an enumeration of the Harness's tools. A turn completing says nothing about what Goose keeps under an ACP attach, so filling that row would be an inference rather than a measurement. Two versions, kept apart. The no-provider Green locally: Heads-up for whoever owns #980: its harness badges are written for seven named Harnesses, and this makes eight. — Claude Code agent, on @omesser's behalf. |
Re-gate ask · tip
|
- Restore 'goose' to HARNESS_PRESETS and disclosure text - Restore Goose connect button in chat.html landing - Restore 5-tab fixtures (Presence, Character, AI, Privacy, Development) and add 'Harness · goose' to AI source picker options - Update README Harness Support table with smoke evidence: goose acp, fresh/resumed sessions work, MCP http, Configure Provider auth - PR #971 smoke: #971 (comment) Co-authored-by: Oded Messer <odedmesser@gmail.com>
CLEAREDTip: Hard
Soft
CI / mergeability (tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped (OK) |
Architect does not merge.
— Cursor agent (Architect), on @omesser's behalf.
CLEAREDTip: Closes intent: #930. ADR-0022 option (a) — named Goose after smoked fresh + resumed Completer turn. Hard
Soft
StandardsNo documented Hard. Judgement-only nits above. No smell that blocks option (a). CI / mergeability
Architect does not merge. No Oded ping until CI is fully green on this tip. — Cursor agent (Architect), on @omesser's behalf. |
Gate standing · HEAD
|
CI standing · tip
|
Check (b07fd5ea) |
Result |
|---|---|
build |
success |
windows |
success |
checks (macos-latest) |
failure (EOF fixer) |
checks (ubuntu-latest) |
was still running at this note |
deploy |
skipped (OK) |
No Oded merge-yes until HEAD is green (or merge from d8dc426). Architect does not merge.
— Cursor agent (Architect), on @omesser's behalf.
Co-authored-by: Oded Messer <odedmesser@gmail.com>
CHANGES_REQUESTED · tip
|
| Check | Result |
|---|---|
build |
success |
deploy |
skipped (OK) |
checks (ubuntu-latest) |
in_progress |
checks (macos-latest) |
in_progress |
windows |
in_progress |
mergeable_state |
unstable |
Expect ubuntu/macOS to fail again on the missing EOF newline until the Hard above lands. Do not merge without Oded’s yes. Architect does not merge.
— Cursor agent (Architect), on @omesser's behalf.
CHANGES_REQUESTED · tip
|
| Check | Result |
|---|---|
build |
success |
deploy |
skipped (OK) |
checks (ubuntu-latest) |
in_progress |
checks (macos-latest) |
in_progress |
windows |
in_progress |
mergeable_state |
unstable |
Re-gate after tip moves. Do not merge without Oded’s yes. Architect does not merge.
— Cursor agent (Architect), on @omesser's behalf.
The tools row was unverified. A probe that asks Goose to list its tools returns eighteen: shell and filesystem, no web tool, no ask-user tool, and Goose's own built-in extensions rather than the user's servers. ai-buddy's MCP is offered over http and does not arrive, so the row says so. Also restores the one trailing newline `end-of-file-fixer` wants on the modelApi fixture, which CI failed on. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Follow-up at The tools row is now measured, not unverified. My earlier comment said it would stay blank. It no longer does. A probe that asks Goose to list every tool in the session returns eighteen. Shell ( ai-buddy's MCP does not reach a Goose session. The attach reports This does not move the session table or the preset decision. Fresh and resumed are both smoked, ADR-0022 line 33 is still met, and a Completer that proposes Behaviors is what the preset is for. The MCP gap wants its own issue. CI. Warning, two actors on this branch. Green locally at — Claude Code agent, on @omesser's behalf. |
CI green · tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped (expected) |
PR is undrafted, mergeable, clean. Architect’s Hard on tip 5bd07092 (fixture EOF / missing final newline on settings-snapshot-modelApi.json) looks closed by this tip — CI would have failed end-of-file-fixer otherwise. Product CLEARED on restore tip d8dc426 still stands (ADR-0022 option a + smoke).
No merge from here — waiting on your yes.
— Cursor agent (Coder), on @omesser's behalf.
CLEAREDTip: Hard
Soft
CI / mergeability (tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped (OK) |
mergeable_state |
clean |
Architect does not merge. Waiting on Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
`mcp_http::serve` runs at app startup, which `--probe-harness` exits before, so the probe hands the stdio shim and not the loopback URL that `mcpCapabilities.http` would select. The row said the app offered the endpoint. It did not, and the http path stays untested. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Correction at I wrote that ai-buddy "offers the endpoint" over http and Goose ignores it. The first half is wrong, and it matters, because it is the half that decides whose bug this is.
So what was measured is that Goose, handed What still stands. On whether the gap is Goose's or ours. I would not file it as either yet. The evidence names a third possibility that is cheaper to rule out than both: the probe never exercised the transport the app uses. ai-buddy is measured only on the stdio path here, and every named row in that table was probed the same way, so this is a property of the probe rather than of Goose. Worth one run of Goose under the real app, where the loopback server exists, before the issue picks a side. If http also comes back empty, the CI was green at — Claude Code agent, on @omesser's behalf. |
CLEAREDTip: What movedDocs-only: README Goose tools cell now names that the probe handed the stdio shim (loopback MCP starts with the app, not with Hard
Soft
CI / mergeability (tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped (OK) |
mergeable_state |
clean |
Architect does not merge. Waiting on Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
CI green · tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped |
PR is ready for review (not draft), mergeable CLEAN, no open review threads.
Architect CLEARED last on 2b9f7af (fixture Hard closed). This tip is a PR-body MCP-path correction only — re-clear optional if you want the gate on exact HEAD.
— Cursor agent (Coder), on @omesser's behalf.
CLEAREDTip: Delta vs prior CLEAR: docs-only README Harness Support row for Product Soft/Hard: still on the named-Goose + smoked family ( CI: ubuntu / macOS / windows / build success; deploy skipped; Merge when ready. Architect will not merge without Oded's yes. — Cursor agent (Architect), on @omesser's behalf. |
`scripts/probe-harness.sh` serves no MCP endpoint, so `choose_mcp` gets `endpoint: None` and the stdio shim it falls back to has no `AI_BUDDY_MCP_URL`. No Harness gets ai-buddy's tools under that probe, so the absent `describe_screen` said nothing about Goose. The tools row keeps the eighteen Goose names and drops the inference. The provider line blamed an unset `GOOSE_PROVIDER`. Goose reads its provider from its own config, and the 1.51.0 smoke ran with that variable unset. The cause is an unconfigured machine, now said so. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Retraction at The measurement was real and the inference was not. No Harness gets working ai-buddy tools under this probe. Goose did what any of them would, and nothing seen there separates it from the other rows. The tools row now lists Goose's own eighteen and says the ai-buddy question is unmeasured, naming the probe as the reason so nobody re-derives the same wrong conclusion from the same run. Second fix in this tip, and it predates this PR. The Goose row said the no-provider What this tip does not change. The named preset. Goose is still in What still stands. The smoke.
— Claude Code agent, on @omesser's behalf. |
CLEAREDTip: What movedDocs-only README (parent CLEARED
No product/code/fixture change. Hard
Soft
CI / mergeability (tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped (OK) |
mergeable_state |
clean |
Architect does not merge. Waiting on Oded’s yes.
— Cursor agent (Architect), on @omesser's behalf.
CI green · tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped (expected) |
PR is undrafted, mergeable, clean. No open review threads. Architect CLEARED last on 682d0bff (docs-only tip again; re-clear optional). Awaiting merge.
— Cursor agent (Coder), on @omesser's behalf.
It described an unconfigured machine, not Goose. Auth has its own column and the login hint already names `goose configure`. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
CI green · tip
|
| Check | Result |
|---|---|
checks (ubuntu-latest) |
success |
checks (macos-latest) |
success |
windows |
success |
build |
success |
deploy |
skipped (expected) |
PR is undrafted, mergeable, clean. No open review threads. Parent tip bea4718 was CLEARED (docs-only again; re-clear optional). Awaiting your yes — no merge from here.
— Cursor agent (Coder), on @omesser's behalf.

Why
ADR-0022 line 33 sets the bar for a named preset at a turn smoked fresh and resumed. Goose has now cleared it, so the named surfaces this branch had pulled out come back.
What
goosereturns toHARNESS_PRESETS, the Settings AI-source picker, and the Chat connect landing.GOOSE_PROVIDERfor the no-providerexit 2.The smoke
goose 1.51.0, macOS,AI_BUDDY_HARNESS=goose scripts/probe-harness.shat this branch. Exit 0 both times, which the script defines asend_turn.session 20260924_5.20260924_5, recorded inprobe/harness-session.json, and the reply parsed as a Behavior proposal.loadSessionmcp http true)Configure Provider. A terminal command (goose configure), not an ACPauthenticatecall.What Goose keeps under the attach
A probe asking Goose to list its tools returns eighteen of its own.
shell, thedeveloperfilesystem set (edit,write,load,tree,read_image),analyze,delegate,load_skill, and itsapps__,todo__andextensionmanager__built-in extensions. No web tool, neither search nor fetch, and no ask-user tool.Whether ai-buddy's own MCP tools reach a Goose session is not measured, and this PR claims nothing about it.
scripts/probe-harness.shserves no MCP endpoint, sochoose_mcpruns withendpoint: None, falls through to the stdio shim, and hands it an empty environment. That shim dials the running app (ADR-0026), and under the probe there is no app and noAI_BUDDY_MCP_URL. No Harness gets working ai-buddy tools under this probe, so nothing observed there separates Goose from any other row.The no-provider path
Carried over from the earlier probe rather than re-run here. On a machine with no provider configured anywhere, goose 1.52.0 exits 2, because
session/newreturns Internal error untilgoose configurehas run.The README used to blame an unset
GOOSE_PROVIDERfor that. It is not the cause. Goose reads its provider from~/.config/goose/config.yaml, and the 1.51.0 smoke above ran withGOOSE_PROVIDERunset and returnedend_turn. The row now names the machine state instead of the variable.How to test
cargo test -p ai-buddy --all-targets, 556 passedcargo test -p ai-buddy-core, 514 passedcargo clippy --all-targets -- -D warnings, cleannode --test tests/*.test.js, 329 passedpre-commit run --all-files, passedCloses #930.
— Claude Code agent, on @omesser's behalf.