Skip to content

timesheets: move the two Clockify e2e tests here from atomic-server #44

Closed

Description

@michielbdejong

Split out of #43 (§3b). See also integrations/HANDOFF-e2e-split.md and integrations/PARALLEL_LANES.md ("Still open").

Problem

timesheets has no e2e tier. Its two Clockify Playwright tests still live upstream in ontola/atomic-server's browser/e2e/tests/plugins.spec.ts:

  • Clockify discovers named workspaces and surfaces preview transport errors
  • Clockify applies linked entries through the real sandbox and skips repeats

They run ungated in this repo's E2E: generic plugin system job on every PR that touches anything under integrations/, rather than behind integrations/timesheets/**.

Change

In one change, alongside the next .atomic-server-ref bump (otherwise they run twice, or not at all):

  1. Delete both tests upstream (a PR against atomic-server).
  2. Add them here as integrations/timesheets/e2e/clockify.spec.ts.
  3. In integrations/lanes.json, add "e2e" to the timesheets lane's tiers plus an e2e spec list, and drop its "No e2e tier yet" note.

The lane already names clockify as its platform, and the mock proxy now serves just that when MOCK_PROXY_PLATFORMS=clockify (fixture: integrations/timesheets/fixtures/clockify/scenario.mjs).

Per PARALLEL_LANES.md §5, bump .atomic-server-ref in its own PR, not from a plugin worktree. Related: #20 (moving Clockify onto an externally hosted app).

🤖 Generated with Claude Code

Update: upstream deletion already happened on feat/plugin-debug

atomic-server commit 4bab16ee6 on feat/plugin-debug already deleted both tests from plugins.spec.ts, so only this repo's half is left. Two things to know before porting:

  • Both tests click [data-integration=clockify]. That card came from IntegrationDiscovery, which the same commit removed, so the tests need a new card or entry point to target.
  • createTableFromDialog still exists in browser/e2e/tests/test-utils.ts at 4bab16ee6^.

The source is recoverable with git show 4bab16ee6^:browser/e2e/tests/plugins.spec.ts | sed -n '1,29p;84,471p' (in atomic-server). Of the imports, the two tests use only before, createTableFromDialog, enableIntegrationDiscovery and dataBrowser.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions