Repository navigation
money e2e: wait for the app save to sync before leaving the page (fixes the 'New app' flake) - #180
Closed
michielbdejong wants to merge 2 commits into
Closed
michielbdejong wants to merge 2 commits into
michielbdejong wants to merge 2 commits into
Conversation
The "Money app" test flaked in CI (runs 36140727009, 36152023575,
36152145164; five failed attempts, all identical) on
`getByRole('menuitem', { name: 'New app' }).click()`. The traces show
the "Add view" menu open with only Table, Kanban, Calendar, Timer,
Dashboard and Issues. `installApp` saved the App (name, `renders`,
source) and the spec navigated 1.2-1.4 s later, before that save had
synced; the next page's `useDriveApps` reads the drive's apps once on
mount, and the App's commits only arrived by ws-sync-push 0.4-0.9 s
after the menu had opened, so it never listed the app.
Wait with test-utils' `waitForSynced` (outbox empty, ClientDb flushed)
after `installApp`, and after the row edit in the first test, which
navigates away right after `save()` the same way.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No conflicts. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Closing as superseded. This PR added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the intermittent
locator.click: Timeout 10000msonmenuitem 'New app'inintegrations/money/e2e/money.spec.ts. It was seen in runs 36140727009, 36152023575 and 36152145164, plus their retries.Root cause, from the traces:
installAppsaves the app's name,rendersclass and source, then navigates to the table about 1.2–1.4 s later, before that save has synced.useDriveApps.ts) is read once, when the table page mounts, and isn't re-read when the app arrives through sync 0.4–0.9 s later. So "New app" never shows up. The menu was open, with no overlay, online, and the import done.Fix:
waitForSyncedfrom atomic-server'stest-utilsat the end ofinstallApp, the documented remedy for save-then-navigate;save().No timeouts or retries were changed.
Checks:
tscare clean.Host note: the "Add view" menu doesn't pick up an app changed after the page loaded, for example in another tab, until a reload.
🤖 Generated with Claude Code