Repository navigation
usertest: sound check before Start, and separate error messages - #229
Merged
Merged
Conversation
The page reported every start failure as "Is the invite link complete?", also when the microphone permission was the problem. Now a sound check (microphone level meter, optional speech-recognition check, speaker test in the moderator's voice, or type instead) gates Start, api() errors carry the HTTP status, and only the moderator's 403 is reported as a code problem. The moderator gets GET /check so the page tests the code on load. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
usertest/e2e/run.mjs runs the moderator with a dummy code against a stand-in Claude API and drives Chromium's new headless mode (fake media, or the microphone denied): 13 checks incl. Dutch. oxfmt on the page. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 37751178 | Triggered | Generic High Entropy Secret | 94a0aab | usertest/e2e/run.mjs | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a sound check before a user-testing session starts, and gives each start failure its own message. Until now, any failure showed "Could not start the session (…). Is the invite link complete?". Everything is in
usertest/; nothing shared is touched.Sound check (a new card; Start moves to its own card):
Separate errors, in en and nl (61 keys, identical sets):
api()now throws anApiErrorcarrying the status. The moderator getsGET /check, so a wrong code shows on page load; an older moderator's 404 is ignored.Tests (headless only):
node usertest/e2e/run.mjspasses 13/13 against the realserver.mjswith a stubbed Claude API. It covers the happy path, typed answers, a denied mic, no mic, no speech recognition, a cancelled screen share, wrong and missing code, a bad plan, the moderator down and retry, an aborted request, and Dutch.Not verifiable headlessly: real speech recognition, whether the speakers are audible and which voice real Chrome/Edge picks, real permission prompts, and whether the level threshold is right in a quiet room.
Note on Polle's error: the old page already fell back to typing on microphone failures. So "Could not start the session (…)" probably came from a moderator error or another screen or recorder failure, which the "(…)" names. Now each has its own message.
Deploy: after merging, run
deploy.shand restart the moderator (for/check). Restarting ends running sessions. Droplet deploys need Michiel's OK (board rule 10).🤖 Generated with Claude Code