Skip to content

notion 0.4.0: option columns are the host's select columns, so the table shows names - #285

Merged
michielbdejong merged 8 commits into
mainfrom
claude/notion-option-names
Oct 2, 2026
Merged

michielbdejong merged 8 commits into
mainfrom
claude/notion-option-names

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Stacked on #281 (Notion 0.3.0, the status view): merge that first.

Part of #8 and #177. Since 0.3.0 people see Notion rows only in the host's table, where select, status and multi-select cells showed Notion option ids.

The host already has a select column: a SelectProperty, a resourceArray of Tags with allowsOnly. It renders coloured chips, and its editor offers only the allowed Tags. Read from chunks/TablePage/ and PropertyForm/ at a12b74a.

What changed:

  • Option columns: the app now gives each option column that shape, with one Tag per Notion option under the column's Property (app/options.ts: name, slug shortname, colour, notion-option-id).
  • Rename stability: a cell holds the Tag, so a rename in Notion renames the Tag and leaves rows untouched.
  • Sync unchanged: the lens, baseline, three-way merge, review and the PATCH-by-option-id send are as before. options.ts translates ids ↔ Tags at the host boundary.
  • Upgrade: 0.3.0 installs are upgraded in place on the first sync, and an unsent edit that holds a raw id survives (Design: plugins sync into shared row classes, and plugin views work on any table of that class ("option 4") #177 Q10).
  • max: the host's SelectCell doesn't enforce max, so a status cell given two Tags is held back in the review.

The e2e screenshot shows Status chips "Shipped", "In progress" and "Not started" in the host's table.

Release: bundle 113,536 bytes (limit 125,000). apps/notion/0.4.0 is written by apps.mjs. The catalog copy is updated and stays enabled: false. Usertest is usertest-6.

Checks: notion unit (180), typecheck, live, and e2e (3 runs). Also: tooling tests 253/253, apps and ontology checks, certify, e2e tsc, oxlint (0 errors) and oxfmt. Not verified against live Notion.

🤖 Generated with Claude Code

michielbdejong and others added 7 commits October 2, 2026 16:44
…s.ts)

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…tests

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ble shows names

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…in the same commit

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
@gitguardian

gitguardian Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@michielbdejong
michielbdejong changed the base branch from claude/notion-q9-status-view to main October 2, 2026 17:12
# Conflicts:
#	integrations/READINESS.md
#	usertest/catalog.mjs
@michielbdejong
michielbdejong merged commit fbb9c78 into main Oct 2, 2026
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant