Repository navigation
notion 0.4.0: option columns are the host's select columns, so the table shows names - #285
Merged
Merged
Conversation
…s.ts) Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…tests Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…ble shows names Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…in the same commit Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
michielbdejong
changed the base branch from
claude/notion-q9-status-view
to
main
October 2, 2026 17:12
# Conflicts: # integrations/READINESS.md # usertest/catalog.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #281 (Notion 0.3.0, the status view): merge that first.
Part of #8 and #177. Since 0.3.0 people see Notion rows only in the host's table, where select, status and multi-select cells showed Notion option ids.
The host already has a select column: a SelectProperty, a
resourceArrayof Tags withallowsOnly. It renders coloured chips, and its editor offers only the allowed Tags. Read fromchunks/TablePage/andPropertyForm/at a12b74a.What changed:
app/options.ts: name, slug shortname, colour,notion-option-id).options.tstranslates ids ↔ Tags at the host boundary.max: the host's SelectCell doesn't enforcemax, so a status cell given two Tags is held back in the review.The e2e screenshot shows Status chips "Shipped", "In progress" and "Not started" in the host's table.
Release: bundle 113,536 bytes (limit 125,000).
apps/notion/0.4.0is written byapps.mjs. The catalog copy is updated and staysenabled: false. Usertest isusertest-6.Checks: notion unit (180), typecheck, live, and e2e (3 runs). Also: tooling tests 253/253, apps and ontology checks, certify, e2e tsc, oxlint (0 errors) and oxfmt. Not verified against live Notion.
🤖 Generated with Claude Code