Repository navigation
overlays: the Todoist completeness test reads the whole composed document - #625
Merged
Merged
Conversation
…617 review) The read tests hard-coded tombstone=None and no resource_gone. They now read the task's x-read-tombstone (on the resource, else on its read operation) and completeness.resource_read_value(..., "gone") from the composed document, through one classifier. A new test shows the check would fail if either appeared: a read tombstone on the resource or on its read, or a gone: deleted, each yields a deleted outcome. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #617's review.
test_todoist_completeness.pynow classifies through one helper that reads everything from the composed document:x-read-tombstone(on the resource, else onGET /tasks/{task_id}, per Deletion Feeds §4.4);resource_not_found;resource_read_value(..., "task", "gone").Nothing is hard-coded to
Noneany more. A new test injects a read tombstone on the resource, then on the read operation, then agone: deleted, and checks that each one would make the "never deleted" check fail. The published overlay is unchanged.🤖 Generated with Claude Code