Skip to content

overlays: the Todoist completeness test reads the whole composed document - #625

Merged
michielbdejong merged 2 commits into
mainfrom
claude/todoist-completeness-test-followup
Oct 15, 2026
Merged

michielbdejong merged 2 commits into
mainfrom
claude/todoist-completeness-test-followup

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Follow-up to #617's review. test_todoist_completeness.py now classifies through one helper that reads everything from the composed document:

  • the task's x-read-tombstone (on the resource, else on GET /tasks/{task_id}, per Deletion Feeds §4.4);
  • resource_not_found;
  • resource_read_value(..., "task", "gone").

Nothing is hard-coded to None any more. A new test injects a read tombstone on the resource, then on the read operation, then a gone: deleted, and checks that each one would make the "never deleted" check fail. The published overlay is unchanged.

🤖 Generated with Claude Code

michielbdejong and others added 2 commits October 15, 2026 16:59
…617 review)

The read tests hard-coded tombstone=None and no resource_gone. They now
read the task's x-read-tombstone (on the resource, else on its read
operation) and completeness.resource_read_value(..., "gone") from the
composed document, through one classifier. A new test shows the check
would fail if either appeared: a read tombstone on the resource or on its
read, or a gone: deleted, each yields a deleted outcome.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong
michielbdejong merged commit 7bd2d77 into main Oct 15, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant