Skip to content

money lane: say why it has no tiers and where a moneybird fixture goes - #64

Merged
michielbdejong merged 1 commit into
mainfrom
claude/issue-45-money-lane-moneybird
Sep 23, 2026
Merged

michielbdejong merged 1 commit into
mainfrom
claude/issue-45-money-lane-moneybird

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Closes #45.

Docs/config only: the money lane's note in integrations/lanes.json and the money bullet under "Still open" in integrations/PARALLEL_LANES.md. No behaviour change.

Summary

  • Tiers stay [], on purpose. shared-checks runs certify.mjs --layer js on every integrations/** change. That already runs exactly the tsc -p integrations/money/tsconfig.json and vitest run --config integrations/money/vitest.config.ts that a typecheck/unit tier would, plus bundle reproducibility. A tier would only repeat that. Add one once money has a server-dependent test, as the issue says.
  • moneybird stays in the lane, but nothing in this repo reads Moneybird data. integrations/money/ is an MT940/camt.053 uploader, and the moneybird catalog entry (requires-api-plugins) has no package here; atomic-server's generic API-plugin path reads it. So a recorded fixture has no in-repo adapter to validate it (§4's "enforced, not asserted" rule), and no lane tier starts a mock proxy to serve it.
  • Fixture location. A future Moneybird fixture and its recorder go in integrations/money/fixtures/moneybird/ (plugin-specific files stay in the plugin folder). The shared registry integrations/localthought/fixtures/index.mjs from CI gate, mock-proxy fixture registry and lane topology fixes (#43) #48 then imports ../../money/fixtures/moneybird/scenario.mjs once api/ is recorded.
  • No fixture is hand-written. Recording one needs a Moneybird account, API token and administration id. A recorder should follow the convention from issue-tracker: record a todoist mock-proxy fixture #46 (todoist): MONEYBIRD_TOKEN, MONEYBIRD_ADMINISTRATION_ID, api/<METHOD>__<path>.json, and an exported REDACTIONS list.

Verified

Not verified / follow-ups

🤖 Generated with Claude Code

Issue #45. No behaviour change; lanes.json note and PARALLEL_LANES.md
"Still open" only.

- Tiers stay []: shared-checks runs certify.mjs --layer js on every
  integrations/** change, and that already runs exactly the tsc and vitest
  a typecheck/unit tier would, plus bundle reproducibility. A tier waits
  for a server-dependent money test, as the issue says.
- moneybird is named by the lane but consumed by nothing in this repo:
  integrations/money/ is an MT940/camt.053 uploader, and the moneybird
  catalog entry is package-less (read by atomic-server's generic
  API-plugin path). A recorded fixture would have no in-repo adapter to
  validate it against and no tier that starts a mock proxy to serve it;
  recording also needs a Moneybird account. Not hand-written, per §4.
- A future Moneybird fixture and recorder go in
  integrations/money/fixtures/moneybird/, not
  integrations/localthought/fixtures/: plugin-specific files stay in the
  plugin's folder; the shared registry (PR #48) imports it as
  ../../money/fixtures/moneybird/scenario.mjs.

The PARALLEL_LANES.md hunk keeps the bullet's last line unchanged so it
merges cleanly with PR #48, which rewrites the next bullet.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong
michielbdejong force-pushed the claude/issue-45-money-lane-moneybird branch from 26978da to ccc28b0 Compare September 23, 2026 09:17
@michielbdejong
michielbdejong merged commit 105a143 into main Sep 23, 2026
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

money: lane has no tiers, and no moneybird mock fixture

1 participant