Repository navigation
money lane: say why it has no tiers and where a moneybird fixture goes - #64
Merged
Merged
Conversation
Issue #45. No behaviour change; lanes.json note and PARALLEL_LANES.md "Still open" only. - Tiers stay []: shared-checks runs certify.mjs --layer js on every integrations/** change, and that already runs exactly the tsc and vitest a typecheck/unit tier would, plus bundle reproducibility. A tier waits for a server-dependent money test, as the issue says. - moneybird is named by the lane but consumed by nothing in this repo: integrations/money/ is an MT940/camt.053 uploader, and the moneybird catalog entry is package-less (read by atomic-server's generic API-plugin path). A recorded fixture would have no in-repo adapter to validate it against and no tier that starts a mock proxy to serve it; recording also needs a Moneybird account. Not hand-written, per §4. - A future Moneybird fixture and recorder go in integrations/money/fixtures/moneybird/, not integrations/localthought/fixtures/: plugin-specific files stay in the plugin's folder; the shared registry (PR #48) imports it as ../../money/fixtures/moneybird/scenario.mjs. The PARALLEL_LANES.md hunk keeps the bullet's last line unchanged so it merges cleanly with PR #48, which rewrites the next bullet. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
michielbdejong
force-pushed
the
claude/issue-45-money-lane-moneybird
branch
from
September 23, 2026 09:17
26978da to
ccc28b0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45.
Docs/config only: the
moneylane'snoteinintegrations/lanes.jsonand themoneybullet under "Still open" inintegrations/PARALLEL_LANES.md. No behaviour change.Summary
[], on purpose.shared-checksrunscertify.mjs --layer json everyintegrations/**change. That already runs exactly thetsc -p integrations/money/tsconfig.jsonandvitest run --config integrations/money/vitest.config.tsthat atypecheck/unittier would, plus bundle reproducibility. A tier would only repeat that. Add one oncemoneyhas a server-dependent test, as the issue says.moneybirdstays in the lane, but nothing in this repo reads Moneybird data.integrations/money/is an MT940/camt.053 uploader, and themoneybirdcatalog entry (requires-api-plugins) has no package here; atomic-server's generic API-plugin path reads it. So a recorded fixture has no in-repo adapter to validate it (§4's "enforced, not asserted" rule), and no lane tier starts a mock proxy to serve it.integrations/money/fixtures/moneybird/(plugin-specific files stay in the plugin folder). The shared registryintegrations/localthought/fixtures/index.mjsfrom CI gate, mock-proxy fixture registry and lane topology fixes (#43) #48 then imports../../money/fixtures/moneybird/scenario.mjsonceapi/is recorded.MONEYBIRD_TOKEN,MONEYBIRD_ADMINISTRATION_ID,api/<METHOD>__<path>.json, and an exportedREDACTIONSlist.Verified
node --test integrations/tooling/lanes.test.mjs integrations/tooling/workflow.test.mjs: 17/17 pass.oxfmt -c browser/.oxfmtrc.json --check integrations: clean. Run against atomic-server at.atomic-server-ref, set up with integrations/ can't be built or tested locally — package the browser/ symlink setup CI already uses #34'slink-atomic-server.mjs.node integrations/tooling/certify.mjs --layer jspasses for money, notion and pets, andrun-lane.mjs money --tier unitpasses. Both ran on an earlier revision of this commit that differs only in wording.git merge-treeagainst CI gate, mock-proxy fixture registry and lane topology fixes (#43) #48's branch is clean. ThePARALLEL_LANES.mdhunk leaves the lines CI gate, mock-proxy fixture registry and lane topology fixes (#43) #48 edits untouched.Not verified / follow-ups
🤖 Generated with Claude Code