Skip to content

Bump atomic-server to b875d4a31 and lift the plugin-system e2e quarantine - #75

Merged
michielbdejong merged 1 commit into
mainfrom
claude/issue-71-lift-plugin-system-quarantine
Sep 23, 2026
Merged

michielbdejong merged 1 commit into
mainfrom
claude/issue-71-lift-plugin-system-quarantine

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

Bumps .atomic-server-ref from 50cf5151c to b875d4a31 (current head of atomic-server feat/plugin-debug). Removes the job-level continue-on-error: true and its comment from e2e-plugin-system, so E2E: generic plugin system fails CI again.

Closes #71

Why the job was red at 50cf5151c

Main's run 35842095258: 3 failed, 4 passed, 0 flaky. All three failures are upstream drift, and none depend on this repo's catalog:

Spec Error at 50cf5151c Cause Fixed upstream by
plugin.spec.ts:26 install a plugin v1.0.0 not found in the Install dialog (the dialog showed 1.0.0) Strings from components added on the branch were missing from the wuchale .po catalogs, so production builds rendered them blank 49d42cfc2 (catalogs settled) + b875d4a31 (.first() on the doubled plugin name)
plugins.spec.ts:17 a published release is discoverable… [data-release] card Unverified not found. Discover showed "No plugins to show here." The "Show experimental plugins" toggle was dropped on the navigation straight after it 1a3a33c69 (pending toggles kept in localStorage)
plugins.spec.ts:123 a run whose target does not exist… Apply button not found (expected disabled) A blocked plan now hides Apply b875d4a31 (spec asserts toHaveCount(0))

Verified

Built locally at b875d4a31 with CI's recipe: wasm-pack --no-opt, then SKIP_WASM_BUILD=1 VITE_E2E=true cargo build --profile e2e -p atomic-server --no-default-features --features wasm-plugins. Linked it with link-atomic-server.mjs and started the stack with serve.mjs. Then ran CI's exact command, with PLUGIN_CATALOG_URL pointing at this repo's catalog:

  • 1 run with the config's default retries: 7/7 passed.
  • 3 more runs, each on a fresh .lane-store/shared and with --retries=0: 7/7 passed each time.

Not verified / caveats

  • The other lanes weren't run locally at the new pin. Upstream's diff 50cf5151c..b875d4a31 is translation catalogs, the integration-visibility hook, wuchale.config.js and three e2e specs, so no server or lib changes. This PR's own CI is the check.
  • This touches .atomic-server-ref, a shared path, so every lane runs and build-server rebuilds (PARALLEL_LANES.md: bump the pin in its own PR). This PR is that pin bump. The only other change is the quarantine lift, which depends on it.
  • Re-running plugin.spec.ts "install a plugin" against a store that an earlier run already used fails. The upload creates the same Release subject, which stays private to the first run's agent, so the Installation commit gets 401. CI always starts from a fresh store, so CI doesn't hit this. It's an upstream test-isolation issue worth a follow-up there.

🤖 Generated with Claude Code

…ntine

At the old pin 50cf5151c the "E2E: generic plugin system" job had 3 of 7
tests failing (run 35842095258), all upstream drift in atomic-server
feat/plugin-debug, none caused by this repo's catalog:

- plugin.spec.ts:26 "install a plugin": the review dialog's "v1.0.0"
  rendered as "1.0.0", because strings from components added on the
  branch were missing from the wuchale catalogs (fixed by 49d42cfc2).
- plugins.spec.ts:17 "a published release is discoverable": the
  "Show experimental plugins" toggle was lost on the navigation straight
  after it, so Discover showed no plugins (fixed by 1a3a33c69).
- plugins.spec.ts:123 "a run whose target does not exist is blocked":
  the spec expected a disabled Apply button; the UI now hides it
  (spec updated in b875d4a31).

b875d4a31 is the current head of feat/plugin-debug. At it, both specs
pass 7/7 locally against this repo's catalog (PLUGIN_CATALOG_URL set as in
CI), on 3 consecutive fresh-store runs with --retries=0. So the job no
longer needs job-level continue-on-error.

Refs #71

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@michielbdejong
michielbdejong merged commit 21a2c14 into main Sep 23, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lift the quarantine on the E2E: generic plugin system job

1 participant