Repository navigation
Bump atomic-server to b875d4a31 and lift the plugin-system e2e quarantine - #75
Merged
michielbdejong merged 1 commit intoSep 23, 2026
Merged
Conversation
…ntine At the old pin 50cf5151c the "E2E: generic plugin system" job had 3 of 7 tests failing (run 35842095258), all upstream drift in atomic-server feat/plugin-debug, none caused by this repo's catalog: - plugin.spec.ts:26 "install a plugin": the review dialog's "v1.0.0" rendered as "1.0.0", because strings from components added on the branch were missing from the wuchale catalogs (fixed by 49d42cfc2). - plugins.spec.ts:17 "a published release is discoverable": the "Show experimental plugins" toggle was lost on the navigation straight after it, so Discover showed no plugins (fixed by 1a3a33c69). - plugins.spec.ts:123 "a run whose target does not exist is blocked": the spec expected a disabled Apply button; the UI now hides it (spec updated in b875d4a31). b875d4a31 is the current head of feat/plugin-debug. At it, both specs pass 7/7 locally against this repo's catalog (PLUGIN_CATALOG_URL set as in CI), on 3 consecutive fresh-store runs with --retries=0. So the job no longer needs job-level continue-on-error. Refs #71 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
.atomic-server-reffrom50cf5151ctob875d4a31(current head of atomic-serverfeat/plugin-debug). Removes the job-levelcontinue-on-error: trueand its comment frome2e-plugin-system, soE2E: generic plugin systemfailsCIagain.Closes #71
Why the job was red at
50cf5151cMain's run 35842095258: 3 failed, 4 passed, 0 flaky. All three failures are upstream drift, and none depend on this repo's catalog:
50cf5151cplugin.spec.ts:26install a pluginv1.0.0not found in the Install dialog (the dialog showed1.0.0).pocatalogs, so production builds rendered them blank49d42cfc2(catalogs settled) +b875d4a31(.first()on the doubled plugin name)plugins.spec.ts:17a published release is discoverable…[data-release]cardUnverifiednot found. Discover showed "No plugins to show here."1a3a33c69(pending toggles kept in localStorage)plugins.spec.ts:123a run whose target does not exist…Applybutton not found (expected disabled)b875d4a31(spec assertstoHaveCount(0))Verified
Built locally at
b875d4a31with CI's recipe: wasm-pack--no-opt, thenSKIP_WASM_BUILD=1 VITE_E2E=true cargo build --profile e2e -p atomic-server --no-default-features --features wasm-plugins. Linked it withlink-atomic-server.mjsand started the stack withserve.mjs. Then ran CI's exact command, withPLUGIN_CATALOG_URLpointing at this repo's catalog:.lane-store/sharedand with--retries=0: 7/7 passed each time.Not verified / caveats
50cf5151c..b875d4a31is translation catalogs, the integration-visibility hook,wuchale.config.jsand three e2e specs, so no server or lib changes. This PR's own CI is the check..atomic-server-ref, asharedpath, so every lane runs andbuild-serverrebuilds (PARALLEL_LANES.md: bump the pin in its own PR). This PR is that pin bump. The only other change is the quarantine lift, which depends on it.plugin.spec.ts"install a plugin" against a store that an earlier run already used fails. The upload creates the same Release subject, which stays private to the first run's agent, so the Installation commit gets 401. CI always starts from a fresh store, so CI doesn't hit this. It's an upstream test-isolation issue worth a follow-up there.🤖 Generated with Claude Code