You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Plugins: binary mode for accepts (pass uploaded files as base64, not decoded text) #1727
When a plugin declares accepts, the host passes the uploaded file as decoded text: UTF-8, with a windows-1252 fallback. That's right for MT940 and camt.053, but binary formats need the raw bytes. ontola/atomic-plugins#141, the Willow drop importer, currently has to reverse the decoding inside the sandbox. It works and is tested, but it's a workaround, and it depends on the fallback decoder staying exactly reversible.
text stays the default, so existing plugins (MT940, camt) don't change.
With base64, the host passes the file's exact bytes, base64-encoded, and does no charset detection.
Validate it in both manifest implementations (server/src/plugins/manifest.rs and browser/lib/src/plugin-manifest.ts), with shared fixtures in testdata/plugin-manifest/. Leaving the field out must keep existing release ids byte-identical.
Upload size limits should apply to the raw byte size, not the base64 length.
Activity