Repository navigation
Fix cross-device AI chat discovery and folder creation - #1616
Merged
Merged
Conversation
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 26549932 | Triggered | Generic High Entropy Secret | ad5cd37 | browser/data-browser/src/helpers/standardLocations.test.ts | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI chats could disappear from the sidebar after signing in on another device: each device could create a different AI Chats folder, while the sidebar followed only the winning drive pointer. The chats remained in the drive but were excluded from the list.
The sidebar now queries AI Chat resources across the private drive, including legacy folders and root-level chats. New chats remain organized in a folder whose genesis certificate derives a stable ID from the account identity, drive and versioned purpose. Concurrent creation converges on the same folder; existing folder metadata is preserved. Existing chats and duplicate folders are not moved or deleted.
Stable folder subjects are derived while the raw key is available at sign-in and persisted alongside non-extractable keys, avoiding nondeterministic WebCrypto signatures. Older sessions can reuse an existing folder; an older session without either a folder or a cached identity must sign in again rather than mint a random fallback. Known deleted folders are not silently resurrected, and transport failures do not trigger initialization.
Validation: 28 focused unit tests passed, including certificate verification, separate-device derivation, persisted identities, concurrent creation, legacy sessions and failure handling. All 3 Chromium E2Es passed with zero retries, covering duplicate-folder discovery and reload, drive/class isolation, two independent signed-in contexts creating chats in the same folder, and normal sidebar creation/reopening. Library, app and E2E typechecks passed; full workspace lint/formatting passed in the pre-commit hook. Physical Safari and offline two-device reconnect were not tested.