Skip to content

Fix cross-device AI chat discovery and folder creation - #1616

Merged
joepio merged 1 commit into
developfrom
codex/deterministic-ai-chats
Sep 22, 2026
Merged

joepio merged 1 commit into
developfrom
codex/deterministic-ai-chats

Conversation

@joepio

@joepio joepio commented Sep 22, 2026

Copy link
Copy Markdown
Member

AI chats could disappear from the sidebar after signing in on another device: each device could create a different AI Chats folder, while the sidebar followed only the winning drive pointer. The chats remained in the drive but were excluded from the list.

The sidebar now queries AI Chat resources across the private drive, including legacy folders and root-level chats. New chats remain organized in a folder whose genesis certificate derives a stable ID from the account identity, drive and versioned purpose. Concurrent creation converges on the same folder; existing folder metadata is preserved. Existing chats and duplicate folders are not moved or deleted.

Stable folder subjects are derived while the raw key is available at sign-in and persisted alongside non-extractable keys, avoiding nondeterministic WebCrypto signatures. Older sessions can reuse an existing folder; an older session without either a folder or a cached identity must sign in again rather than mint a random fallback. Known deleted folders are not silently resurrected, and transport failures do not trigger initialization.

Validation: 28 focused unit tests passed, including certificate verification, separate-device derivation, persisted identities, concurrent creation, legacy sessions and failure handling. All 3 Chromium E2Es passed with zero retries, covering duplicate-folder discovery and reload, drive/class isolation, two independent signed-in contexts creating chats in the same folder, and normal sidebar creation/reopening. Library, app and E2E typechecks passed; full workspace lint/formatting passed in the pre-commit hook. Physical Safari and offline two-device reconnect were not tested.

@gitguardian

gitguardian Bot commented Sep 22, 2026

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
26549932 Triggered Generic High Entropy Secret ad5cd37 browser/data-browser/src/helpers/standardLocations.test.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@joepio
joepio merged commit ae276d3 into develop Sep 22, 2026
8 of 9 checks passed
@joepio
joepio deleted the codex/deterministic-ai-chats branch September 22, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant