Skip to content

test: require usable private homes after sign-in without data - #1620

Merged
joepio merged 1 commit into
developfrom
codex/private-drive-coverage
Sep 22, 2026
Merged

joepio merged 1 commit into
developfrom
codex/private-drive-coverage

Conversation

@joepio

@joepio joepio commented Sep 22, 2026

Copy link
Copy Markdown
Member

Signing in with a valid secret and no recoverable data currently selects the derived private-drive DID without creating a readable home. Existing E2Es require that recovery roadblock and accept a DID in localStorage as proof of a place to write.

This replaces those expectations with exact-home readability, document creation and reload persistence, adds legacy-home and persisted-session regressions, and puts the core case in the smoke suite. Sync checks reject unsupported local-cache and remote-copy claims. It removes the label-only status test and duplicate idempotence test, requires exactly one saved home entry, and updates the coverage inventory.

Draft: coverage only; the implementation bugs remain. The corrected assertions are deliberately failing, not skipped or marked as expected failures.

Validation

During the coverage work, before transplanting these changes onto current develop:

  • 28 focused unit tests passed; the new missing-drive summary test failed on the unsupported remote-copy claim.
  • Four Chromium regressions failed: both sign-ins stayed at recovery, a restored session's home remained unreadable, and Sync displayed both misleading claims. Document creation/reload checks are downstream and were not reached.
  • Focused lint/format passed; smoke discovery includes the no-data sign-in test.
  • App/E2E typechecks reported errors in unchanged files.

For this PR, the six-file patch applied cleanly to current develop and git diff --check passed. Runtime tests were not rerun after transplanting. No runtime code changes or unrelated workspace edits are included.

Checklist

  • Add or update tests
  • Update coverage documentation and remaining gaps
  • Fix the exposed implementation bugs before marking ready for review

No API change or release changelog entry; this PR changes regression coverage only.

@joepio
joepio marked this pull request as ready for review September 22, 2026 11:58
@joepio
joepio merged commit 6b1ca6e into develop Sep 22, 2026
3 checks passed
@joepio
joepio deleted the codex/private-drive-coverage branch September 22, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant