Repository navigation
test: require usable private homes after sign-in without data - #1620
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing in with a valid secret and no recoverable data currently selects the derived private-drive DID without creating a readable home. Existing E2Es require that recovery roadblock and accept a DID in localStorage as proof of a place to write.
This replaces those expectations with exact-home readability, document creation and reload persistence, adds legacy-home and persisted-session regressions, and puts the core case in the smoke suite. Sync checks reject unsupported local-cache and remote-copy claims. It removes the label-only status test and duplicate idempotence test, requires exactly one saved home entry, and updates the coverage inventory.
Draft: coverage only; the implementation bugs remain. The corrected assertions are deliberately failing, not skipped or marked as expected failures.
Validation
During the coverage work, before transplanting these changes onto current develop:
For this PR, the six-file patch applied cleanly to current develop and
git diff --checkpassed. Runtime tests were not rerun after transplanting. No runtime code changes or unrelated workspace edits are included.Checklist
No API change or release changelog entry; this PR changes regression coverage only.