Skip to content

Fix local sign-in redirects and passkey settings continuation - #1627

Merged
joepio merged 1 commit into
developfrom
fix/signin-redirect-loop
Sep 22, 2026
Merged

joepio merged 1 commit into
developfrom
fix/signin-redirect-loop

Conversation

@joepio

@joepio joepio commented Sep 22, 2026

Copy link
Copy Markdown
Member

Signing in with an agent secret could briefly show the drive and then leave the app for the SaaS portal. Hosted welcome now keeps local sign-in available, and identity reconciliation discards asynchronous results after the agent or route changes.

Opening account settings to add a passkey preserves a named, validated continuation through unlock. Invitations and requested drives retain priority; ordinary workspace unlock still offers restore/connect-device when data is missing. The route map is documented in browser/data-browser/AUTH_FLOWS.md.

Validation: 43 focused Vitest checks passed, data-browser TypeScript check passed, changed-file lint and formatting passed with existing React Compiler warnings. Real authenticator registration was not exercised.

Paired with the atomic-saas fix/signin-redirect-loop branch.

@joepio
joepio merged commit 8e47fc3 into develop Sep 22, 2026
3 checks passed
@joepio
joepio deleted the fix/signin-redirect-loop branch September 22, 2026 16:48
joepio added a commit that referenced this pull request Sep 24, 2026
The hosted app on app.atomic.place asks node1 for /plugin-list with
credentials: 'include'. Since #1627 a node only sends
Access-Control-Allow-Credentials to origins it serves itself, so the
browser refused the response and the drive's plugins never loaded. The
request is already signed, so same-origin credentials are enough.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant