Repository navigation
Fix local sign-in redirects and passkey settings continuation - #1627
Merged
Merged
Conversation
joepio
added a commit
that referenced
this pull request
Sep 24, 2026
The hosted app on app.atomic.place asks node1 for /plugin-list with credentials: 'include'. Since #1627 a node only sends Access-Control-Allow-Credentials to origins it serves itself, so the browser refused the response and the drive's plugins never loaded. The request is already signed, so same-origin credentials are enough.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signing in with an agent secret could briefly show the drive and then leave the app for the SaaS portal. Hosted welcome now keeps local sign-in available, and identity reconciliation discards asynchronous results after the agent or route changes.
Opening account settings to add a passkey preserves a named, validated continuation through unlock. Invitations and requested drives retain priority; ordinary workspace unlock still offers restore/connect-device when data is missing. The route map is documented in
browser/data-browser/AUTH_FLOWS.md.Validation: 43 focused Vitest checks passed, data-browser TypeScript check passed, changed-file lint and formatting passed with existing React Compiler warnings. Real authenticator registration was not exercised.
Paired with the atomic-saas
fix/signin-redirect-loopbranch.