Repository navigation
Resume file uploads across database leader handoffs - #1628
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing the database leader tab during a file upload left the follower's hash or blob request pending until the 30-second timeout, even after another tab had successfully taken ownership of the database. The staging report surfaced this during profile-picture upload.
Leader announcements now identify their sender. When the uploader or another tab takes over, pending hash/read/blob-store operations can retry once against the new leader. Content-addressed blob writes are safe to repeat after a lost acknowledgement. Other operations fail promptly instead of replaying arbitrary mutations or worker-local session handles. Repeated announcements from the same leader do not replay requests, and legacy announcements remain supported.
Validation: four regression cases failed before the fix; 16 focused Vitest checks now pass, including retry limits, duplicate announcements, cancellation and non-repeatable operations. Library and data-browser TypeScript checks and changed-file lint/format pass. A local Chromium harness exercised all four handoffs using real Web Locks, BroadcastChannel, WASM and OPFS; blobs survived reload.
The exact reported Sentry event was not accessible from this host. This fixes the reproduced handoff failure; a live-but-unresponsive leader that never hands off still has the bounded timeout.