Skip to content

Redesign the Share dialog: email invites, people list, public toggle - #1698

Closed
Polleps wants to merge 4 commits into
developfrom
claude/lucid-hawking-of1zk5
Closed

Polleps wants to merge 4 commits into
developfrom
claude/lucid-hawking-of1zk5

Conversation

@Polleps

@Polleps Polleps commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Implements the new Share dialog designs. The same dialog covers both setups:

  • Hosted (atomic-saas): email field with chips and a role picker. Once you type, the dialog switches to an optional message with Cancel / Send. The footer has a Copy invite link split button with its own role.
  • FOSS (no mail server): an invite-link field with a role picker and a primary Copy invite link button.

Both setups share:

  • People with access: rights set on this resource, each with a Can write / Can read / Remove access menu that saves immediately. The dialog has no Save button any more.
  • You are listed as "(you)" with your account email (hosted) or "Owner" (when you can write the drive).
  • Inherited access: "N more through folder X", which expands with Show.
  • Public: an Off / Read / Write segmented control.
  • Title: "Share resource name".

Hosted mode is detected the same way as before (getManagedPortalUrl()). Sending is POST /api/share/invitations on the control plane (companion PR: https://github.com/ontola/atomic-saas/pull/147, same branch name). The browser signs the normal invite token and the control plane only mails the link, so emailing grants nothing that copying the link wouldn't.

Screenshots are in a comment below.

Deviations from the mockups, to check

  • Row subtitles: the app doesn't know other collaborators' emails or how they joined, so their rows show only a name. The design's "pollon@example.com" and "Joined via invite link" aren't shown, because nothing in the data backs them.
  • Role pickers: these are native <select>s styled as the grey pill, so keyboard, screen readers and phone OS sheets work without extra code.
  • FOSS link field: the link is signed on the first Copy, not on open. Signing a link for a local-only drive also starts peer sync, and just opening the dialog shouldn't do that. Until then the field shows the link prefix, muted. Changing the role clears the link so the next copy signs a new one.
  • Writer rights: "Can write" writes the agent into both the read and write lists.

Other changes

  • Invite-link signing moves from InviteForm into useCreateInviteLink, shared with the Permissions page (which still uses InviteForm and is otherwise unchanged).
  • The first-time profile step before inviting is kept.
  • The private-drive warning is kept above everything.

Related Issues

None linked.

Checklist

  • Add changelog entry (browser/CHANGELOG.md)
  • Add or update tests if needed:
    • Unit tests for the send-invite client.
    • e2e specs updated for the new dialog.
    • Locally, authorization, invite, share menu and chatroom pass. browser-invite.spec.ts fails at the peer-join step, and it fails at the same assertion on unmodified develop, because this sandbox can't reach WebRTC signaling / relays.
  • Update docs if needed (the atomic-saas PR documents the endpoint)

🤖 Generated with Claude Code

https://claude.ai/code/session_01PT7L8bNp1zDsgeyXNzMy9K

The dialog is now one screen instead of an invite form with a separate
"Manage access" view:

- On hosted Atomic, an email field turns addresses into chips; once
  something is typed the dialog switches to an optional message with
  Cancel / Send. The browser signs the usual invite link and asks the
  control plane to mail it (POST /api/share/invitations).
- Without a control plane (FOSS) the invite link is the way in: a link
  field with a role picker and "Copy invite link".
- "People with access" lists rights set here with a Can write / Can read /
  Remove access menu that saves right away, the viewer as "(you)", and
  "N more through <parent>" for inherited rights, expandable with Show.
- Public is an Off / Read / Write segmented control.
- The title is "Share <resource name>".

Invite-link creation moves out of InviteForm into useCreateInviteLink so
the Permissions page and the dialog share it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PT7L8bNp1zDsgeyXNzMy9K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PT7L8bNp1zDsgeyXNzMy9K
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PT7L8bNp1zDsgeyXNzMy9K
@Polleps
Polleps force-pushed the claude/lucid-hawking-of1zk5 branch from 3ba9b56 to 568dca1 Compare September 24, 2026 12:35

Polleps commented Sep 24, 2026

Copy link
Copy Markdown
Collaborator Author

Screenshots

Taken from the running app (local atomic-server + Vite; hosted mode against a local control plane with mock email).

Hosted: overview

Hosted: typing addresses / filled in

Hosted: the email the recipients get (mock mail spool)

FOSS: overview / after copying the link

Inherited people expanded, public set to Read

Mobile (390px): hosted / FOSS

These images are served from commit e6b4eb0, which was force-pushed off this branch, so they are not part of the PR diff or the merge.


Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01PT7L8bNp1zDsgeyXNzMy9K
joepio added a commit that referenced this pull request Sep 24, 2026
# Conflicts:
#	browser/CHANGELOG.md
joepio added a commit that referenced this pull request Sep 24, 2026
joepio added a commit that referenced this pull request Sep 24, 2026
Combines #1549, #1654, #1682, #1684, #1689, #1690, #1691, #1692, #1693, #1694, #1695, #1696, #1697 and #1698, with the conflict resolutions and e2e fixes described in #1699. Tested green on Mancave in run 4576 at 25b124a.

joepio commented Sep 24, 2026

Copy link
Copy Markdown
Member

Landed on develop in c589fc6 via the combined batch #1699, which was tested green on Mancave at this PR's head. Closing, since the squash merge does not mark it merged.


Generated by Claude Code

@joepio joepio closed this Sep 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants