Repository navigation
Drop cached propvals before a replacing Loro import - #1707
Closed
michielbdejong wants to merge 1 commit into
Closed
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
`importLoroUpdate(bytes, replace = true)` rebuilt the LoroDoc but kept the cached propvals. `getLoroDoc()`'s heal pass then wrote every cached key the new snapshot lacked back into the doc as a local change, so a property removed at the source reappeared on this client. Clear the cache first, keeping only server-derived keys, which never live in Loro. Ported from #1705. Refs #1703. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
|
Landed on develop in f0721f0 via the combined batch #1853 (green on Mancave). Closing. Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1703. Ported from #1705 so develop gets the fix without waiting for the plugin-debug stack.
Bug
Resource.importLoroUpdate(bytes, replace = true)inbrowser/lib/src/resource.tsrebuilds the LoroDoc but kept the cached propvals map. The heal pass ingetLoroDoc()then wrote every cached key that the new snapshot lacked back into the doc as a local change. So a property removed on the source came back on this client, and the client never sent that change back.Every full-state replace hits this, not only
/app-write.Fix
Before the rebuild, clear the cache, keeping only server-derived keys (
isDerivedByServer), which never live in Loro. This is the same 8 lines as in #1705.Test
a replacing snapshot drops properties the source removedinbrowser/lib/src/resource.test.ts. It fails without the fix (expected 'Goes away' to be undefined) and passes with it.cd browser/lib && NODE_OPTIONS=--no-experimental-webstorage pnpm test: 959 passed, 1 skipped.🤖 Generated with Claude Code