Repository navigation
Catalog and install review for gated plugins and public endpoints (AS-03) - #1742
michielbdejong wants to merge 3 commits into
Conversation
…eview The catalog reads `hostFeatures.pluginRoutes` and each entry's derived `requires`: plugins that need plugin routes this build doesn't have are hidden, with one line saying how many; plugins that need a higher level (or an unbound listener or sidecar) are marked "Needs public endpoints" with the refusal text of design 0.4. The install review lists every public surface in plain words, the address that becomes the plugin's identity and the level it needs, and disables Install with an inline banner when the node refuses, whether predicted from the gates or thrown by the server as `host-feature-unavailable`. The lib gains `requiresGate` and `checkGate`, so the catalog decides from `requires` with the same rules the install uses, `parsePluginRoutesStatus`, and `http` on `InstallationReview`. Closes #1713 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Conflicts, both sides kept: - routes/IntegrationStore.tsx: the drive-apps count in nothingToDiscover next to #1742's gated catalog (marked releases and their refusals). - locales/en.po: the CatalogApps/FileImport/InstallationConnections entries next to #1742's PublicEndpoints entries; no duplicate msgids. - browser/lib/src/index.ts: #1730's plugin-upload exports next to #1742's checkGate, parsePluginRoutesStatus and requiresGate. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The review dialog resets its refusal in an effect that depends on `show`. The mock returned a new `show` on every render, so the effect cleared the server's 409 refusal right after it was shown, and 'shows the server's 409 refusal' failed whenever the suite ran under load (it passed on its own). The real hook's functions are stable. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…test.tsx The pre-commit lint and format check were skipped when this branch was committed with --no-verify. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Merge note: |
|
Merge-risk triage (2026-09-28). This is a read-only review of this PR's own diff. The rule it applies: nothing that works today may break for existing users or clients, and new behaviour is added alongside the old. The stack is being rebased onto Verdict: SAFE UI only. 🤖 Generated with Claude Code |
|
Closing as part of the plugin-host stack cleanup (Q-101): not needed by atomic-plugins now. See the inventory at #1726 (comment). The branch is kept, and pin candidates are unaffected. Closed by Claude (VPS coordinator) on behalf of Michiel. |
Closes #1713. Stacked on #1732 (which is on #1726).
What changes
Catalog (
routes/IntegrationStore.tsx,chunks/Plugins/catalogGate.ts), fromhostFeatures.pluginRoutesand each entry'srequires(design 0.5):hostFeatures: gated plugins are hidden. One line at the end says "N plugins need server features this server doesn't have."hostFeatureMessage. The card fetches the release manifest to get that text, becauserequiresdoesn't list the surfaces.Install review (
InstallationReviewDialog.tsx, newPublicEndpoints.tsx). This dialog is shared by the Store, the zip upload and the Installation page's update, so all three get:--plugin-routes read-onlyor higher /read-write).checkHostFeaturesor thrown by the server as aHostFeatureUnavailableError(the 409). A generic toast is no longer shown for it. The dialog reads the node's gates itself when the caller hasn't passed them in (usePluginRoutesStatus).Lib (
plugin-manifest-http.ts):requiresGate(requires)andcheckGate(gate, node):checkHostFeaturesis nowcheckGate(httpGate(http), node), so the catalog uses the same rules as an install.parsePluginRoutesStatus(body).InstallationReview.http.Tests
http-refusals.jsoncase, the verdict fromrequiresmatches the verdict from the manifest. ThehostFeaturesparsing is tested too.catalogGate.test.ts: plugins are hidden when the feature isn't compiled or the server is from before the gates. They are marked when the level is too low or a listener isn't bound, and listed when the gates are open.PublicEndpoints.test.tsx: renders the endpoint list fromv3-activitypub.jsonand the address under a routes origin. The review refuses up front when the level is too low. A thrownHostFeatureUnavailableErroris shown inline and disables Install.Screenshots
Taken against a server built from this branch with
--features plugin-routesand started with--plugin-routes read-only. Two v3 releases were published to its catalog: "Public profile" (read-only, listed normally) and "Fediverse actor" (read-write, marked).Screenshots are not attached yet: the gh CLI cannot upload images. Covered at desktop and mobile width: the catalog with the marked plugin, the review refusal banner with Install disabled, the gate level with the first routes, and the rest of the endpoint list.
Not in this PR
🤖 Generated with Claude Code