Repository navigation
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
|
GitGuardian fails here on incident 37585749, which is not from this PR. The flagged commits (4f6fe33, 49ac330, 1d80224) come from #1767 through the base branch. The hit is a false positive: a test fixture in Generated by Claude Code |
Maps the envelope, the critical commit row, its index rows and the Loro oplog, lists every reader of each, and records why critical commits cannot move to Tree::Envelopes only under latest retention.
ce273cd to
720602c
Compare
|
Trekmeester cleanup (Joep agreed, 2026-10-04): closing as stale. Untouched for 2+ weeks and conflicting with develop, or superseded by later work. The branch stays; reopen if this is still needed. |
Requested by Joep · project thread
Before: the storage review said rights, parent and destroy commits are stored three times on the server, and suggested keeping critical commits only in
Tree::Envelopesif rights lookups read from there.After: no code changes. A new section in
planning/auditability-loro-history.mdlists every place a commit is written and every reader of each copy, and explains why neither copy can be removed safely under the defaultlatestretention.How: the payload of a critical commit is stored twice, not three times: once in the envelope and once in the commit row in
Tree::Resources. The third place is the resource's own Loro oplog, which is its state, not a copy of the commit. Rights checks never read commit rows. The rows are read by the destroy replay guard inapply_commit, byget_resource, byall_resources, and by index queries onsubject/signer. Envelopes are read by history attribution,SYNC_DIFF.removeCommits,SYNC_PUSHand vault packs. You can't drop the row, becauselatestdeletes the envelope on the next edit. After a destroy followed by a re-create, the row is then the only local record of the destroy, and the only copy its signature can be checked against. You also can't skip the envelope, because every envelope reader would then need a fallback that finds the row by subject. That is more code than the copy saves, and the copy only lasts until the next edit anyway. The note also records two options for getting the space back later, neither built. It also flags that the tests that pinned the self-contained-row rule on the earlier branch are not on this base.Tests: none run. This PR only changes documentation.