Skip to content

Fix [i18n-404] in the Installation Release section - #1786

Closed
michielbdejong wants to merge 1 commit into
feat/plugin-debugfrom
fix/plugin-debug-installation-catalogs
Closed

michielbdejong wants to merge 1 commit into
feat/plugin-debugfrom
fix/plugin-debug-installation-catalogs

Conversation

@michielbdejong

Copy link
Copy Markdown
Contributor

The Installation page on feat/plugin-debug rendered Pinned to <code>google-calendar@1.2.0</code> [i18n-404:2150] in its Release section.

Cause

The catalogs on feat/plugin-debug were not stale. They were already at the extractor's fixed point for that branch's source: a fresh vite run with .wuchale removed wrote no .po changes. The bug was in the source. feat/plugin-debug still nested the <br /> from … fragment inside the Pinned to paragraph. wuchale gives a nested message like that an index but never writes a catalog entry for it. VersionTitle.tsx and SyncRoute.tsx document the same failure.

#1654 fixed this on develop by splitting the text into two paragraphs. feat/plugin-debug has the old source and the matching old catalogs (Pinned to <0/> {0}).

Change

  • Port Let a second publisher of the same plugin release install it #1654's source hunks for InstallationPage.tsx and InstallationReviewDialog.tsx from develop. The result is byte-identical to develop, so a later merge of develop has nothing to conflict on.
  • Commit the catalogs vite settled on. I followed the steps in AGENTS.md: rm -rf src/locales/.wuchale, ran one vite on a free port, loaded the Installation page, then read the .po diff by hand. Pinned to <0/> {0} becomes obsolete (#~). Pinned to <0/>, from {0} and from are added, the same entries develop has. No real translations are dropped: de/es/fr only had empty msgstrs for the old key.

Screenshots

Desktop and mobile screenshots of the Release section (Pinned to google-calendar@1.2.0 / from https://plugins.example.com/google-calendar/1.2.0) will be attached in a comment. They are not committed, per AGENTS.md.

🤖 Generated with Claude Code

feat/plugin-debug still nested the "from <release>" fragment inside the
"Pinned to" paragraph. wuchale gives that nested message an index but no
catalog entry, so the Release section rendered "[i18n-404:NNNN]". Port
the two-paragraph shape from develop (#1654) to InstallationPage and
InstallationReviewDialog, and commit the catalogs vite settles on for it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

joepio commented Sep 25, 2026

Copy link
Copy Markdown
Member

This can't be batched yet. Its branch conflicts with develop in about 30 files (AppPage, PluginRuns, Kanban, proxyConnections, view-client.js and planning docs), so it looks like it was cut from another stack rather than develop. If it's meant to be a small i18n fix, could it be rebased onto develop, or recreated from develop with only the catalog change? Then it goes into the next batch.


Generated by Claude Code

@michielbdejong

Copy link
Copy Markdown
Contributor Author

Merge-risk triage (2026-09-28)

Verdict: already in develop, can be closed. Every line this PR adds to InstallationPage.tsx is already in develop. The only difference is the .po catalogs, which conflict because develop already carries those strings. The rebase chain drops it.

🤖 Generated with Claude Code

@michielbdejong

Copy link
Copy Markdown
Contributor Author

Closing as part of the plugin-host stack cleanup (Q-101): not needed by atomic-plugins now. See the inventory at #1726 (comment). The branch is kept, and pin candidates are unaffected. Closed by Claude (VPS coordinator) on behalf of Michiel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants