Skip to content

Batch: fresh worktree build (#1830) and external classes in the class picker (#1842) - #1873

Merged
joepio merged 6 commits into
developfrom
trekmeester/combined-20260928
Sep 29, 2026
Merged

joepio merged 6 commits into
developfrom
trekmeester/combined-20260928

Conversation

@joepio

@joepio joepio commented Sep 28, 2026

Copy link
Copy Markdown
Member

Before: Michiel's #1830 and #1842 sat open. #1830 was left out of the 25 Sep batch for a TS7016 type error and #1842 for an unhandled rejection in its SearchBox test, and both fell 47 to 51 commits behind develop.

After: both sit on current develop, merged as they are, so one Mancave run decides them.

Both merge cleanly with develop. Locally on this branch: pnpm run -r lint is clean, pnpm run -r typecheck passes with the Website runtime bundles both absent and generated, and the SearchBox tests passed 6 of 6, six runs in a row. Neither earlier failure reproduced here, so the CI run on this exact head is the test.

How: trekmeester/combined-20260928, built off develop eaa48be with a merge commit per PR. Merging this squash-closes #1830 and #1842 by hand afterwards, once their heads are checked unchanged.


Generated by Claude Code

Michiel de Jong and others added 6 commits September 25, 2026 15:36
- build:wasm: drop the `cargo bin` alias. Cargo concatenates array config
  values from every parent `.cargo/config.toml`, so in a worktree nested in
  the main checkout the alias doubled into `run -p cargo-bin -- run ...`
  ("No package found for binary run"). The script now runs the shim package
  directly, which installs wasm-pack into the worktree's own `.bin/`.
- Website runtime bundles are gitignored and generated by a vite plugin on
  every vite / vitest start, instead of committed copies that had drifted
  from their sources and got rewritten by every build.
- data-browser vitest: a setup file restores jsdom's localStorage and
  sessionStorage, which Node 25+'s built-in Web Storage shadows.
- Remove @tomic/lib's devDependency on @tomic/cli. The cycle let pnpm build
  cli concurrently with lib; `pnpm run -r build` is now ordered.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The picker's search goes to the server, which only indexes the drive and
atomicdata.dev, so a shared class published elsewhere (atomic-plugins
Pages) was only reachable by pasting its URL. The search window now also
matches external classes the store has already fetched, on shortname,
name and description, drops the ones the server returned too, and shows
each one's origin next to its title. Pasting a URL still selects it.

Closes #1839

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@joepio
joepio merged commit 95963c6 into develop Sep 29, 2026
8 checks passed
@joepio
joepio deleted the trekmeester/combined-20260928 branch September 29, 2026 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant