Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joep · project thread
Fixes #2089
Fixes #2093
Before: editing only the end time of a multi-day timed calendar event moved its end date back to the start day (or the next day), so four nights became one. A JSON filter with the exact text of a saved value matched nothing unless its keys were in alphabetical order.
After: the end date stays where it was and only the time changes. A JSON filter value is rewritten with sorted keys and no whitespace when you leave the field, which is how the index stores it, so the text of a saved value matches its row.
How:
saveTimesnow reads the stored end first and keeps its day offset (daysSpanned/endDayForincalendarRows.ts); a same-day event whose end is at or before the start still ends the next day.TableFilterValueInputnormalizes JSON values through the newcanonicalJson. Both have unit tests, and the typecheck and formatter pass. Not run in the browser, so there are no screenshots; neither change adds new UI.Generated by Claude Code