Repository navigation
Share TablePage view-query compilation and resolve timer defaults - #2508
Closed
michielbdejong wants to merge 1 commit into
Closed
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
michielbdejong
marked this pull request as draft
November 13, 2026 16:03
This was referenced Nov 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structurally split — superseded by #2543 (code moves) and #2544 (functionality improvements).
The improvement child’s full Git tree matches this original head exactly. Original refs/review history are preserved. The pair uses this PR’s legacy base for review; later restacking remains necessary and it is not a prerequisite of the independent clean extraction #2536. This is a structural content split, not completion of the whole TablePage port. The original description follows.
Mixed extraction and behavior changes — held for separation.
This branch combines moved UI/model/query code with changed validation, scope, recovery or state behavior. Those changes must be separated before this PR is ready: move the existing complete TablePage first, preserving behavior, then review improvements as follow-ups. The original branch and validation are preserved below; the current legacy stack is not a completed clean split and must not be merged as the TablePage extraction.
See the revised scope.
A valued filter on a missing computed column was silently skipped, and implicit timer duration was resolved for the grid separately from row filters and totals. Add a shared configuration-to-query compiler and use it in the actual Atomic TablePage. Unresolved expressions, invalid numeric values and unsupported computed operators make the query unavailable. Explicit empty derived-column settings retain their meaning. Rows and totals now reuse one compiled aggregation, and the timer supplies the same default expression.
Validation: 126 package tests; 184 Atomic adapter/formula regressions against the real WASM engine; package/host types; clean packed external consumer; and the normal staged workspace lint hook passed. Edited hooks compile cleanly. TableResource retains the identical pre-existing compiler suppression at its baseline. The actual TablePage was tested with a local-only drive: a removed computed-column filter hides the renderer, repair restores it, and settings survive reload. Desktop/mobile screenshots were shown in chat. All four translation diffs only add source references for existing messages.
This continues the full TablePage extraction. Standalone dashboard-block queries, remaining configuration UI and built-in renderer/page orchestration remain open; no new native backend capability is claimed.