Repository navigation
Record confirmed full syncs with Iroh peers - #2564
Open
michielbdejong wants to merge 1 commit into
Open
michielbdejong wants to merge 1 commit into
michielbdejong wants to merge 1 commit into
Conversation
Member
|
Complexity review of this PR together with #2559, which it stacks on. Combined they are +3,317 / −223. The main point: "this copy holds everything I have" is built twice, in two layers and two ways.
Both paths answer the same question that the reconcile in
Smaller points:
Generated by Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #2559. Previous peer activity could reflect a transfer that stopped after the file metadata arrived.
The two-node Iroh regression transfers a file and records a date, then disconnects during a second file write after its metadata has arrived. It checks that the second file’s bytes are absent and the previous date is unchanged.
Locally verified with the focused Rust full-sync tests, the existing Iroh probe-hit test, the Chromium Sync settings test, and the drive protection and server helper unit tests.