Repository navigation
Conversation
NewIdentitySection replaced the guest agent without handing its drives over, and the reconcile gate skips /app/welcome, so the guest's drives vanished after portal sign-up. Use prepareIdentitySwitch before the switch and applyBroughtAlong once the new home exists.
joepio
marked this pull request as ready for review
November 17, 2026 21:14
The hand-over ran inside account creation without a guard, so a refused grant would have stopped the sign-up with an error. The guest key is archived first and the reconcile gate retries, so continue and only warn.
Member
Author
|
Self-review, read critically. The checks that ran on this PR are the Flutter package jobs only; the browser suite does not run on PRs. I dispatched Fixed in a follow-up commit (effaa6a)
For the reviewer
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joep · project thread
What was wrong
Found while walking real user flows on a local stack (atomic-server + vite + atomic-saas portal).
/app/welcome?from_portal=true.The work looked lost, while
planning/identity-bring-along.mdsays a guest's work always comes along and the guest checklist itself says "Save your work: sign up with your email".Cause
NewIdentitySection.handleCreatereplaced the guest agent with the freshly made one (store.setAgent) without handing the guest's drives over, andIdentityReconcileGateskips/app/welcome, so nothing else caught the switch. The guest key was not archived either.Fix
No second mechanism: before the switch,
handleCreatecalls the existingprepareIdentitySwitch(archives the old key, applies the existing "has work" rule, hands a guest's drives over without asking). Once the new home drive exists it callsapplyBroughtAlong, which imports the local-only drives and lists them in the new home. If that fails it only warns; the pending record stays and the reconcile gate retries. An identity that is not a guest is only archived, never handed over unasked, as on secret sign-in.Verified
NewIdentitySection.test.tsx(3 tests; 2 failed before the fix). WithbringAlong.test.ts,views/getting-startedandIdentityReconcileGate.test.tsx: 5 files, 57 tests pass.pnpm typecheckclean.bring-along.spec.tsis the model for the FOSS side).No UI text or layout changed, so there are no screenshots.
Checklist
browser/CHANGELOG.md)planning/identity-bring-along.mdupdated