Repository navigation
Conversation
# Conflicts: # rust/src/api/spaceman.rs # rust/src/core/scan.rs
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Joep
You no longer have to wait for a scan to finish before picking what to remove. This PR also stops the macOS Data volume from being counted twice when scanning
/.Select and remove while scanning
≥ 12 GBin rows, the treemap, the selection bar and Clean up. The confirmation then says "This frees at least …".ENOENT(a folder or file removed mid-walk) as "not there" instead of an error or an unreadable folder.Firmlinks (macOS)
/Users,/Applications,/Library,/private,/usr/local, … are firmlinks to the same folders under/System/Volumes/Data, on the same device, sosame_filesystemdidn't stop the second walk.core::firmlinksreads/usr/share/firmlinks(with a built-in copy as fallback). For a scan whose root contains the Data volume, it lists the Data-side copies that the scan also reaches through the firmlink, and the scanner skips those, for fresh and cached listings alike. Data-only content under/System/Volumes/Datais still counted./System/Volumes/VM,Prebootetc. have their own device and were already skipped.Scanning
/on this Mac (Google Drive's CloudStorage left out of both runs):dfreports 821 GB used (Data volume 808 GB + system volume 13 GB), so "not scanned" is positive again.Tests
formatSize.