JSON view block #74

Activity

1. vladfaust

   added

   bug

   on Mar 24, 2019
2. vladfaust

   added this to the next patch milestone on Mar 24, 2019
3. vladfaust

   self-assigned this

   on Mar 24, 2019
4. vladfaust

   added a commit that references this issue on Apr 9, 2019

   fix (View): properly handle inline blocks

   ...

   This issue will close once commit 9e60b18 is merged into the 'master' branch.

   9e60b18
5. vladfaust

   closed this as completedin 9e60b18on Apr 16, 2019
6. vladfaust commented on May 13, 2019

   

   vladfaust

   on May 13, 2019

   MemberAuthor

   More actions

   Also doesn't work for

   json tips: @tips.map do |tip|
     View::Tip.new(tip)
   end

      7.     def render_to_application_json(io : IO)
   >  8.       ({tips: @tips.map}).to_json(io)
      9.     end
   
   'Array(Models::Tip)#map' is expected to be invoked with a block, but no block was given
   
7. vladfaust

   reopened this on May 13, 2019
8. vladfaust commented on May 28, 2019

   

   vladfaust

   on May 28, 2019

   MemberAuthor

   More actions

   Should put more thought into it. Given:

   json content_type: "application/json-a" do
     builder do
       field "foo", @foo
       field "bar", @bar
     end
   end

   What if I just wanted to add builder block arg?

   json content_type: "application/json-a" do |builder|
     builder do
       field "foo", @foo
       field "bar", @bar
     end
   end
9. vladfaust

   removed this from the 0.7.2 milestone on May 28, 2019