Conversation
… model The interface-segregation refactor moved GetParameters / SetParameters / ParameterCount / WithParameters off IFullModel and onto the separate IParameterizable interface. EWC and Synaptic Intelligence guard-require it via InterfaceGuard.Parameterizable (correctly — EWC's Fisher information matrix and SI's per-parameter importance are both computed OVER the model's parameters, so a model without trainable parameters cannot participate). The CLMockModel test fixture still declared only IFullModel, so the runtime `model is IParameterizable<...>` check failed and threw "CLMockModel does not implement IParameterizable<...>" from PrepareForTask — failing all 14 EWC/SI deep-math integration tests. The mock already implements every IParameterizable member (GetParameters, SetParameters, ParameterCount, SupportsParameterInitialization, WithParameters, SanitizeParameters); it just needed to declare the interface so the cast succeeds. No assertion or expected value changed. All 36 ContinualLearningDeepMath tests pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Owner
Author
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the continual-learning cluster in the Integration C shard from the PR #1563 failing-CI list — 14
ElasticWeightConsolidation/SynapticIntelligencedeep-math integration tests (in my hand-off lane from #1562; does not touch any files #1562 owns).Root cause (one shared bug): the interface-segregation refactor moved
GetParameters/SetParameters/ParameterCount/WithParametersoffIFullModelonto the separateIParameterizableinterface. EWC and SI guard-require it viaInterfaceGuard.Parameterizable— correctly, since EWC's Fisher information matrix and SI's per-parameter importance are both computed over the model's parameters, so a model with no trainable parameters cannot participate. TheCLMockModeltest fixture still declared onlyIFullModel, so the runtimemodel is IParameterizable<...>check failed:Fix: declare
IParameterizable<double, Tensor<double>, Tensor<double>>onCLMockModel. The mock already implements every member of that interface (GetParameters,SetParameters,ParameterCount,SupportsParameterInitialization,WithParameters,SanitizeParameters) — it just needed to declare it so the cast succeeds.This is a fixture completing an interface it already implements. No production code is changed, and no assertion or expected value is weakened — the production requirement (EWC/SI need
IParameterizable) is correct and stays.Verification
All 36
ContinualLearningDeepMathIntegrationTestspass locally (net10.0, Release) — the 14 previously-failing EWC/SI tests plus the 22 that already passed.🤖 Generated with Claude Code