fix(us-bf-031): resolve optimizer type conversion errors

[ooples]

User Story

References: US-BF-031

Summary

This PR addresses critical type conversion errors in optimizer classes by adding a missing API method and updating constructors to match the new model-centric architecture.

Key Changes

1. OptimizerBase.cs - Critical API Addition

Added missing InitializeRandomSolution(TInput) overload:

protected virtual IFullModel<T, TInput, TOutput> InitializeRandomSolution(TInput xTrain)
{
    return CreateSolution(xTrain);
}

Impact: This resolves CS1503 errors where Vector<T> was being passed to methods expecting IFullModel<T, TInput, TOutput> across all 31+ optimizers that call this method.

2. Optimizer Constructor Updates

Fixed constructors to accept model parameter as required by base class:

Fixed Optimizers:

• ProximalGradientDescentOptimizer
• GradientDescentOptimizer
• StochasticGradientDescentOptimizer
• RootMeanSquarePropagationOptimizer
• PowellOptimizer
• TrustRegionOptimizer
• ADMMOptimizer
• AMSGradOptimizer

All now follow pattern:

public XxxOptimizer(
    IFullModel<T, TInput, TOutput> model,
    XxxOptimizerOptions<T, TInput, TOutput>? options = null)
    : base(model, options ?? new())

Error Reduction

• Before: 740+ compilation errors
• After: Significant reduction in CS7036 and CS1503 errors
• Remaining: ~10 more optimizers need similar constructor fixes (will be addressed in follow-up PRs)

Technical Details

The root cause was an API evolution:

1. OptimizerBase now requires a model in its constructor
2. The base class stores this model in a _model field
3. Optimizers call InitializeRandomSolution(xTrain) expecting a model back
4. The overload was missing, causing type mismatches

This PR provides the foundation fix that will cascade to resolve errors across the entire optimizer hierarchy.

Testing

• ✅ Build succeeds for modified files
• ✅ No new warnings introduced
• ✅ Type safety improved (no more Vector<T> to IFullModel implicit conversions)

Remaining Work

The following optimizers still need constructor updates (tracked separately):

• BayesianOptimizer
• BFGSOptimizer
• CMAESOptimizer
• ConjugateGradientOptimizer
• CoordinateDescentOptimizer
• DFPOptimizer
• FTRLOptimizer
• LBFGSOptimizer
• LevenbergMarquardtOptimizer
• MiniBatchGradientDescentOptimizer
• NelderMeadOptimizer
• NewtonMethodOptimizer
• NormalOptimizer

Additionally, non-optimizer files have separate issues:

• AutoMLModelBase.cs (LoadFromFile method)
• VectorModel.cs (argument order issues)
• PredictionModelResult.cs (GetModelMetadata method)

Acceptance Criteria Met

• ✅ Type conversion errors resolved for modified optimizers
• ✅ Build passes for affected files
• ✅ No new warnings introduced
• ⏳ Complete resolution pending remaining constructor fixes

🤖 Generated with Claude Code

[Copilot]

Pull Request Overview

This PR resolves type conversion errors in optimizer classes by adding a missing API method and updating constructors to align with the new model-centric architecture. The changes address CS1503 and CS7036 compilation errors by ensuring optimizers properly accept and pass the required model parameter to their base class.

Key Changes:

• Added InitializeRandomSolution(TInput) overload to OptimizerBase to resolve type mismatches
• Updated 8 optimizer constructors to accept IFullModel<T, TInput, TOutput> model parameter
• Standardized constructor patterns across affected optimizers

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
OptimizerBase.cs	Adds missing InitializeRandomSolution(TInput) method that returns IFullModel instead of Vector<T>
GradientDescentOptimizer.cs	Updates constructor to accept and pass model parameter to base class
StochasticGradientDescentOptimizer.cs	Updates constructor to accept and pass model parameter to base class
RootMeanSquarePropagationOptimizer.cs	Updates constructor to accept and pass model parameter to base class
ProximalGradientDescentOptimizer.cs	Updates constructor to accept and pass model parameter to base class
PowellOptimizer.cs	Updates constructor to accept and pass model parameter to base class
TrustRegionOptimizer.cs	Updates constructor to accept and pass model parameter to base class
ADMMOptimizer.cs	Updates constructor to accept and pass model parameter to base class
AMSGradOptimizer.cs	Updates constructor to accept and pass model parameter to base class

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}