Skip to content

fix: add missing model parameter to NelderMeadOptimizer constructor - #207

Merged
ooples merged 2 commits into
merge-dev2-to-masterfrom
fix/neldermead-constructor
Oct 24, 2025
Merged

ooples merged 2 commits into
merge-dev2-to-masterfrom
fix/neldermead-constructor

Conversation

@ooples

@ooples ooples commented Oct 24, 2025

Copy link
Copy Markdown
Owner

Summary

  • Fix CS7036 constructor error in NelderMeadOptimizer.cs at line 75
  • Add missing IFullModel<T, TInput, TOutput> model parameter to constructor
  • Update base constructor call to pass both model and options parameters
  • Follows the same pattern established in US-BF-027 and US-BF-028 fixes

Changes

  • Updated NelderMeadOptimizer constructor signature to include model parameter
  • Updated XML documentation to document the new parameter
  • Removed outdated parameter documentation (predictionOptions, modelOptions, etc.)
  • Changed base constructor call from base(options ?? new()) to base(model, options ?? new())

Test plan

  • Verify NelderMeadOptimizer.cs builds without CS7036 error
  • Run full test suite to ensure no regressions
  • Verify optimizer instantiation works correctly with model parameter

Related Issues

Part of the metaheuristic optimizer constructor updates following OptimizerBase refactoring

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings October 24, 2025 02:54

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compilation error (CS7036) in the NelderMeadOptimizer constructor by adding the missing model parameter. This aligns the constructor signature with the refactored OptimizerBase class, which now requires a model parameter in its constructor call.

  • Added model parameter to NelderMeadOptimizer constructor
  • Updated base constructor call to pass both model and options
  • Cleaned up outdated XML documentation for removed parameters

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ooples
ooples merged commit ef12e6a into merge-dev2-to-master Oct 24, 2025
0 of 2 checks passed
@ooples
ooples deleted the fix/neldermead-constructor branch October 24, 2025 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants