Skip to content

docs(activation): clarify temperature conversion - #2204

Merged
ooples merged 4 commits into
masterfrom
test/ci-production-canary-20260915
Sep 26, 2026
Merged

ooples merged 4 commits into
masterfrom
test/ci-production-canary-20260915

Conversation

@ooples

@ooples ooples commented Sep 15, 2026 •

Copy link
Copy Markdown
Owner

Production CI-routing acceptance canary after #2197. One inline comment changes in a mapped source file; executable code is unchanged. Uses the ordinary master-certified map with no workflow or trust overrides. Master audit 34919418484 passed and certified the map with zero historical misses. Expected shard matrix: Integration A-B plus mandatory Integration D, 2/116. Actual selection and merge-reuse results are pending. Created ready to exercise the genuine PR event rather than draft-skipped CI. Integration D runtime diagnosis remains separate in existing PRs #2183/#2112.

Summary by CodeRabbit

  • Documentation
    • Clarified the constructor comment for the temperature setting.
    • No runtime behavior or public functionality changed.

@vercel

vercel Bot commented Sep 15, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
aidotnet_website Ready Ready Preview Sep 26, 2026 3:39am UTC
1 Skipped Deployment
Project Deployment Actions Updated
aidotnet-playground-api Ignored Ignored Preview Sep 26, 2026 3:39am UTC

@coderabbitai

coderabbitai Bot commented Sep 15, 2026 •

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: ooples/AiDotNet/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 3bb1f22d-14eb-486b-bc56-f8c84427f76b

📥 Commits

Reviewing files that changed from the base of the PR and between e373fda and 0b3eb49.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: dc7a698f-3fa7-42f7-9661-c1f1a9057e59

📥 Commits

Reviewing files that changed from the base of the PR and between 7c43269 and 23a2575.

📒 Files selected for processing (1)
  • src/ActivationFunctions/GumbelSoftmaxActivation.cs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The pull request updates the _temperature assignment comment in the Gumbel-Softmax activation constructor. Runtime behavior and public declarations remain unchanged.

Changes

Gumbel-Softmax Comment Update

Layer / File(s) Summary
Temperature assignment documentation
src/ActivationFunctions/GumbelSoftmaxActivation.cs
The constructor comment for _temperature is updated. The assignment behavior remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e373f

This comment-only update introduces no identified production or CI-routing risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the documentation change that clarifies temperature conversion in the activation function.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/ci-production-canary-20260915

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A comment shifts its place
The temperature keeps its pace
No runtime paths bend
No public symbols amend
One clear note now guides the trace

Comment @coderabbitai help to get the list of available commands.

@ooples

ooples commented Sep 15, 2026

Copy link
Copy Markdown
Owner Author

Live production selection proof: https://github.com/ooples/AiDotNet/actions/runs/34919695471/job/104225032304 passed. At 02:05:01 UTC it accepted master-certified map run 34919418484; at 02:06:23 UTC it selected 2 of 116 shards. No proof-branch map override is present. Build/test completion and post-merge validation reuse remain pending; selection alone is not passing test evidence.

@ooples

ooples commented Sep 15, 2026

Copy link
Copy Markdown
Owner Author

Live merge-reuse evidence: isolated PR #2206 merged the identical head/tree using unchanged production workflows and normal master map trust. Run https://github.com/ooples/AiDotNet/actions/runs/34964852374 resolver accepted source run 34919695471, reuse_scope=Validation, execute_validation=false, reused_requires_validation=true. GitHub skipped shard selection, both builds, the test matrix, parameter sweeps, and model-shape conformance. Baseline publication and CodeQL/Sonar remain enabled because the source has a Validation certificate, not Complete. Source Integration A-B and Integration D both passed. This proves live suppression of duplicate validation on a real isolated branch merge; #2204 itself remains unmerged on master due to the Sonar runner failure. Retrying only Sonar and dependents, not the tests. Final quality/baseline outcomes pending.

These write-ups should never have been committed. Removed here so the file does not
arrive on master when this PR merges; .gitignore gains matching rules in #2224.

Deliberately untouched: ci-proof/nonruntime-routing-canary.md, which is functional
rather than a write-up (it exercises the permanent ci-proof/** workflow trigger).

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GYQycGHKxLFBqhEtPMHz29
ooples pushed a commit that referenced this pull request Sep 18, 2026
PR #2223 changed one file - website/package-lock.json - and ran all 164
shards. website/ is the documentation site: on master it holds zero .cs and
zero .csproj files, appears nowhere in AiDotNet.sln, and its pipelines are
already listed as independent non-runtime workflows. The classifier had no
entry for it, so the path fell through to MapCandidate, found no coverage, and
escalated.

NonRuntimeDirectories is an allowlist, checked after shared infrastructure so a
build file keeps its meaning wherever it sits, and before the markdown and
map-candidate rules so a non-product tree is spared whatever its extension.

Assert-NonRuntimeDirectories is the trip-wire. The entry is trusted because the
tree contains nothing the solution compiles, which is a fact about today rather
than a law, and the cost of it quietly ceasing to be true is tests skipped on a
change that needed them. It is re-checked on every self-test run instead of
being remembered.

The self-test now pins classification to four real pull requests rather than to
a synthetic map, because every failure this feature has shipped was a
classification failure and none of them were visible from the synthetic one:
#1889 which ran 1 shard, #2223 which ran 164, #2204 which ran 49 and #2098
which ran 161. Verified as a control arm: with the directory check removed the
suite fails on exactly the two #2223 paths and names the wrong classification.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@ooples
ooples merged commit 3eb874f into master Sep 26, 2026
70 checks passed
@ooples
ooples deleted the test/ci-production-canary-20260915 branch September 26, 2026 15:28

This branch was successfully deployed

2 active (1 outdated) deployments
Preview – aidotnet_website — 0b3eb490 Deployed Sep 26, 2026 by vercel[bot]
Preview – aidotnet-playground-api — 23a2575f Deployed Sep 15, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants