feat: allow specialized trading transition execution - #2242
Conversation
…/ooples/AiDotNet into fix/trading-environment-step-overrides
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: ooples/AiDotNet/.coderabbit.yaml Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…t-masking-merge into fix/trading-env-reviewed
…mit from GitHub Matching merge commits by message replayed a pull request into another branch (#2242, into feat/legal-action-mask) against an unrelated master commit, and treated it as open when nothing matched. The replay now asks gh for the state, base branch and merge commit, skips pull requests into another branch and closed ones, and reports gh's own error when it cannot describe one. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017otuSGr3GdmvPoYLbiaWR2
Make TradingEnvironment.Step virtual so a derived environment can implement a complete OHLC transition, including protective exits and the resulting reward, through the common environment reference. The default transition is unchanged.
Rebased by merging the reviewed masking branch (#2226); the diff against that branch is one keyword. Final head e48d28c passes 61 focused environment/masking tests on net10.0. Downstream AdminClient #225 separately covers virtual dispatch, stop/target reward changes and conservative fills with falsification.
Stacked on #2226.