Skip to content

feat: allow specialized trading transition execution - #2242

Merged
ooples merged 3 commits into
feat/legal-action-maskfrom
fix/trading-environment-step-overrides
Sep 22, 2026
Merged

ooples merged 3 commits into
feat/legal-action-maskfrom
fix/trading-environment-step-overrides

Conversation

@ooples

@ooples ooples commented Sep 22, 2026 •

Copy link
Copy Markdown
Owner

Make TradingEnvironment.Step virtual so a derived environment can implement a complete OHLC transition, including protective exits and the resulting reward, through the common environment reference. The default transition is unchanged.

Rebased by merging the reviewed masking branch (#2226); the diff against that branch is one keyword. Final head e48d28c passes 61 focused environment/masking tests on net10.0. Downstream AdminClient #225 separately covers virtual dispatch, stop/target reward changes and conservative fills with falsification.

Stacked on #2226.

@vercel

vercel Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
aidotnet_website Ready Ready Preview Sep 22, 2026 3:11pm UTC
1 Skipped Deployment
Project Deployment Actions Updated
aidotnet-playground-api Ignored Ignored Preview Sep 22, 2026 3:11pm UTC

@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (2)
  • master
  • integration/.*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: ooples/AiDotNet/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Advanced

Run ID: 0b298f7f-aa4b-4b0e-a685-2b17c3201fc3

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

…t-masking-merge into fix/trading-env-reviewed
@ooples
ooples marked this pull request as ready for review September 22, 2026 15:13
@ooples
ooples merged commit 5c281c3 into feat/legal-action-mask Sep 22, 2026
24 of 28 checks passed
@ooples
ooples deleted the fix/trading-environment-step-overrides branch September 22, 2026 15:13
ooples added a commit that referenced this pull request Oct 1, 2026
…mit from GitHub

Matching merge commits by message replayed a pull request into another branch (#2242, into
feat/legal-action-mask) against an unrelated master commit, and treated it as open when nothing
matched. The replay now asks gh for the state, base branch and merge commit, skips pull requests
into another branch and closed ones, and reports gh's own error when it cannot describe one.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_017otuSGr3GdmvPoYLbiaWR2

This branch was successfully deployed

2 active (1 outdated) deployments
Preview – aidotnet_website — e48d28cf Deployed Sep 22, 2026 by vercel[bot]
Preview – aidotnet-playground-api — 5d167294 Deployed Sep 22, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant